Changeset 64766 in vbox for trunk/src/VBox/HostDrivers/VBoxNetFlt/win

Timestamp:

Nov 30, 2016 10:59:48 AM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

112111

Message:

src/VBox: Make the use of the iterator for RTListForEach()/RTListForEachSafe() more obvious. There is no need to initialize the iterator and we also must not depend on the iterator being NULL if the list was empty.

Location:

trunk/src/VBox/HostDrivers/VBoxNetFlt/win/drv

Files:

• VBoxNetFltRt-win.cpp (modified) (1 diff)
• VBoxNetLwf-win.cpp (modified) (2 diffs)

trunk/src/VBox/HostDrivers/VBoxNetFlt/win/drv/VBoxNetFltRt-win.cpp

@@ -3373 +3373 @@
         NdisAcquireSpinLock(&g_VBoxNetFltGlobalsWin.lockFilters);
         /* At this point the list must contain at least one element. */
-        PVBOXNETFLTWIN pFilter   = NULL;
         PVBOXNETFLTINS pInstance = NULL;
+        PVBOXNETFLTWIN pFilter;
         RTListForEach(&g_VBoxNetFltGlobalsWin.listFilters, pFilter, VBOXNETFLTWIN, node)
         {

trunk/src/VBox/HostDrivers/VBoxNetFlt/win/drv/VBoxNetLwf-win.cpp

@@ -233 +233 @@
     unsigned cMaxModules = (ERROR_LOG_MAXIMUM_SIZE - FIELD_OFFSET(IO_ERROR_LOG_PACKET, DumpData)) / sizeof(RTMAC);
     unsigned cModules = 0;
-    PVBOXNETLWF_MODULE pModuleCtx = NULL;
+    PVBOXNETLWF_MODULE pModuleCtx;
     NdisAcquireSpinLock(&g_VBoxNetLwfGlobals.Lock);
     RTListForEach(&g_VBoxNetLwfGlobals.listModules, pModuleCtx, VBOXNETLWF_MODULE, node)
@@ -2549 +2549 @@
     AssertReturn(pThis, VERR_INVALID_PARAMETER);
     Log(("vboxNetFltOsInitInstance: trunk name=%s\n", pThis->szName));
-    PVBOXNETLWF_MODULE pModuleCtx = NULL;
     NdisAcquireSpinLock(&g_VBoxNetLwfGlobals.Lock);
+    PVBOXNETLWF_MODULE pModuleCtx;
     RTListForEach(&g_VBoxNetLwfGlobals.listModules, pModuleCtx, VBOXNETLWF_MODULE, node)
     {