Changeset 64766 in vbox for trunk/src/VBox/Runtime/common/dvm

Timestamp:

Nov 30, 2016 10:59:48 AM (8 years ago)

Author:

vboxsync

Message:

src/VBox: Make the use of the iterator for RTListForEach()/RTListForEachSafe() more obvious. There is no need to initialize the iterator and we also must not depend on the iterator being NULL if the list was empty.

File:

• trunk/src/VBox/Runtime/common/dvm/dvm.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/common/dvm/dvm.cpp

@@ -348 +348 @@
                     if (RT_FAILURE(rc))
                     {
+                        /* Remove all entries. */
                         PRTDVMVOLUMEINTERNAL pItNext, pIt;
-
-                        /* Remove all entries. */
                         RTListForEachSafe(&pThis->VolumeList, pIt, pItNext, RTDVMVOLUMEINTERNAL, VolumeNode)
                         {
@@ -491 +490 @@
                && !fAllocated)
         {
-            PRTDVMVOLUMEINTERNAL pVol;
             bool fVolFound = false;
             uint64_t cbIntersect;
@@ -503 +501 @@
              * contigous on the medium.
              */
+            PRTDVMVOLUMEINTERNAL pVol;
             RTListForEach(&pThis->VolumeList, pVol, RTDVMVOLUMEINTERNAL, VolumeNode)
             {