Changeset 64766 in vbox for trunk/src/VBox/Storage/testcase

Timestamp:

Nov 30, 2016 10:59:48 AM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

112111

Message:

src/VBox: Make the use of the iterator for RTListForEach()/RTListForEachSafe() more obvious. There is no need to initialize the iterator and we also must not depend on the iterator being NULL if the list was empty.

File:

• trunk/src/VBox/Storage/testcase/tstVDIo.cpp (modified) (8 diffs)

trunk/src/VBox/Storage/testcase/tstVDIo.cpp ¶

@@ -1717 +1717 @@
 
     /* Check for the file. */
-    PVDFILE pIt = NULL;
     bool fFound = false;
+    PVDFILE pIt;
     RTListForEach(&pGlob->ListFiles, pIt, VDFILE, Node)
     {
@@ -1943 +1943 @@
 
     /* Check for the file. */
-    PVDFILE pIt = NULL;
     bool fFound = false;
+    PVDFILE pIt;
     RTListForEach(&pGlob->ListFiles, pIt, VDFILE, Node)
     {
@@ -1976 +1976 @@
 
     /* Check for the file. */
-    PVDFILE pIt = NULL;
     bool fFound = false;
+    PVDFILE pIt;
     RTListForEach(&pGlob->ListFiles, pIt, VDFILE, Node)
     {
@@ -2056 +2056 @@
 
     /* Check if the file exists. */
-    PVDFILE pIt = NULL;
+    PVDFILE pIt;
     RTListForEach(&pGlob->ListFiles, pIt, VDFILE, Node)
     {
@@ -2151 +2151 @@
 
     /* Check if the file exists. */
-    PVDFILE pIt = NULL;
+    PVDFILE pIt;
     RTListForEach(&pGlob->ListFiles, pIt, VDFILE, Node)
     {
@@ -2182 +2182 @@
 
     /* Check if the file exists. */
-    PVDFILE pIt = NULL;
+    PVDFILE pIt;
     RTListForEach(&pGlob->ListFiles, pIt, VDFILE, Node)
     {
@@ -2586 +2586 @@
 static PVDDISK tstVDIoGetDiskByName(PVDTESTGLOB pGlob, const char *pcszDisk)
 {
-    PVDDISK pIt = NULL;
     bool fFound = false;
 
     LogFlowFunc(("pGlob=%#p pcszDisk=%s\n", pGlob, pcszDisk));
 
+    PVDDISK pIt;
     RTListForEach(&pGlob->ListDisks, pIt, VDDISK, ListNode)
     {
@@ -2614 +2614 @@
 static PVDPATTERN tstVDIoGetPatternByName(PVDTESTGLOB pGlob, const char *pcszName)
 {
-    PVDPATTERN pIt = NULL;
     bool fFound = false;
 
     LogFlowFunc(("pGlob=%#p pcszName=%s\n", pGlob, pcszName));
 
+    PVDPATTERN pIt;
     RTListForEach(&pGlob->ListPatterns, pIt, VDPATTERN, ListNode)
     {