Changeset 64766 in vbox for trunk/src/VBox/VMM/VMMR3

Timestamp:

Nov 30, 2016 10:59:48 AM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

112111

Message:

src/VBox: Make the use of the iterator for RTListForEach()/RTListForEachSafe() more obvious. There is no need to initialize the iterator and we also must not depend on the iterator being NULL if the list was empty.

Location:

trunk/src/VBox/VMM/VMMR3

Files:

• DBGFR3Flow.cpp (modified) (10 diffs)
• PDMBlkCache.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR3/DBGFR3Flow.cpp

@@ -339 +339 @@
 {
     /* Defer destruction if there are still basic blocks referencing us. */
-    PDBGFFLOWBBINT pFlowBb = NULL;
-    PDBGFFLOWBBINT pFlowBbNext = NULL;
+    PDBGFFLOWBBINT pFlowBb;
+    PDBGFFLOWBBINT pFlowBbNext;
     RTListForEachSafe(&pThis->LstFlowBb, pFlowBb, pFlowBbNext, DBGFFLOWBBINT, NdFlowBb)
     {
@@ -455 +455 @@
 DECLINLINE(PDBGFFLOWBBINT) dbgfR3FlowGetUnpopulatedBb(PDBGFFLOWINT pThis)
 {
-    PDBGFFLOWBBINT pFlowBb = NULL;
+    PDBGFFLOWBBINT pFlowBb;
     RTListForEach(&pThis->LstFlowBb, pFlowBb, DBGFFLOWBBINT, NdFlowBb)
     {
@@ -475 +475 @@
 DECLINLINE(PDBGFFLOWBRANCHTBLINT) dbgfR3FlowBranchTblFindByAddr(PDBGFFLOWINT pThis, PDBGFADDRESS pAddrTbl)
 {
-    PDBGFFLOWBRANCHTBLINT pTbl = NULL;
+    PDBGFFLOWBRANCHTBLINT pTbl;
     RTListForEach(&pThis->LstBranchTbl, pTbl, DBGFFLOWBRANCHTBLINT, NdBranchTbl)
     {
@@ -519 +519 @@
 static bool dbgfR3FlowHasBbWithStartAddr(PDBGFFLOWINT pThis, PDBGFADDRESS pAddr)
 {
-    PDBGFFLOWBBINT pFlowBb = NULL;
+    PDBGFFLOWBBINT pFlowBb;
     RTListForEach(&pThis->LstFlowBb, pFlowBb, DBGFFLOWBBINT, NdFlowBb)
     {
@@ -616 +616 @@
                                     uint32_t fNewBbFlags, PDBGFFLOWBRANCHTBLINT pBranchTbl)
 {
-    PDBGFFLOWBBINT pFlowBb = NULL;
+    PDBGFFLOWBBINT pFlowBb;
     RTListForEach(&pThis->LstFlowBb, pFlowBb, DBGFFLOWBBINT, NdFlowBb)
     {
@@ -1431 +1431 @@
     AssertPtrReturn(pThis, VERR_INVALID_HANDLE);
 
-    PDBGFFLOWBBINT pFlowBb = NULL;
+    PDBGFFLOWBBINT pFlowBb;
     RTListForEach(&pThis->LstFlowBb, pFlowBb, DBGFFLOWBBINT, NdFlowBb)
     {
@@ -1463 +1463 @@
     AssertPtrReturn(phFlowBb, VERR_INVALID_POINTER);
 
-    PDBGFFLOWBBINT pFlowBb = NULL;
+    PDBGFFLOWBBINT pFlowBb;
     RTListForEach(&pThis->LstFlowBb, pFlowBb, DBGFFLOWBBINT, NdFlowBb)
     {
@@ -1833 +1833 @@
 
     uint32_t cRefsBb = 0;
-    PDBGFFLOWBBINT pFlowBbCur = NULL;
+    PDBGFFLOWBBINT pFlowBbCur;
     RTListForEach(&pFlowBb->pFlow->LstFlowBb, pFlowBbCur, DBGFFLOWBBINT, NdFlowBb)
     {
@@ -2042 +2042 @@
         pIt->idxBbNext = 0;
         /* Fill the list and then sort. */
+        uint32_t idxBb = 0;
         PDBGFFLOWBBINT pFlowBb;
-        uint32_t idxBb = 0;
         RTListForEach(&pFlow->LstFlowBb, pFlowBb, DBGFFLOWBBINT, NdFlowBb)
         {
@@ -2179 +2179 @@
         pIt->idxTblNext = 0;
         /* Fill the list and then sort. */
+        uint32_t idxTbl = 0;
         PDBGFFLOWBRANCHTBLINT pFlowBranchTbl;
-        uint32_t idxTbl = 0;
         RTListForEach(&pFlow->LstBranchTbl, pFlowBranchTbl, DBGFFLOWBRANCHTBLINT, NdBranchTbl)
         {

trunk/src/VBox/VMM/VMMR3/PDMBlkCache.cpp

@@ -780 +780 @@
 {
     bool fFound = false;
-    PPDMBLKCACHE pBlkCache = NULL;
-
+
+    PPDMBLKCACHE pBlkCache;
     RTListForEach(&pBlkCacheGlobal->ListUsers, pBlkCache, PDMBLKCACHE, NodeCacheUser)
     {