Changeset 65980 in vbox for trunk/src/VBox/ValidationKit/testmanager/core/build.py

Timestamp:

Mar 7, 2017 1:00:36 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

113806

Message:

testmanager/core: pylint 2.0.0 fixes.

File:

• trunk/src/VBox/ValidationKit/testmanager/core/build.py (modified) (6 diffs)

trunk/src/VBox/ValidationKit/testmanager/core/build.py

@@ -278 +278 @@
                           , (idBuildCategory,))
         aaoRows = self._oDb.fetchAll()
-        if len(aaoRows) == 0:
+        if not aaoRows:
             return None;
         if len(aaoRows) != 1:
@@ -307 +307 @@
                           ));
         aaoRows = self._oDb.fetchAll();
-        if len(aaoRows) == 0:
+        if not aaoRows:
             return None;
         if len(aaoRows) > 1:
@@ -323 +323 @@
         # Check BuildCategoryData before do anything
         dDataErrors = oData.validateAndConvert(self._oDb, oData.ksValidateFor_Add);
-        if len(dDataErrors) > 0:
+        if dDataErrors:
             raise TMInvalidData('Invalid data passed to addBuildCategory(): %s' % (dDataErrors,));
 
@@ -432 +432 @@
         for sBinary in self.sBinaries.split(','):
             sBinary = sBinary.strip();
-            if len(sBinary) == 0:
+            if not sBinary:
                 continue;
             # Same URL tests as in webutils.downloadFile().
@@ -593 +593 @@
         #
         dErrors = oData.validateAndConvert(self._oDb, oData.ksValidateFor_Edit);
-        if len(dErrors) > 0:
+        if dErrors:
             raise TMInvalidData('editEntry invalid input: %s' % (dErrors,));
         oOldData = BuildData().initFromDbWithId(self._oDb, oData.idBuild);
@@ -741 +741 @@
         for i in range(len(oBuildEx.oCat.asOsArches)):
             asParts = oBuildEx.oCat.asOsArches[i].split('.');
-            if len(asParts) != 2 or len(asParts[0]) == 0 or len(asParts[1]) == 0:
+            if len(asParts) != 2 or not asParts[0] or not asParts[1]:
                 raise self._oDb.integrityException('Bad build asOsArches value: %s (idBuild=%s idBuildCategory=%s)'
                                                    % (oBuildEx.asOsArches[i], oBuildEx.idBuild, oBuildEx.idBuildCategory));