Changeset 66315 in vbox

Timestamp:

Mar 28, 2017 9:34:58 PM (8 years ago)

Author:

vboxsync

Message:

IEM: Implemented movsldup Vdq,Wdq (f3 0f 12)

Location:

trunk/src/VBox

Files:

• VMM/VMMAll/IEMAllInstructionsTwoByte0f.cpp.h (modified) (3 diffs)
• ValidationKit/bootsectors/bs3-cpu-generated-1-template.c (modified) (3 diffs)
• ValidationKit/bootsectors/bs3-cpu-generated-1.h (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsTwoByte0f.cpp.h

@@ -1397 +1397 @@
 }
 
-#if 0
-FNIEMOP_STUB(iemOp_vmovsldup_Vx_Wx); //NEXT
-#else
+
 /**
- * opcode      0x12
- * opcodesub   !11 mr/reg
- * oppfx       0xf3
- * opcpuid     sse3
- * opgroup     og_sse3_pcksclr_datamove
- * opxcpttype  4
- * optest      op1=-1 op2=0xdddddddd00000002eeeeeeee00000001 ->
+ * @opcode      0x12
+ * @oppfx       0xf3
+ * @opcpuid     sse3
+ * @opgroup     og_sse3_pcksclr_datamove
+ * @opxcpttype  4
+ * @optest      op1=-1 op2=0xdddddddd00000002eeeeeeee00000001 ->
  *              op1=0x00000002000000020000000100000001
+ * @oponlytest
  */
 FNIEMOP_DEF(iemOp_vmovsldup_Vx_Wx)
@@ -1450 +1448 @@
         IEM_MC_PREPARE_SSE_USAGE();
 
-        IEM_MC_FETCH_MEM_U128(uSrc, pVCpu->iem.s.iEffSeg, GCPtrEffSrc);
+        IEM_MC_FETCH_MEM_U128_ALIGN_SSE(uSrc, pVCpu->iem.s.iEffSeg, GCPtrEffSrc);
         IEM_MC_REF_XREG_U128(puDst, ((bRm >> X86_MODRM_REG_SHIFT) & X86_MODRM_REG_SMASK) | pVCpu->iem.s.uRexReg);
         IEM_MC_CALL_SSE_AIMPL_2(iemAImpl_movsldup, puDst, puSrc);
@@ -1460 +1458 @@
 
 }
-#endif
 
 /** Opcode 0xf2 0x0f 0x12. */

trunk/src/VBox/ValidationKit/bootsectors/bs3-cpu-generated-1-template.c

@@ -1402 +1402 @@
             break;
 
+        case BS3CG1ENC_MODRM_Vdq_Wdq:
+            if (iEncoding == 0)
+            {
+                off = Bs3Cg1InsertOpcodes(pThis, Bs3Cg1InsertReqPrefix(pThis, 0));
+                pThis->abCurInstr[off++] = X86_MODRM_MAKE(3, 1, 0);
+                pThis->aOperands[pThis->iRmOp ].idxField = BS3CG1DST_XMM0;
+                pThis->aOperands[pThis->iRegOp].idxField = BS3CG1DST_XMM1;
+            }
+            else if (iEncoding == 1)
+            {
+                pThis->aOperands[pThis->iRegOp].idxField = BS3CG1DST_XMM2;
+                off = Bs3Cg1InsertOpcodes(pThis, Bs3Cg1InsertReqPrefix(pThis, 0));
+                off = Bs3Cfg1EncodeMemMod0Disp(pThis, false, off, 2 /*iReg*/, 16, 0, BS3CG1OPLOC_MEM);
+            }
+            else if (iEncoding == 2)
+            {
+                if (pThis->bMode == BS3_MODE_RM)
+                    break; /** @todo fix real mode #GP() context gathering. */
+                pThis->aOperands[pThis->iRegOp].idxField = BS3CG1DST_XMM3;
+                off = Bs3Cg1InsertOpcodes(pThis, Bs3Cg1InsertReqPrefix(pThis, 0));
+                off = Bs3Cfg1EncodeMemMod0Disp(pThis, false, off, 3 /*iReg*/, 16, 1 /*cbMissalign*/, BS3CG1OPLOC_MEM);
+                if (!Bs3Cg1XcptTypeIsUnaligned(pThis->enmXcptType))
+                    pThis->bAlignmentXcpt = X86_XCPT_GP;
+            }
+            else
+                break;
+            pThis->cbCurInstr = off;
+            iEncoding++;
+            break;
+
         case BS3CG1ENC_MODRM_Gv_Ma:
             cbOp = BS3_MODE_IS_16BIT_CODE(pThis->bMode) ? 2 : 4;
@@ -1671 +1701 @@
             pThis->iRmOp             = 0;
             pThis->iRegOp            = 1;
+            pThis->aOperands[0].cbOp = 16;
+            pThis->aOperands[1].cbOp = 16;
+            pThis->aOperands[0].enmLocation = BS3CG1OPLOC_CTX;
+            pThis->aOperands[1].enmLocation = BS3CG1OPLOC_CTX;
+            break;
+
+        case BS3CG1ENC_MODRM_Vdq_Wdq:
+            pThis->iRmOp             = 1;
+            pThis->iRegOp            = 0;
             pThis->aOperands[0].cbOp = 16;
             pThis->aOperands[1].cbOp = 16;
@@ -3066 +3105 @@
                                 pThis->bValueXcpt      = UINT8_MAX;
                                 if (   fInvalidInstr
+                                    || pThis->bAlignmentXcpt != UINT8_MAX
+                                    || pThis->bValueXcpt     != UINT8_MAX
                                     || Bs3Cg1RunContextModifier(pThis, &pThis->Ctx, pHdr,
                                                                 pHdr->cbSelector + pHdr->cbInput, pHdr->cbOutput,

trunk/src/VBox/ValidationKit/bootsectors/bs3-cpu-generated-1.h

@@ -48 +48 @@
     BS3CG1OP_Wps,
     BS3CG1OP_Wpd,
+    BS3CG1OP_Wdq,
 
     BS3CG1OP_Gb,
@@ -58 +59 @@
     BS3CG1OP_Vpd,
     BS3CG1OP_Vq,
+    BS3CG1OP_Vdq,
 
     BS3CG1OP_Ib,
@@ -96 +98 @@
     BS3CG1ENC_MODRM_Vq_UqHi,
     BS3CG1ENC_MODRM_Vq_Mq,
+    BS3CG1ENC_MODRM_Vdq_Wdq,
 
     BS3CG1ENC_FIXED,