Changeset 66878 in vbox for trunk/src/VBox/VMM/VMMR0/HMR0A.asm

Timestamp:

May 12, 2017 12:40:17 PM (8 years ago)

Author:

vboxsync

Message:

CPUM,HM: Added CPUMRZFpuStateActualizeAvxForRead and fixed missing MXCSR availability for the SSE variant. Should save MXCSR when VBOX_WITH_KERNEL_USING_XMM is define.

File:

• trunk/src/VBox/VMM/VMMR0/HMR0A.asm (modified) (11 diffs)

trunk/src/VBox/VMM/VMMR0/HMR0A.asm

@@ -808 +808 @@
 ; @remarks      This is essentially the same code as hmR0SVMRunWrapXMM, only the parameters differ a little bit.
 ;
+; @remarks      Drivers shouldn't use AVX registers without saving+loading:
+;                   https://msdn.microsoft.com/en-us/library/windows/hardware/ff545910%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396
+;               However the compiler docs have different idea:
+;                   https://msdn.microsoft.com/en-us/library/9z1stfyw.aspx
+;               We'll go with the former for now.
+;
 ; ASSUMING 64-bit and windows for now.
+;
 ALIGNCODE(16)
 BEGINPROC hmR0VMXStartVMWrapXMM
         push    xBP
         mov     xBP, xSP
-        sub     xSP, 0a0h + 040h        ; Don't bother optimizing the frame size.
+        sub     xSP, 0b0h + 040h ; Don't bother optimizing the frame size.
 
         ; spill input parameters.
@@ -853 +860 @@
         movdqa  [rsp + 040h + 080h], xmm14
         movdqa  [rsp + 040h + 090h], xmm15
+        stmxcsr [rsp + 040h + 0a0h]
 
         mov     r10, [xBP + 018h]       ; pCtx
@@ -901 +909 @@
         movdqa  xmm14, [rsp + 040h + 080h]
         movdqa  xmm15, [rsp + 040h + 090h]
+        ldmxcsr        [rsp + 040h + 0a0h]
         leave
         ret
@@ -926 +935 @@
         movdqa  xmm14, [r10 + XMM_OFF_IN_X86FXSTATE + 0e0h]
         movdqa  xmm15, [r10 + XMM_OFF_IN_X86FXSTATE + 0f0h]
+        ldmxcsr        [r10 + X86FXSTATE.MXCSR]
 
         ; Make the call (same as in the other case ).
@@ -940 +950 @@
         mov     r10, [xBP + 018h]       ; pCtx
         mov     r10, [r10 + CPUMCTX.pXStateR0]
+        stmxcsr [r10 + X86FXSTATE.MXCSR]
         movdqa  [r10 + XMM_OFF_IN_X86FXSTATE + 000h], xmm0
         movdqa  [r10 + XMM_OFF_IN_X86FXSTATE + 010h], xmm1
@@ -976 +987 @@
 ; @remarks      This is essentially the same code as hmR0VMXStartVMWrapXMM, only the parameters differ a little bit.
 ;
+; @remarks      Drivers shouldn't use AVX registers without saving+loading:
+;                   https://msdn.microsoft.com/en-us/library/windows/hardware/ff545910%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396
+;               However the compiler docs have different idea:
+;                   https://msdn.microsoft.com/en-us/library/9z1stfyw.aspx
+;               We'll go with the former for now.
+;
 ; ASSUMING 64-bit and windows for now.
 ALIGNCODE(16)
@@ -981 +998 @@
         push    xBP
         mov     xBP, xSP
-        sub     xSP, 0a0h + 040h        ; Don't bother optimizing the frame size.
+        sub     xSP, 0b0h + 040h        ; Don't bother optimizing the frame size.
 
         ; spill input parameters.
@@ -1021 +1038 @@
         movdqa  [rsp + 040h + 080h], xmm14
         movdqa  [rsp + 040h + 090h], xmm15
+        stmxcsr [rsp + 040h + 0a0h]
 
         mov     r10, [xBP + 020h]       ; pCtx
@@ -1069 +1087 @@
         movdqa  xmm14, [rsp + 040h + 080h]
         movdqa  xmm15, [rsp + 040h + 090h]
+        ldmxcsr [rsp + 040h + 0a0h]
         leave
         ret
@@ -1094 +1113 @@
         movdqa  xmm14, [r10 + XMM_OFF_IN_X86FXSTATE + 0e0h]
         movdqa  xmm15, [r10 + XMM_OFF_IN_X86FXSTATE + 0f0h]
+        ldmxcsr        [r10 + X86FXSTATE.MXCSR]
 
         ; Make the call (same as in the other case ).
@@ -1108 +1128 @@
         mov     r10, [xBP + 020h]       ; pCtx
         mov     r10, [r10 + CPUMCTX.pXStateR0]
+        stmxcsr [r10 + X86FXSTATE.MXCSR]
         movdqa  [r10 + XMM_OFF_IN_X86FXSTATE + 000h], xmm0
         movdqa  [r10 + XMM_OFF_IN_X86FXSTATE + 010h], xmm1