Changeset 68627 in vbox for trunk/src/VBox/Installer/linux/Makefile.include.footer

Timestamp:

Sep 5, 2017 9:48:21 AM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

117857

Message:

Linux driver make files: clean up.
bugref:4567: Linux kernel driver maintenance

Simplify the Makefile.include.header and .footer templates and remove some
content which was either no longer relevant or perhaps never really needed.
Also make a small fix to build_in_tmp which sometimes caused it to fail on
Linux 2.4-based systems (that is, CentOS 3). Second attempt.

File:

• trunk/src/VBox/Installer/linux/Makefile.include.footer (modified) (4 diffs)

trunk/src/VBox/Installer/linux/Makefile.include.footer

@@ -18 +18 @@
 override MODULE = $(MOD_NAME)
 OBJS   = $(MOD_OBJS)
-
-ifneq ($(MAKECMDGOALS),clean)
 
 KBUILD_VERBOSE ?= 1
@@ -44 +42 @@
 #
 
+# Note: while 2.4 kernels could also do "proper" builds from kbuild, the make
+# script needed to support it was somewhat different from 2.6.  Since this
+# script works and 2.4 is not a moving target we will not try do do things the
+# "proper" way.
+
 ifeq ($(BUILD_TARGET_ARCH),amd64)
  KFLAGS  += -mcmodel=kernel
@@ -59 +62 @@
 $(MODULE): $(MODULE).o
 
-else
+install: $(MODULE)
+        @mkdir -p $(MODULE_DIR); \
+        install -m 0644 -o root -g root $(MODULE).$(MODULE_EXT) \
+        $(INSTALL_MOD_PATH)/$(KERN_DIR)/$(INSTALL_MOD_DIR); \
+        PATH="$(PATH):/bin:/sbin" depmod -a;
+
+clean:
+        for f in $(sort $(dir $(OBJS))); do rm -f $$f/*.o $$f/.*.cmd $$f/.*.flags; done
+        rm -rf .$(MOD_NAME)* .tmp_ver* $(MOD_NAME).* Modules.symvers modules.order
+
+else  # ! $(KERN_VERSION), 24
 #
 # 2.6 and later
@@ -85 +98 @@
         $(MAKE) KBUILD_VERBOSE=$(KBUILD_VERBOSE) CONFIG_MODULE_SIG= -C $(KERN_DIR) SUBDIRS=$(CURDIR) SRCROOT=$(CURDIR) -j$(JOBS) modules
 
-modules_install:
-        $(MAKE) KBUILD_VERBOSE=$(KBUILD_VERBOSE) CONFIG_MODULE_SIG= -C $(KERN_DIR) SUBDIRS=$(CURDIR) SRCROOT=$(CURDIR) modules_install
+install: $(MODULE)
+        $(MAKE) KBUILD_VERBOSE=$(KBUILD_VERBOSE) CONFIG_MODULE_SIG= -C $(KERN_DIR) SUBDIRS=$(CURDIR) SRCROOT=$(CURDIR) INSTALL_MOD_PATH=$(INSTALL_MOD_PATH) INSTALL_MOD_DIR=$(INSTALL_MOD_DIR) modules_install
 
-endif
-
-install: $(MODULE)
-        @mkdir -p $(MODULE_DIR); \
-        install -m 0644 -o root -g root $(MODULE).$(MODULE_EXT) $(MODULE_DIR); \
-        PATH="$(PATH):/bin:/sbin" depmod -a;
-
-endif # eq($(MAKECMDGOALS),clean)
+modules_install: install
 
 clean:
-        for f in $(MOD_CLEAN); do rm -f $$f/*.o $$f/.*.cmd $$f/.*.flags; done
-        rm -rf .$(MOD_NAME)* .tmp_ver* $(MOD_NAME).* Modules.symvers modules.order
+        $(MAKE) KBUILD_VERBOSE=$(KBUILD_VERBOSE) CONFIG_MODULE_SIG= -C $(KERN_DIR) SUBDIRS=$(CURDIR) SRCROOT=$(CURDIR) clean
+
+.PHONY: $(MODULE) install modules_install clean
+endif