Changeset 69803 in vbox for trunk/src/VBox/Main/src-server/win

Timestamp:

Nov 22, 2017 11:42:14 AM (7 years ago)

Author:

vboxsync

Message:

svcmain.cpp: Only call IVirtualBoxSDS::deregisterVBoxSVC from the chosen VBoxSVC. Avoid calling it during com shutdown (just to be on the safe side).

File:

• trunk/src/VBox/Main/src-server/win/svcmain.cpp (modified) (4 diffs)

trunk/src/VBox/Main/src-server/win/svcmain.cpp

@@ -79 +79 @@
 HINSTANCE   g_hInstance   = NULL;
 #ifdef VBOX_WITH_SDS
-/** This is set if we're connected to SDS and should discount a server lock
- * that it is holding when deciding whether we're idle or not. */
+/** This is set if we're connected to SDS.
+ *
+ * It means that we should discount a server lock that it is holding when
+ * deciding whether we're idle or not.
+ *
+ * Also, when set we deregister with SDS during class factory destruction.  We
+ * exploit this to prevent attempts to deregister during or after COM shutdown.
+ */
 bool        g_fRegisteredWithVBoxSDS = false;
 #endif
@@ -220 +226 @@
         }
 
-        /** @todo Need to check if this is okay wrt COM termination. */
-        i_deregisterWithSds();
+        /* We usually get here during g_pModule->Term() via CoRevokeClassObjec, so COM
+           probably working well enough to talk to SDS when we get here. */
+        if (g_fRegisteredWithVBoxSDS)
+            i_deregisterWithSds();
     }
 
@@ -323 +331 @@
         if (SUCCEEDED(hrc))
         {
-            g_fRegisteredWithVBoxSDS = true;
+            g_fRegisteredWithVBoxSDS = !*ppOtherVirtualBox;
             return hrc;
         }
@@ -901 +909 @@
     g_pModule->Term();
 
+#ifdef VBOX_WITH_SDS
+    g_fRegisteredWithVBoxSDS = false; /* Don't trust COM LPC to work right from now on.  */
+#endif
     com::Shutdown();