Changeset 71036 in vbox for trunk/src/VBox/VMM/VMMAll/IEMAllCImplSvmInstr.cpp.h

Timestamp:

Feb 16, 2018 5:47:33 AM (7 years ago)

Author:

vboxsync

Message:

VMM/IEM: Nested Hw.virt: Comment, removed obsolete todo.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllCImplSvmInstr.cpp.h (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllCImplSvmInstr.cpp.h

@@ -154 +154 @@
 
         PSVMVMCBCTRL pVmcbCtrl = &pCtx->hwvirt.svm.CTX_SUFF(pVmcb)->ctrl;
-        /* Record any interrupt shadow of the nested-guest instruction into the nested-guest VMCB. */
+
+        /*
+         * Save additional state and intercept information.
+         *
+         *   - Interrupt shadow: Tracked using VMCPU_FF_INHIBIT_INTERRUPTS and RIP.
+         *   - V_TPR: Already updated by iemCImpl_load_CrX or by the physical CPU for
+         *     hardware-assisted SVM execution.
+         *   - V_IRQ: Tracked using VMCPU_FF_INTERRUPT_NESTED_GUEST force-flag and updated below.
+         */
         if (   VMCPU_FF_IS_PENDING(pVCpu, VMCPU_FF_INHIBIT_INTERRUPTS)
             && EMGetInhibitInterruptsPC(pVCpu) == pCtx->rip)
@@ -165 +173 @@
         }
 
-        /*
-         * Save additional state and intercept information.
-         */
         if (VMCPU_FF_IS_PENDING(pVCpu, VMCPU_FF_INTERRUPT_NESTED_GUEST))
         {
@@ -176 +181 @@
             pVmcbCtrl->IntCtrl.n.u1VIrqPending = 0;
 
-        /** @todo Save V_TPR, V_IRQ. */
         /** @todo NRIP. */