Changeset 71054 in vbox for trunk/src/VBox/Frontends/VBoxManage/VBoxManageMisc.cpp

Timestamp:

Feb 19, 2018 1:38:37 PM (7 years ago)

Author:

vboxsync

Message:

bugref:8345. CHECK_ERROR_BREAK was replaced by CHECK_ERROR_RET.

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageMisc.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageMisc.cpp

@@ -360 +360 @@
         /* Start the moving */
         ComPtr<IProgress> progress;
-        do
-        {
-            /* we have to open a session for this task */
-            CHECK_ERROR_BREAK(srcMachine, LockMachine(a->session, LockType_Write));
-            ComPtr<IMachine> sessionMachine;
-            do
-            {
-                CHECK_ERROR_BREAK(a->session, COMGETTER(Machine)(sessionMachine.asOutParam()));
-                CHECK_ERROR_BREAK(sessionMachine, MoveTo(Bstr(pszTargetFolder).raw(),
-                                       Bstr(pszType).raw(),
-                                       progress.asOutParam()));
-                rc = showProgress(progress);
-                CHECK_PROGRESS_ERROR_RET(progress, ("Move VM failed"), RTEXITCODE_FAILURE);
-//              CHECK_ERROR_BREAK(sessionMachine, SaveSettings());
-            } while (0);
-
-            sessionMachine.setNull();
-            CHECK_ERROR_BREAK(a->session, UnlockMachine());
-        } while (0);
-    }
-
-    RTPrintf("Machine has been successfully moved into %s\n", pszTargetFolder);
+
+        /* we have to open a session for this task */
+        CHECK_ERROR_RET(srcMachine, LockMachine(a->session, LockType_Write), RTEXITCODE_FAILURE);
+        ComPtr<IMachine> sessionMachine;
+
+        CHECK_ERROR_RET(a->session, COMGETTER(Machine)(sessionMachine.asOutParam()), RTEXITCODE_FAILURE);
+        CHECK_ERROR_RET(sessionMachine, MoveTo(Bstr(pszTargetFolder).raw(),
+                               Bstr(pszType).raw(),
+                               progress.asOutParam()), RTEXITCODE_FAILURE);
+        rc = showProgress(progress);
+        CHECK_PROGRESS_ERROR_RET(progress, ("Move VM failed"), RTEXITCODE_FAILURE);
+
+        sessionMachine.setNull();
+        CHECK_ERROR_RET(a->session, UnlockMachine(), RTEXITCODE_FAILURE);
+
+//        do
+//        {
+//            /* we have to open a session for this task */
+//            CHECK_ERROR_BREAK(srcMachine, LockMachine(a->session, LockType_Write));
+//            ComPtr<IMachine> sessionMachine;
+//            do
+//            {
+//                CHECK_ERROR_BREAK(a->session, COMGETTER(Machine)(sessionMachine.asOutParam()));
+//                CHECK_ERROR_BREAK(sessionMachine, MoveTo(Bstr(pszTargetFolder).raw(),
+//                                       Bstr(pszType).raw(),
+//                                       progress.asOutParam()));
+//                rc = showProgress(progress);
+//                CHECK_PROGRESS_ERROR_RET(progress, ("Move VM failed"), RTEXITCODE_FAILURE);
+////              CHECK_ERROR_BREAK(sessionMachine, SaveSettings());
+//            } while (0);
+//
+//            sessionMachine.setNull();
+//            CHECK_ERROR_BREAK(a->session, UnlockMachine());
+//        } while (0);
+        RTPrintf("Machine has been successfully moved into %s\n", pszTargetFolder);
+    }
 
     return RTEXITCODE_SUCCESS;