Changeset 72851 in vbox for trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

Timestamp:

Jul 4, 2018 5:36:58 AM (6 years ago)

Author:

vboxsync

Message:

VMM/HMVMXR0: Macro nit, try not to hide parameters.

File:

• trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (17 diffs)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -160 +160 @@
                                                               (a_pVCpu)->cpum.GstCtx.fExtrn, (a_fExtrnMbz)))
 
-
 /** Helper macro for VM-exit handlers called unexpectedly. */
-#define HMVMX_RETURN_UNEXPECTED_EXIT() \
+#define HMVMX_UNEXPECTED_EXIT_RET(a_pVCpu, a_pVmxTransient) \
     do { \
-        pVCpu->hm.s.u32HMError = pVmxTransient->uExitReason; \
+        (a_pVCpu)->hm.s.u32HMError = (a_pVmxTransient)->uExitReason; \
         return VERR_VMX_UNEXPECTED_EXIT; \
     } while (0)
@@ -11158 +11157 @@
     {
         AssertMsgFailed(("Unexpected NMI-window exit.\n"));
-        HMVMX_RETURN_UNEXPECTED_EXIT();
+        HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
     }
 
@@ -11280 +11279 @@
 
     AssertMsgFailed(("hmR0VmxExitGetsec: unexpected VM-exit when CR4.SMXE is 0.\n"));
-    HMVMX_RETURN_UNEXPECTED_EXIT();
+    HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
 }
 
@@ -11517 +11516 @@
     HMVMX_VALIDATE_EXIT_HANDLER_PARAMS();
     AssertMsgFailed(("Unexpected RSM VM-exit. pVCpu=%p pMixedCtx=%p\n", pVCpu, pMixedCtx));
-    HMVMX_RETURN_UNEXPECTED_EXIT();
+    HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
 }
 
@@ -11537 +11536 @@
     HMVMX_VALIDATE_EXIT_HANDLER_PARAMS();
     AssertMsgFailed(("Unexpected SMI VM-exit. pVCpu=%p pMixedCtx=%p\n", pVCpu, pMixedCtx));
-    HMVMX_RETURN_UNEXPECTED_EXIT();
+    HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
 }
 
@@ -11549 +11548 @@
     HMVMX_VALIDATE_EXIT_HANDLER_PARAMS();
     AssertMsgFailed(("Unexpected IO SMI VM-exit. pVCpu=%p pMixedCtx=%p\n", pVCpu, pMixedCtx));
-    HMVMX_RETURN_UNEXPECTED_EXIT();
+    HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
 }
 
@@ -11565 +11564 @@
     HMVMX_VALIDATE_EXIT_HANDLER_PARAMS();
     AssertMsgFailed(("Unexpected SIPI VM-exit. pVCpu=%p pMixedCtx=%p\n", pVCpu, pMixedCtx));
-    HMVMX_RETURN_UNEXPECTED_EXIT();
+    HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
 }
 
@@ -11745 +11744 @@
     NOREF(pVmxTransient);
     AssertMsgFailed(("Unexpected MSR-load exit. pVCpu=%p pMixedCtx=%p\n", pVCpu, pMixedCtx)); NOREF(pMixedCtx);
-    HMVMX_RETURN_UNEXPECTED_EXIT();
+    HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
 }
 
@@ -11757 +11756 @@
     NOREF(pVmxTransient);
     AssertMsgFailed(("Unexpected machine-check event exit. pVCpu=%p pMixedCtx=%p\n", pVCpu, pMixedCtx)); NOREF(pMixedCtx);
-    HMVMX_RETURN_UNEXPECTED_EXIT();
+    HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
 }
 
@@ -11787 +11786 @@
         return VERR_EM_INTERPRETER;
     AssertMsgFailed(("Unexpected XDTR access. pVCpu=%p pMixedCtx=%p\n", pVCpu, pMixedCtx));
-    HMVMX_RETURN_UNEXPECTED_EXIT();
+    HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
 }
 
@@ -11802 +11801 @@
         return VERR_EM_INTERPRETER;
     AssertMsgFailed(("Unexpected RDRAND exit. pVCpu=%p pMixedCtx=%p\n", pVCpu, pMixedCtx));
-    HMVMX_RETURN_UNEXPECTED_EXIT();
+    HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
 }
 
@@ -11832 +11831 @@
             AssertMsgFailed(("Unexpected RDMSR for an MSR in the auto-load/store area in the VMCS. ecx=%#RX32\n",
                              pMixedCtx->ecx));
-            HMVMX_RETURN_UNEXPECTED_EXIT();
+            HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
         }
         if (hmR0VmxIsLazyGuestMsr(pVCpu, pMixedCtx->ecx))
@@ -11843 +11842 @@
             {
                 AssertMsgFailed(("Unexpected RDMSR for a passthru lazy-restore MSR. ecx=%#RX32\n", pMixedCtx->ecx));
-                HMVMX_RETURN_UNEXPECTED_EXIT();
+                HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
             }
         }
@@ -11951 +11950 @@
                 {
                     AssertMsgFailed(("Unexpected WRMSR for an MSR in the VMCS. ecx=%#RX32\n", pMixedCtx->ecx));
-                    HMVMX_RETURN_UNEXPECTED_EXIT();
+                    HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
                 }
 
@@ -11964 +11963 @@
                             AssertMsgFailed(("Unexpected WRMSR for an MSR in the auto-load/store area in the VMCS. ecx=%#RX32\n",
                                              pMixedCtx->ecx));
-                            HMVMX_RETURN_UNEXPECTED_EXIT();
+                            HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
                         }
                     }
@@ -11977 +11976 @@
                         {
                             AssertMsgFailed(("Unexpected WRMSR for passthru, lazy-restore MSR. ecx=%#RX32\n", pMixedCtx->ecx));
-                            HMVMX_RETURN_UNEXPECTED_EXIT();
+                            HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
                         }
                     }
@@ -12577 +12576 @@
     {
         AssertMsgFailed(("Unexpected MOV DRx exit. pVCpu=%p pMixedCtx=%p\n", pVCpu, pMixedCtx));
-        HMVMX_RETURN_UNEXPECTED_EXIT();
+        HMVMX_UNEXPECTED_EXIT_RET(pVCpu, pVmxTransient);
     }