VirtualBox

Ignore:
Timestamp:
Dec 22, 2018 10:48:10 PM (6 years ago)
Author:
vboxsync
Message:

VBox/GuestHost/DragAndDrop.h: Don't include err.h, dir.h and file.h when all you need is fs.h for RTFSOBJINFO. Also address some misconception in Guest/DragAndDrop of how we use LOG_GROUP (it goes first, before all the headers (and you don't need #ifndef before #undef)). Generally, include the module header first and then all the stuff the implementation needs afterwards. bugref:9344

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/GuestHost/DragAndDrop/DnDDroppedFiles.cpp

    r74526 r76379  
    11/* $Id$ */
    22/** @file
    3  * DnD: Directory handling.
     3 * DnD - Directory handling.
    44 */
    55
     
    2020*   Header Files                                                                                                                 *
    2121*********************************************************************************************************************************/
     22#define LOG_GROUP LOG_GROUP_GUEST_DND
     23#include <VBox/GuestHost/DragAndDrop.h>
    2224
    2325#include <iprt/assert.h>
    2426#include <iprt/dir.h>
     27#include <iprt/err.h>
     28#include <iprt/file.h>
    2529#include <iprt/path.h>
    2630#include <iprt/string.h>
    2731
    28 #include <VBox/GuestHost/DragAndDrop.h>
    29 
    30 #ifdef LOG_GROUP
    31  #undef LOG_GROUP
    32 #endif
    33 #define LOG_GROUP LOG_GROUP_GUEST_DND
     32
    3433#include <VBox/log.h>
    3534
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette