Changeset 76787 in vbox for trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_gentextures.c

Timestamp:

Jan 11, 2019 8:00:15 PM (6 years ago)

Author:

vboxsync

Message:

3D: Parameters validation corrected, bugref:9327

File:

• trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_gentextures.c (modified) (6 diffs)

trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_gentextures.c

@@ -17 +17 @@
     (void) textures;
 
-    if (n >= INT32_MAX / sizeof(GLuint))
+    if (n <= 0 || n >= INT32_MAX / sizeof(GLuint))
     {
         crError("crServerDispatchGenTextures: parameter 'n' is out of range");
@@ -42 +42 @@
     (void) ids;
 
-    if (n >= INT32_MAX / sizeof(GLuint))
+    if (n <= 0 || n >= INT32_MAX / sizeof(GLuint))
     {
         crError("crServerDispatchGenProgramsNV: parameter 'n' is out of range");
@@ -67 +67 @@
     (void) ids;
 
-    if (n >= INT32_MAX / sizeof(GLuint))
+    if (n <= 0 || n >= INT32_MAX / sizeof(GLuint))
     {
         crError("crServerDispatchGenFencesNV: parameter 'n' is out of range");
@@ -88 +88 @@
 void SERVER_DISPATCH_APIENTRY crServerDispatchGenProgramsARB( GLsizei n, GLuint * ids )
 {
-    GLuint *local_progs = (GLuint *) crAlloc( n*sizeof( *local_progs) );
+    GLuint *local_progs;
     GLsizei i;
     (void) ids;
 
-    if (n >= INT32_MAX / sizeof(GLuint))
+    if (n <= 0 || n >= INT32_MAX / sizeof(GLuint))
     {
         crError("crServerDispatchGenProgramsARB: parameter 'n' is out of range");
@@ -102 +102 @@
     if (!local_progs)
     {
-        crError("crServerDispatchGenProgramsARB: out of memory");
+        crError("crServerDispatchGenProgramsARB: out of money");
         return;
     }
@@ -120 +120 @@
     }
 
-    crServerReturnValue( local_progs, n*sizeof( *local_progs ) );
+    crServerReturnValue( local_progs, n * sizeof( *local_progs ) );
     crFree( local_progs );
 }