Changeset 76787 in vbox for trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_texture.c

Timestamp:

Jan 11, 2019 8:00:15 PM (6 years ago)

Author:

vboxsync

Message:

3D: Parameters validation corrected, bugref:9327

File:

• trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_texture.c (modified) (5 diffs)

trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_texture.c

@@ -169 +169 @@
 void SERVER_DISPATCH_APIENTRY crServerDispatchGetTexEnvfv( GLenum target, GLenum pname, GLfloat * params )
 {
-    GLfloat local_params[4];
+    GLfloat local_params[4] = {0};
     (void) params;
     if (GL_POINT_SPRITE != target && pname != GL_COORD_REPLACE)
@@ -181 +181 @@
 void SERVER_DISPATCH_APIENTRY crServerDispatchGetTexEnviv( GLenum target, GLenum pname, GLint * params )
 {
-    GLint local_params[4];
+    GLint local_params[4] = {0};
     (void) params;
     if (GL_POINT_SPRITE != target && pname != GL_COORD_REPLACE)
@@ -203 +203 @@
     GLint i;
 
-    if (n >= UINT32_MAX / sizeof(GLuint))
+    if (n <= 0 || n >= INT32_MAX / sizeof(GLuint))
     {
         crError("crServerDispatchDeleteTextures: parameter 'n' is out of range");
@@ -239 +239 @@
     GLint i;
 
-    if (n >= INT32_MAX / sizeof(GLuint))
+    if (n <= 0 || n >= INT32_MAX / sizeof(GLuint))
     {
         crError("crServerDispatchPrioritizeTextures: parameter 'n' is out of range");
@@ -285 +285 @@
     (void) residences;
 
-    if (n >= INT32_MAX / sizeof(GLuint))
+    if (n <= 0 || n >= INT32_MAX / sizeof(GLuint))
     {
         crError("crServerDispatchAreTexturesResident: parameter 'n' is out of range");