Changeset 76851 in vbox for trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

Timestamp:

Jan 17, 2019 11:32:14 AM (6 years ago)

Author:

vboxsync

Message:

Audio/AC97: More verbose BDL(E) logging.

File:

• trunk/src/VBox/Devices/Audio/DevIchAc97.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

@@ -271 +271 @@
 typedef struct AC97BDLE
 {
+    /** Location of data buffer (bits 31:1). */
     uint32_t addr;
+    /** Flags (bits 31 + 30) and length (bits 15:0) of data buffer (in audio samples). */
     uint32_t ctl_len;
 } AC97BDLE;
@@ -764 +766 @@
 # endif
     pRegs->picb       = pRegs->bd.ctl_len & AC97_BD_LEN_MASK;
-    LogFlowFunc(("bd %2d addr=%#x ctl=%#06x len=%#x(%d bytes)\n",
+    LogFlowFunc(("bd %2d addr=%#x ctl=%#06x len=%#x(%d bytes), bup=%RTbool, ioc=%RTbool\n",
                   pRegs->civ, pRegs->bd.addr, pRegs->bd.ctl_len >> 16,
                   pRegs->bd.ctl_len & AC97_BD_LEN_MASK,
-                 (pRegs->bd.ctl_len & AC97_BD_LEN_MASK) << 1)); /** @todo r=andy Assumes 16bit samples. */
+                 (pRegs->bd.ctl_len & AC97_BD_LEN_MASK) << 1,  /** @todo r=andy Assumes 16bit samples. */
+                  RT_BOOL(pRegs->bd.ctl_len & AC97_BD_BUP),
+                  RT_BOOL(pRegs->bd.ctl_len & AC97_BD_IOC)));
 }
 
@@ -1443 +1447 @@
         PDMDevHlpPhysRead(pThis->CTX_SUFF(pDevIns), u64BDLBase + i * sizeof(AC97BDLE), &BDLE, sizeof(AC97BDLE));
 
+# ifndef RT_LITTLE_ENDIAN
+#  error "Please adapt the code (audio buffers are little endian)!"
+# else
         BDLE.addr    = RT_H2LE_U32(BDLE.addr & ~3);
         BDLE.ctl_len = RT_H2LE_U32(BDLE.ctl_len);
-
-        LogFunc(("\t#%03d BDLE(adr:0x%llx, size:%RU32 [%RU32 bytes])\n",
+#endif
+        LogFunc(("\t#%03d BDLE(adr:0x%llx, size:%RU32 [%RU32 bytes], bup:%RTbool, ioc:%RTbool)\n",
                   i, BDLE.addr,
                   BDLE.ctl_len & AC97_BD_LEN_MASK,
-                 (BDLE.ctl_len & AC97_BD_LEN_MASK) << 1)); /** @todo r=andy Assumes 16bit samples. */
+                 (BDLE.ctl_len & AC97_BD_LEN_MASK) << 1, /** @todo r=andy Assumes 16bit samples. */
+                  RT_BOOL(BDLE.ctl_len & AC97_BD_BUP),
+                  RT_BOOL(BDLE.ctl_len & AC97_BD_IOC)));
 
         cbBDLE += (BDLE.ctl_len & AC97_BD_LEN_MASK) << 1; /** @todo r=andy Ditto. */
@@ -3192 +3201 @@
                             /* Fetch the initial BDLE descriptor. */
                             ichac97R3StreamFetchBDLE(pThis, pStream);
+# ifdef LOG_ENABLED
+                            ichac97R3BDLEDumpAll(pThis, pStream->Regs.bdbar, pStream->Regs.lvi + 1);
+# endif
                             ichac97R3StreamEnable(pThis, pStream, true /* fEnable */);