Changeset 7717 in vbox

Timestamp:

Apr 3, 2008 9:54:12 AM (17 years ago)

Author:

vboxsync

Message:

Some write protect changes

Location:

trunk/src/VBox/VMM/VMMR0

Files:

• HWSVMR0.cpp (modified) (1 diff)
• HWVMXR0.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR0/HWSVMR0.cpp

@@ -527 +527 @@
 
         val |= X86_CR0_PG;          /* Paging is always enabled; even when the guest is running in real mode or PE without paging. */
+        val |= X86_CR0_WP;          /* Must set this as we rely on protect various pages and supervisor writes must be caught. */
         pVMCB->guest.u64CR0 = val;
     }

trunk/src/VBox/VMM/VMMR0/HWVMXR0.cpp

@@ -805 +805 @@
         /* Note: protected mode & paging are always enabled; we use them for emulating real and protected mode without paging too. */
         val |= X86_CR0_PE | X86_CR0_PG;
+        /* Note: We must also set this as we rely on protecting various pages for which supervisor writes must be caught. */
+        val |= X86_CR0_WP;
 
         rc |= VMXWriteVMCS(VMX_VMCS_GUEST_CR0,              val);
@@ -812 +814 @@
          */
         val =   X86_CR0_PE  /* Must monitor this bit (assumptions are made for real mode emulation) */
-              | X86_CR0_WP  /** @todo do we care? (we do if we start patching the guest) */
+              | X86_CR0_WP  /* Must monitor this bit (it must always be enabled). */
               | X86_CR0_PG  /* Must monitor this bit (assumptions are made for real mode & protected mode without paging emulation) */
               | X86_CR0_TS