Changeset 7718 in vbox for trunk/src

Timestamp:

Apr 3, 2008 11:26:16 AM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

29250

Message:

Enabled X86_CR0_WP=0 code execution with VT-x & AMD-V

Location:

trunk/src/VBox/VMM

Files:

• HWACCM.cpp (modified) (3 diffs)
• VMMAll/EMAll.cpp (modified) (1 diff)
• VMMAll/PGMAllBth.h (modified) (1 diff)

trunk/src/VBox/VMM/HWACCM.cpp

@@ -405 +405 @@
                 pVM->hwaccm.s.vmx.fEnabled = true;
                 CPUMSetGuestCpuIdFeature(pVM, CPUMCPUIDFEATURE_SEP);
+#if 0 /* not yet */
+                CPUMSetGuestCpuIdFeature(pVM, CPUMCPUIDFEATURE_PAE);
+#endif
                 LogRel(("HWACCM: VMX enabled!\n"));
             }
@@ -436 +439 @@
                 hwaccmr3DisableRawMode(pVM);
                 CPUMSetGuestCpuIdFeature(pVM, CPUMCPUIDFEATURE_SEP);
+#if 0 /* not yet */
+                CPUMSetGuestCpuIdFeature(pVM, CPUMCPUIDFEATURE_PAE);
+#endif
 
                 pVM->fHWACCMEnabled = true;
@@ -569 +575 @@
         return false;
     if (pCtx->ssHid.Attr.n.u1Present == 0)
-        return false;
-
-    /** @todo if we remove this check, then Windows XP install fails during the textmode phase */
-    if (!(pCtx->cr0 & X86_CR0_WRITE_PROTECT))
         return false;
 #endif

trunk/src/VBox/VMM/VMMAll/EMAll.cpp

@@ -1659 +1659 @@
         case USE_REG_CR0:
             oldval = CPUMGetGuestCR0(pVM);
-#ifndef IN_RING3
+#ifdef IN_GC
             /* CR0.WP and CR0.AM changes require a reschedule run in ring 3. */
             if (    (val32 & (X86_CR0_WP | X86_CR0_AM)) 

trunk/src/VBox/VMM/VMMAll/PGMAllBth.h

@@ -539 +539 @@
                     return rc;
                 }
+                else
+                    AssertFailed(); /* This shouldn't happen; the above check is paranoid. */
             }