Changeset 77971 in vbox for trunk/src/VBox/Runtime/common/ldr/ldrLX.cpp

Timestamp:

Apr 1, 2019 9:35:17 AM (6 years ago)

Author:

vboxsync

Message:

Runtime/ldr: Make RTLDRREADER::pfnSize return an unsigned 64bit value instead of a signed one for the raw image size and adapt all users. This avoids signed/unsigned confusions when comparing those value with others (bugref:9188)

File:

• trunk/src/VBox/Runtime/common/ldr/ldrLX.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/ldr/ldrLX.cpp

@@ -227 +227 @@
 
     /* Some rough sanity checks. */
-    offEnd = pRdr->pfnSize(pRdr) >= (RTFOFF)~(uint32_t)16 ? ~(uint32_t)16 : (uint32_t)pRdr->pfnSize(pRdr);
+    offEnd = pRdr->pfnSize(pRdr) >= (uint64_t)~(uint32_t)16 ? ~(uint32_t)16 : (uint32_t)pRdr->pfnSize(pRdr);
     if (    Hdr.e32_itermap > offEnd
         ||  Hdr.e32_datapage > offEnd