Changeset 77971 in vbox for trunk/src/VBox/Runtime/common/ldr/ldrVfsFile.cpp

Timestamp:

Apr 1, 2019 9:35:17 AM (6 years ago)

Author:

vboxsync

Message:

Runtime/ldr: Make RTLDRREADER::pfnSize return an unsigned 64bit value instead of a signed one for the raw image size and adapt all users. This avoids signed/unsigned confusions when comparing those value with others (bugref:9188)

File:

• trunk/src/VBox/Runtime/common/ldr/ldrVfsFile.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/common/ldr/ldrVfsFile.cpp

@@ -84 +84 @@
 
 /** @copydoc RTLDRREADER::pfnSize */
-static DECLCALLBACK(RTFOFF) rtldrVfsFileSize(PRTLDRREADER pReader)
+static DECLCALLBACK(uint64_t) rtldrVfsFileSize(PRTLDRREADER pReader)
 {
     PRTLDRREADERVFSFILE pFileReader = (PRTLDRREADERVFSFILE)pReader;
@@ -121 +121 @@
      * Allocate memory.
      */
-    RTFOFF cbFile = rtldrVfsFileSize(pReader);
+    uint64_t cbFile = rtldrVfsFileSize(pReader);
     size_t cb = (size_t)cbFile;
-    if ((RTFOFF)cb != cbFile)
+    if ((uint64_t)cb != cbFile)
         return VERR_IMAGE_TOO_BIG;
     pFileReader->pvMapping = RTMemAlloc(cb);