Changeset 78105 in vbox for trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/presenter/server_presenter.cpp

Timestamp:

Apr 10, 2019 8:01:12 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

129961

Message:

GuestHost/OpenGL,HostServices/SharedOpenGL: Updates bugref:9407

File:

• trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/presenter/server_presenter.cpp (modified) (1 diff)

trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/presenter/server_presenter.cpp

@@ -146 +146 @@
 static int8_t crFbImgFromDimOffVramBGRA(VBOXCMDVBVAOFFSET offVRAM, uint32_t width, uint32_t height, CR_BLITTER_IMG *pImg)
 {
-    uint32_t cbBuff = width * height * 4;
+    uint32_t cbBuff;
+    
+    if (width == 0 || height == 0)
+    {
+        WARN(("invalid param"));
+        return -1;
+    }
+    
+    cbBuff = width * height * 4;
+    // Check if overflow happened
+    if (cbBuff / width != height * 4)
+    {
+        WARN(("invalid param"));
+        return -1;
+    }
+    
     if (offVRAM >= g_cbVRam
+            || UINT32_MAX - cbBuff <= offVRAM
             || offVRAM + cbBuff >= g_cbVRam)
     {