Changeset 78723 in vbox for trunk/src/VBox/Frontends/VirtualBox/src/globals/VBoxGlobal.cpp

Timestamp:

May 24, 2019 12:26:23 PM (6 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:7127: Do not perform whole medium-enumeration if one medium was not found in the tree, just enumerate it and it's children; This speedups VM details processing but is a dangerous one, needs to be carefully tested.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/globals/VBoxGlobal.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/VBoxGlobal.cpp

@@ -2520 +2520 @@
 }
 
+void VBoxGlobal::enumerateAdditionalMedium(const CMedium &comMedium)
+{
+    /* Make sure VBoxGlobal is already valid: */
+    AssertReturnVoid(m_fValid);
+    /* Ignore the request during VBoxGlobal cleanup: */
+    if (s_fCleaningUp)
+        return;
+    /* Ignore the request during startup snapshot restoring: */
+    if (shouldRestoreCurrentSnapshot())
+        return;
+
+    /* Make sure medium-enumerator is already created: */
+    if (!m_pMediumEnumerator)
+        return;
+
+    /* Redirect request to medium-enumerator under proper lock: */
+    if (m_meCleanupProtectionToken.tryLockForRead())
+    {
+        if (m_pMediumEnumerator)
+            m_pMediumEnumerator->enumerateAdditionalMedium(comMedium);
+        m_meCleanupProtectionToken.unlock();
+    }
+}
+
 void VBoxGlobal::refreshMedia()
 {
@@ -3307 +3331 @@
     {
         /* UI medium may be new and not among our media, request enumeration: */
-        startMediumEnumeration();
+        enumerateAdditionalMedium(comMedium);
 
         /* Search for corresponding UI medium again: */