Changeset 78860 in vbox for trunk/src/VBox/Additions/linux/sharedfolders/utils.c

Timestamp:

May 29, 2019 8:21:42 PM (6 years ago)

Author:

vboxsync

Message:

linux/vboxsf: Relax setattr permission checks. bugref:9172 ticketref:18569

File:

• trunk/src/VBox/Additions/linux/sharedfolders/utils.c (modified) (1 diff)

trunk/src/VBox/Additions/linux/sharedfolders/utils.c

@@ -801 +801 @@
 
     /*
-     * Need to check whether the caller is allowed to modify the attributes or not.
+     * Do minimal attribute permission checks.  We set ATTR_FORCE since we cannot
+     * preserve ownership and such and would end up with EPERM here more often than
+     * we would like.  For instance it would cause 'cp' to complain about EPERM
+     * from futimes() when asked to preserve times, see ticketref:18569.
      */
+    iattr->ia_valid |= ATTR_FORCE;
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 9, 0)
     rc = setattr_prepare(dentry, iattr);