VirtualBox

Changeset 79087 in vbox for trunk/src/VBox/ValidationKit


Ignore:
Timestamp:
Jun 11, 2019 11:58:28 AM (6 years ago)
Author:
vboxsync
Message:

ValKit: New pylint version - cleanup in progress.

Location:
trunk/src/VBox/ValidationKit
Files:
79 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/VBox/ValidationKit/analysis/reader.py

    r76553 r79087  
    3737import traceback
    3838
    39 # pylint: disable=C0111
     39# pylint: disable=missing-docstring
    4040
    4141class Value(object):

  • trunk/src/VBox/ValidationKit/common/netutils.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""

  • trunk/src/VBox/ValidationKit/common/utils.py

    r78472 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""
    … …  
    320320    else:
    321321        try:
    322             from fcntl import FD_CLOEXEC, F_GETFD, F_SETFD, fcntl; # pylint: disable=F0401
     322            from fcntl import FD_CLOEXEC, F_GETFD, F_SETFD, fcntl; # pylint: disable=import-error
    323323        except:
    324324            # On windows, we can use the 'N' flag introduced in Visual C++ 7.0 or 7.1 with python 2.x.
    … …  
    399399        if uPythonVer < ((3 << 16) | 4):
    400400            try:
    401                 from fcntl import FD_CLOEXEC, F_GETFD, F_SETFD, fcntl; # pylint: disable=F0401
     401                from fcntl import FD_CLOEXEC, F_GETFD, F_SETFD, fcntl; # pylint: disable=import-error
    402402            except:
    403403                pass;
    … …  
    411411    """
    412412    try:
    413         sRet = os.readlink(sPath); # pylint: disable=E1101
     413        sRet = os.readlink(sPath); # pylint: disable=no-member
    414414    except:
    415415        return sXcptRet;
    … …  
    583583        cbFreeSpace = oCTypeFreeSpace.value;
    584584    else:
    585         oStats = os.statvfs(sPath); # pylint: disable=E1101
     585        oStats = os.statvfs(sPath); # pylint: disable=no-member
    586586        cbFreeSpace = long(oStats.f_frsize) * oStats.f_bfree;
    587587
    … …  
    685685    fIsRoot = True;
    686686    try:
    687         fIsRoot = os.getuid() == 0; # pylint: disable=E1101
     687        fIsRoot = os.getuid() == 0; # pylint: disable=no-member
    688688    except:
    689689        pass;
    … …  
    797797    else:
    798798        try:
    799             os.kill(uPid, signal.SIGUSR1); # pylint: disable=E1101
     799            os.kill(uPid, signal.SIGUSR1); # pylint: disable=no-member
    800800            fRc = True;
    801801        except:
    … …  
    840840    else:
    841841        try:
    842             os.kill(uPid, signal.SIGKILL); # pylint: disable=E1101
     842            os.kill(uPid, signal.SIGKILL); # pylint: disable=no-member
    843843            fRc = True;
    844844        except:
    … …  
    898898    if sys.platform == 'win32':
    899899        try:
    900             from win32com.client import GetObject; # pylint: disable=F0401
     900            from win32com.client import GetObject; # pylint: disable=import-error
    901901            oWmi = GetObject('winmgmts:');
    902902            aoProcesses = oWmi.InstancesOf('Win32_Process');
    … …  
    10921092
    10931093
    1094 def processListAll(): # pylint: disable=R0914
     1094def processListAll():
    10951095    """
    10961096    Return a list of ProcessInfo objects for all the processes in the system
    … …  
    11011101    sOs = getHostOs();
    11021102    if sOs == 'win':
    1103         from win32com.client import GetObject; # pylint: disable=F0401
     1103        from win32com.client import GetObject; # pylint: disable=import-error
    11041104        oWmi = GetObject('winmgmts:');
    11051105        aoProcesses = oWmi.InstancesOf('Win32_Process');
    … …  
    21382138#
    21392139
    2140 # pylint: disable=C0111
     2140# pylint: disable=missing-docstring
    21412141# pylint: disable=undefined-variable
    21422142class BuildCategoryDataTestCase(unittest.TestCase):

  • trunk/src/VBox/ValidationKit/common/webutils.py

    r76553 r79087  
    190190#
    191191
    192 # pylint: disable=C0111
     192# pylint: disable=missing-docstring
    193193class CommonUtilsTestCase(unittest.TestCase):
    194194    def testHasSchema(self):

  • trunk/src/VBox/ValidationKit/testboxscript/testboxconnection.py

    r76553 r79087  
    149149        # When connecting we're using a 15 second timeout, we increase it later.
    150150        #
    151         if self._oParsedUrl.scheme == 'https': # pylint: disable=E1101
     151        if self._oParsedUrl.scheme == 'https': # pylint: disable=no-member
    152152            fnCtor = httplib.HTTPSConnection;
    153153        else:
    … …  
    199199            'Connection':       'keep-alive',
    200200        };
    201         sServerPath = '/%s/testboxdisp.py' % (self._oParsedUrl.path.strip('/'),); # pylint: disable=E1101
     201        sServerPath = '/%s/testboxdisp.py' % (self._oParsedUrl.path.strip('/'),); # pylint: disable=no-member
    202202        dParams[constants.tbreq.ALL_PARAM_ACTION] = sAction;
    203203        sBody = urllib_urlencode(dParams);

  • trunk/src/VBox/ValidationKit/testboxscript/testboxscript.py

    r76553 r79087  
    5151
    5252
    53 class TestBoxScriptWrapper(object): # pylint: disable=R0903
     53class TestBoxScriptWrapper(object): # pylint: disable=too-few-public-methods
    5454    """
    5555    Wrapper class

  • trunk/src/VBox/ValidationKit/testboxscript/testboxscript_real.py

    r76553 r79087  
    9696    # Keys for config params
    9797    VALUE = 'value'
    98     FN = 'fn'                           # pylint: disable=C0103
     98    FN = 'fn'                           # pylint: disable=invalid-name
    9999
    100100    ## @}
    … …  
    136136            sSubDir = 'testbox';
    137137            try:
    138                 sSubDir = '%s-%u' % (sSubDir, os.getuid()); # pylint: disable=E1101
     138                sSubDir = '%s-%u' % (sSubDir, os.getuid()); # pylint: disable=no-member
    139139            except:
    140140                pass;
    … …  
    279279            utils.sudoProcessCall(['/sbin/umount', sMountPoint]);
    280280            utils.sudoProcessCall(['/bin/mkdir', '-p', sMountPoint]);
    281             utils.sudoProcessCall(['/usr/sbin/chown', str(os.getuid()), sMountPoint]); # pylint: disable=E1101
     281            utils.sudoProcessCall(['/usr/sbin/chown', str(os.getuid()), sMountPoint]); # pylint: disable=no-member
    282282            if sType == 'cifs':
    283283                # Note! no smb://server/share stuff here, 10.6.8 didn't like it.
    … …  
    302302                                                + ',password=' + sPassword
    303303                                                + ',sec=ntlmv2'
    304                                                 + ',uid=' + str(os.getuid()) # pylint: disable=E1101
    305                                                 + ',gid=' + str(os.getgid()) # pylint: disable=E1101
     304                                                + ',uid=' + str(os.getuid()) # pylint: disable=no-member
     305                                                + ',gid=' + str(os.getgid()) # pylint: disable=no-member
    306306                                                + ',nounix,file_mode=0555,dir_mode=0555,soft,ro'
    307307                                                + sMountOpt,
    … …  
    330330                                                '-o',
    331331                                                'user=' + sUser
    332                                                 + ',uid=' + str(os.getuid()) # pylint: disable=E1101
    333                                                 + ',gid=' + str(os.getgid()) # pylint: disable=E1101
     332                                                + ',uid=' + str(os.getuid()) # pylint: disable=no-member
     333                                                + ',gid=' + str(os.getgid()) # pylint: disable=no-member
    334334                                                + ',fileperms=0555,dirperms=0555,noxattr,ro'
    335335                                                + sMountOpt,
    … …  
    449449            # Windows: WMI
    450450            try:
    451                 import win32com.client;  # pylint: disable=F0401
     451                import win32com.client;  # pylint: disable=import-error
    452452                oWmi  = win32com.client.Dispatch('WbemScripting.SWbemLocator');
    453453                oWebm = oWmi.ConnectServer('.', 'root\\cimv2');
    … …  
    592592            cMbFreeSpace = cTypeMbFreeSpace.value
    593593        else:
    594             stats = os.statvfs(self._oOptions.sScratchRoot); # pylint: disable=E1101
     594            stats = os.statvfs(self._oOptions.sScratchRoot); # pylint: disable=no-member
    595595            cMbFreeSpace = stats.f_frsize * stats.f_bfree
    596596
    … …  
    687687            fUseTheForce = self._fFirstSignOn;
    688688
    689         class ErrorCallback(object): # pylint: disable=R0903
     689        class ErrorCallback(object): # pylint: disable=too-few-public-methods
    690690            """
    691691            Callbacks + state for the cleanup.

  • trunk/src/VBox/ValidationKit/testboxscript/testboxtasks.py

    r77165 r79087  
    432432                                            close_fds  = (False if utils.getHostOs() == 'win' else True),
    433433                                            preexec_fn = (None if utils.getHostOs() in ['win', 'os2']
    434                                                           else os.setsid)); # pylint: disable=E1101
     434                                                          else os.setsid)); # pylint: disable=no-member
    435435        except Exception as oXcpt:
    436436            self._log('Error creating child process %s: %s' % (asArgs, oXcpt));
    … …  
    518518            if iProcGroup > 0:
    519519                try:
    520                     os.killpg(iProcGroup, signal.SIGTERM); # pylint: disable=E1101
     520                    os.killpg(iProcGroup, signal.SIGTERM); # pylint: disable=no-member
    521521                except Exception as oXcpt:
    522522                    self._log('killpg() failed: %s' % (oXcpt,));
    … …  
    534534        if iProcGroup > 0:
    535535            try:
    536                 os.killpg(iProcGroup, signal.SIGKILL); # pylint: disable=E1101
     536                os.killpg(iProcGroup, signal.SIGKILL); # pylint: disable=no-member
    537537            except Exception as oXcpt:
    538538                self._log('killpg() failed: %s' % (oXcpt,));

  • trunk/src/VBox/ValidationKit/testdriver/base.py

    r79067 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""
    … …  
    222222        fRc = False;
    223223    else:
    224         fRc = __processSudoKill(uPid, signal.SIGUSR1, fSudo); # pylint: disable=E1101
     224        fRc = __processSudoKill(uPid, signal.SIGUSR1, fSudo); # pylint: disable=no-member
    225225    return fRc;
    226226
    … …  
    246246        fRc = winbase.processKill(uPid);
    247247    else:
    248         fRc = __processSudoKill(uPid, signal.SIGKILL, fSudo); # pylint: disable=E1101
     248        fRc = __processSudoKill(uPid, signal.SIGKILL, fSudo); # pylint: disable=no-member
    249249    return fRc;
    250250
    … …  
    307307
    308308            # ps fails with non-zero exit code if the pid wasn't found.
    309             if iExitCode is not 0:
     309            if iExitCode != 0:
    310310                return False;
    311311            if sCurName is None:
    … …  
    380380    def __del__(self):
    381381        """In case we need it later on."""
    382         pass;
     382        pass;   # pylint: disable=unnecessary-pass
    383383
    384384    def toString(self):
    … …  
    395395    def lockTask(self):
    396396        """ Wrapper around oCv.acquire(). """
    397         if True is True: # change to False for debugging deadlocks.
     397        if True is True: # change to False for debugging deadlocks. # pylint: disable=comparison-with-itself
    398398            self.oCv.acquire();
    399399        else:
    … …  
    600600                    try:
    601601                        (uPid, uStatus) = os.waitpid(self.hWin, 0);
    602                         if uPid == self.hWin or uPid == self.uPid:
     602                        if uPid in (self.hWin, self.uPid,):
    603603                            self.hWin.Detach(); # waitpid closed it, so it's now invalid.
    604604                            self.hWin = None;
    … …  
    613613            else:
    614614                try:
    615                     (uPid, uStatus) = os.waitpid(self.uPid, os.WNOHANG); # pylint: disable=E1101
     615                    (uPid, uStatus) = os.waitpid(self.uPid, os.WNOHANG); # pylint: disable=no-member
    616616                except:
    617617                    reporter.logXcpt();
    … …  
    773773
    774774
    775 class TestDriverBase(object): # pylint: disable=R0902
     775class TestDriverBase(object): # pylint: disable=too-many-instance-attributes
    776776    """
    777777    The base test driver.
    … …  
    16281628
    16291629
    1630     def innerMain(self, asArgs = None): # pylint: disable=R0915
     1630    def innerMain(self, asArgs = None): # pylint: disable=too-many-statements
    16311631        """
    16321632        Exception wrapped main() worker.
    … …  
    17491749
    17501750# The old, deprecated name.
    1751 TestDriver = TestDriverBase; # pylint: disable=C0103
     1751TestDriver = TestDriverBase; # pylint: disable=invalid-name
    17521752
    17531753
    … …  
    17561756#
    17571757
    1758 # pylint: disable=C0111
     1758# pylint: disable=missing-docstring
    17591759class TestDriverBaseTestCase(unittest.TestCase):
    17601760    def setUp(self):

  • trunk/src/VBox/ValidationKit/testdriver/btresolver.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""
    … …  
    548548                self.oResolverOs = BacktraceResolverOsLinux(self.sScratchDbgPath, self.sScratchPath, self.fnLog);
    549549            elif self.sTargetOs == 'darwin':
    550                 self.oResolverOs = BacktraceResolverOsDarwin(self.sScratchDbgPath, self.sScratchPath, self.fnLog); # pylint: disable=R0204
     550                self.oResolverOs = BacktraceResolverOsDarwin(self.sScratchDbgPath, self.sScratchPath, self.fnLog); # pylint: disable=redefined-variable-type
    551551            elif self.sTargetOs == 'solaris':
    552                 self.oResolverOs = BacktraceResolverOsSolaris(self.sScratchDbgPath, self.sScratchPath, self.fnLog); # pylint: disable=R0204
     552                self.oResolverOs = BacktraceResolverOsSolaris(self.sScratchDbgPath, self.sScratchPath, self.fnLog); # pylint: disable=redefined-variable-type
    553553            else:
    554554                self.log('The backtrace resolver is not supported on %s' % (self.sTargetOs,));

  • trunk/src/VBox/ValidationKit/testdriver/reporter.py

    r78973 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""
    … …  
    677677        if     sys.version_info[0] >= 3 \
    678678           or (sys.version_info[0] == 2 and sys.version_info[1] >= 6):
    679             if self._oParsedTmUrl.scheme == 'https': # pylint: disable=E1101
     679            if self._oParsedTmUrl.scheme == 'https': # pylint: disable=no-member
    680680                self._fnTmConnect = lambda: httplib.HTTPSConnection(self._oParsedTmUrl.hostname,
    681681                                                                    timeout = self.kcSecTestManagerRequestTimeout);
    … …  
    684684                                                                    timeout = self.kcSecTestManagerRequestTimeout);
    685685        else:
    686             if self._oParsedTmUrl.scheme == 'https': # pylint: disable=E1101
     686            if self._oParsedTmUrl.scheme == 'https': # pylint: disable=no-member
    687687                self._fnTmConnect = lambda: httplib.HTTPSConnection(self._oParsedTmUrl.hostname);
    688688            else:
    … …  
    704704        };
    705705        self._sTmServerPath = '/%s/testboxdisp.py?%s' \
    706                             % ( self._oParsedTmUrl.path.strip('/'), # pylint: disable=E1101
     706                            % ( self._oParsedTmUrl.path.strip('/'), # pylint: disable=no-member
    707707                                self._fnUrlEncode(dParams), );
    708708
    … …  
    16871687
    16881688    cThread = 0;
    1689     for idThread, oStack in sys._current_frames().items(): # >=2.5, a bit ugly - pylint: disable=W0212
     1689    for idThread, oStack in sys._current_frames().items(): # >=2.5, a bit ugly - pylint: disable=protected-access
    16901690        try:
    16911691            if cThread > 0:

  • trunk/src/VBox/ValidationKit/testdriver/tst-txsclient.py

    r76553 r79087  
    6969    return 'FAILED';
    7070
    71 def main(asArgs): # pylint: disable=C0111,R0914,R0915
     71def main(asArgs): # pylint: disable=missing-docstring,too-many-locals,too-many-statements
    7272    cMsTimeout      = long(30*1000);
    7373    sAddress        = 'localhost';

  • trunk/src/VBox/ValidationKit/testdriver/txsclient.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""
    … …  
    719719    #
    720720    # Process task
    721     # pylint: disable=C0111
     721    # pylint: disable=missing-docstring
    722722    #
    723723
    724     def taskExecEx(self, sExecName, fFlags, asArgs, asAddEnv, oStdIn, oStdOut, oStdErr, oTestPipe, sAsUser): # pylint: disable=R0913,R0914,R0915,C0301
     724    def taskExecEx(self, sExecName, fFlags, asArgs, asAddEnv, oStdIn, oStdOut, oStdErr, oTestPipe, sAsUser): # pylint: disable=too-many-arguments,too-many-locals,too-many-statements,line-too-long
    725725        # Construct the payload.
    726726        aoPayload = [long(fFlags), '%s' % (sExecName), long(len(asArgs))];
    … …  
    918918        for o in (oStdIn, oStdOut, oStdErr, oTestPipe):
    919919            if o is not None and not utils.isString(o):
    920                 del o.uTxsClientCrc32;      # pylint: disable=E1103
     920                del o.uTxsClientCrc32;      # pylint: disable=maybe-no-member
    921921                # Make sure all files are closed
    922                 o.close();                  # pylint: disable=E1103
     922                o.close();                  # pylint: disable=maybe-no-member
    923923        reporter.log('taskExecEx: returns %s' % (rc));
    924924        return rc;
    … …  
    10511051    def taskUploadString(self, sContent, sRemoteFile):
    10521052        # Wrap sContent in a file like class.
    1053         class InStringFile(object): # pylint: disable=R0903
     1053        class InStringFile(object): # pylint: disable=too-few-public-methods
    10541054            def __init__(self, sContent):
    10551055                self.sContent = sContent;
    … …  
    11481148    def taskDownloadString(self, sRemoteFile, sEncoding = 'utf-8', fIgnoreEncodingErrors = True):
    11491149        # Wrap sContent in a file like class.
    1150         class OutStringFile(object): # pylint: disable=R0903
     1150        class OutStringFile(object): # pylint: disable=too-few-public-methods
    11511151            def __init__(self):
    11521152                self.asContent = [];
    … …  
    12321232        return rc;
    12331233
    1234     # pylint: enable=C0111
     1234    # pylint: enable=missing-docstring
    12351235
    12361236
    … …  
    13101310    #
    13111311
    1312     def asyncExecEx(self, sExecName, asArgs = (), asAddEnv = (), # pylint: disable=R0913
     1312    def asyncExecEx(self, sExecName, asArgs = (), asAddEnv = (), # pylint: disable=too-many-arguments
    13131313                    oStdIn = None, oStdOut = None, oStdErr = None, oTestPipe = None,
    13141314                    sAsUser = "", cMsTimeout = 3600000, fIgnoreErrors = False):
    … …  
    13391339                               oStdOut, oStdErr, oTestPipe, sAsUser));
    13401340
    1341     def syncExecEx(self, sExecName, asArgs = (), asAddEnv = (), # pylint: disable=R0913
     1341    def syncExecEx(self, sExecName, asArgs = (), asAddEnv = (), # pylint: disable=too-many-arguments
    13421342                   oStdIn = '/dev/null', oStdOut = '/dev/null',
    13431343                   oStdErr = '/dev/null', oTestPipe = '/dev/null',
    … …  
    18951895        oWakeupW = None;
    18961896        if hasattr(socket, 'socketpair'):
    1897             try:    (oWakeupR, oWakeupW) = socket.socketpair();         # pylint: disable=E1101
     1897            try:    (oWakeupR, oWakeupW) = socket.socketpair();         # pylint: disable=no-member
    18981898            except: reporter.logXcpt('socket.socketpair() failed');
    18991899

  • trunk/src/VBox/ValidationKit/testdriver/vbox.py

    r79056 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""
    … …  
    6868#
    6969
    70 ComException = None;                                                            # pylint: disable=C0103
    71 __fnComExceptionGetAttr__ = None;                                               # pylint: disable=C0103
     70ComException = None;                                                            # pylint: disable=invalid-name
     71__fnComExceptionGetAttr__ = None;                                               # pylint: disable=invalid-name
    7272
    7373def __MyDefaultGetAttr(oSelf, sName):
    … …  
    110110    exceptions and errors.
    111111    """
    112     global ComException                                                         # pylint: disable=C0103
    113     global __fnComExceptionGetAttr__                                            # pylint: disable=C0103
     112    global ComException                                                         # pylint: disable=invalid-name
     113    global __fnComExceptionGetAttr__                                            # pylint: disable=invalid-name
    114114
    115115    # Hook up our attribute getter for the exception class (ASSUMES new-style).
    … …  
    210210
    211211    # Reverse lookup table.
    212     dDecimalToConst = {}; # pylint: disable=C0103
     212    dDecimalToConst = {}; # pylint: disable=invalid-name
    213213
    214214    def __init__(self):
    … …  
    329329
    330330
    331 class Build(object): # pylint: disable=R0903
     331class Build(object): # pylint: disable=too-few-public-methods
    332332    """
    333333    A VirtualBox build.
    … …  
    372372            sSearch = os.environ.get('VBOX_TD_DEV_TREE', os.path.dirname(__file__)); # Env.var. for older trees or testboxscript.
    373373            sCandidat = None;
    374             for i in range(0, 10):                                          # pylint: disable=W0612
     374            for i in range(0, 10):                                          # pylint: disable=unused-variable
    375375                sBldDir = os.path.join(sSearch, sOut);
    376376                if os.path.isdir(sBldDir):
    … …  
    453453        self.oEventSrc  = dArgs['oEventSrc']; # Console/VirtualBox for < 3.3
    454454        self.oListener  = dArgs['oListener'];
    455         self.fPassive   = self.oListener != None;
     455        self.fPassive   = self.oListener is not None;
    456456        self.sName      = sName
    457457        self.fShutdown  = False;
    … …  
    616616
    617617
    618     # pylint: disable=C0111,R0913,W0613
     618    # pylint: disable=missing-docstring,too-many-arguments,unused-argument
    619619    def onMousePointerShapeChange(self, fVisible, fAlpha, xHot, yHot, cx, cy, abShape):
    620620        reporter.log2('onMousePointerShapeChange/%s' % (self.sName));
    … …  
    657657        reporter.log2('onShowWindow/%s' % (self.sName));
    658658        return None;
    659     # pylint: enable=C0111,R0913,W0613
     659    # pylint: enable=missing-docstring,too-many-arguments,unused-argument
    660660
    661661    def handleEvent(self, oEvt):
    … …  
    698698        EventHandlerBase.__init__(self, dArgs, self.oVBox.fpApiVer, sName);
    699699
    700     # pylint: disable=C0111,W0613
     700    # pylint: disable=missing-docstring,unused-argument
    701701    def onMachineStateChange(self, sMachineId, eState):
    702702        pass;
    … …  
    724724    def onGuestPropertyChange(self, sMachineId, sName, sValue, sFlags):
    725725        pass;
    726     # pylint: enable=C0111,W0613
     726    # pylint: enable=missing-docstring,unused-argument
    727727
    728728    def handleEvent(self, oEvt):
    … …  
    763763        ConsoleEventHandlerBase.__init__(self, dArgs);
    764764
    765     def onMachineStateChange(self, sMachineId, eState):                         # pylint: disable=W0613
     765    def onMachineStateChange(self, sMachineId, eState):                         # pylint: disable=unused-argument
    766766        """ Just interrupt the wait loop here so it can check again. """
    767767        _ = sMachineId; _ = eState;
    … …  
    782782
    783783
    784 class TestDriver(base.TestDriver):                                              # pylint: disable=R0902
     784class TestDriver(base.TestDriver):                                              # pylint: disable=too-many-instance-attributes
    785785    """
    786786    This is the VirtualBox test driver.
    … …  
    846846
    847847        # Try dev build first since that's where I'll be using it first...
    848         if True is True:
     848        if True is True: # pylint: disable=comparison-with-itself
    849849            try:
    850850                self.oBuild = Build(self, None);
    … …  
    10081008        return self.fImportedVBoxApi;
    10091009
    1010     def _startVBoxSVC(self): # pylint: disable=R0915
     1010    def _startVBoxSVC(self): # pylint: disable=too-many-statements
    10111011        """ Starts VBoxSVC. """
    10121012        assert(self.oVBoxSvcProcess is None);
    … …  
    10581058                sWinDbg = 'c:\\Program Files\\Debugging Tools for Windows\\windbg.exe';
    10591059                if not os.path.isfile(sWinDbg): sWinDbg = 'c:\\Program Files\\Debugging Tools for Windows (x64)\\windbg.exe';
    1060                 if not os.path.isfile(sWinDbg): sWinDbg = 'c:\\Programme\\Debugging Tools for Windows\\windbg.exe'; # Localization rulez!  pylint: disable=C0301
     1060                if not os.path.isfile(sWinDbg): sWinDbg = 'c:\\Programme\\Debugging Tools for Windows\\windbg.exe'; # Localization rulez!  pylint: disable=line-too-long
    10611061                if not os.path.isfile(sWinDbg): sWinDbg = 'c:\\Programme\\Debugging Tools for Windows (x64)\\windbg.exe';
    10621062                if not os.path.isfile(sWinDbg): sWinDbg = 'windbg'; # WinDbg must be in the path; better than nothing.
    … …  
    10871087                self.oVBoxSvcProcess = base.Process.spawn(sVBoxSVC, sVBoxSVC, '--auto-shutdown'); # SIGUSR1 requirement.
    10881088                try: # Try make sure we get the SIGINT and not VBoxSVC.
    1089                     os.setpgid(self.oVBoxSvcProcess.getPid(), 0); # pylint: disable=E1101
    1090                     os.setpgid(0, 0);                             # pylint: disable=E1101
     1089                    os.setpgid(self.oVBoxSvcProcess.getPid(), 0); # pylint: disable=no-member
     1090                    os.setpgid(0, 0);                             # pylint: disable=no-member
    10911091                except:
    10921092                    reporter.logXcpt();
    … …  
    11291129        # Fudge and pid file.
    11301130        #
    1131         if self.oVBoxSvcProcess != None and not self.oVBoxSvcProcess.wait(cMsFudge):
     1131        if self.oVBoxSvcProcess is not None and not self.oVBoxSvcProcess.wait(cMsFudge):
    11321132            if fWritePidFile:
    11331133                iPid = self.oVBoxSvcProcess.getPid();
    … …  
    11491149            except: pass;
    11501150
    1151         return self.oVBoxSvcProcess != None;
     1151        return self.oVBoxSvcProcess is not None;
    11521152
    11531153
    … …  
    12611261
    12621262        try:
    1263             from vboxapi import VirtualBoxManager # pylint: disable=import-error
     1263            from vboxapi import VirtualBoxManager; # pylint: disable=import-error
    12641264        except:
    12651265            reporter.logXcpt('Error importing vboxapi');
    … …  
    12701270            # pylint: disable=import-error
    12711271            if self.sHost == 'win':
    1272                 from pythoncom import com_error as NativeComExceptionClass  # pylint: disable=E0611
     1272                from pythoncom import com_error as NativeComExceptionClass  # pylint: disable=no-name-in-module
    12731273                import winerror                 as NativeComErrorClass
    12741274            else:
    … …  
    13921392            if oXcpt is None: oXcpt = sys.exc_info()[1];
    13931393            if sys.platform == 'win32':
    1394                 from pythoncom import com_error as NativeComExceptionClass  # pylint: disable=import-error,E0611
     1394                from pythoncom import com_error as NativeComExceptionClass  # pylint: disable=import-error,no-name-in-module
    13951395            else:
    13961396                from xpcom import Exception     as NativeComExceptionClass  # pylint: disable=import-error
    … …  
    14001400            """ See vboxapi. """
    14011401            hrXcpt = oSelf.xcptGetResult(oXcpt);
    1402             return hrXcpt == hrStatus or hrXcpt == hrStatus - 0x100000000;
     1402            return hrXcpt == hrStatus or hrXcpt == hrStatus - 0x100000000;  # pylint: disable=consider-using-in
    14031403
    14041404        def _xcptToString(oSelf, oXcpt):
    … …  
    14781478                # Also, it keeps a number of internal objects and interfaces around to do its job, so shutting
    14791479                # it down before we go looking for dangling interfaces is more or less required.
    1480                 from xpcom import _xpcom as _xpcom;             # pylint: disable=import-error
     1480                from xpcom import _xpcom as _xpcom;             # pylint: disable=import-error,useless-import-alias
    14811481                hrc   = _xpcom.DeinitCOM();
    1482                 cIfs  = _xpcom._GetInterfaceCount();            # pylint: disable=W0212
    1483                 cObjs = _xpcom._GetGatewayCount();              # pylint: disable=W0212
     1482                cIfs  = _xpcom._GetInterfaceCount();            # pylint: disable=protected-access
     1483                cObjs = _xpcom._GetGatewayCount();              # pylint: disable=protected-access
    14841484
    14851485                if cObjs == 0 and cIfs == 0:
    … …  
    14891489                                 % (cObjs, cIfs, hrc));
    14901490                    if hasattr(_xpcom, '_DumpInterfaces'):
    1491                         try:    _xpcom._DumpInterfaces();       # pylint: disable=W0212
     1491                        try:    _xpcom._DumpInterfaces();       # pylint: disable=protected-access
    14921492                        except: reporter.logXcpt('_teardownVBoxApi: _DumpInterfaces failed');
    14931493
    … …  
    16661666        return rc;
    16671667
    1668     def parseOption(self, asArgs, iArg): # pylint: disable=R0915
     1668    def parseOption(self, asArgs, iArg): # pylint: disable=too-many-statements
    16691669        if asArgs[iArg] == '--vbox-session-type':
    16701670            iArg += 1;
    … …  
    19451945        return None;
    19461946
    1947     def _logVmInfoUnsafe(self, oVM):                                            # pylint: disable=R0915,R0912
     1947    def _logVmInfoUnsafe(self, oVM):                                            # pylint: disable=too-many-statements,too-many-branches
    19481948        """
    19491949        Internal worker for logVmInfo that is wrapped in try/except.
    … …  
    21532153        return True;
    21542154
    2155     def logVmInfo(self, oVM):                                                   # pylint: disable=R0915,R0912
     2155    def logVmInfo(self, oVM):                                                   # pylint: disable=too-many-statements,too-many-branches
    21562156        """
    21572157        Logs VM configuration details.
    … …  
    21942194                    reporter.logXcpt();
    21952195                else:
    2196                     if sIdOrDesc == sId or sIdOrDesc == sDesc:
     2196                    if sIdOrDesc in (sId, sDesc,):
    21972197                        sIdOrDesc = sId;
    21982198                        break;
    … …  
    22392239                    return oVM;
    22402240                except:
     2241                    reporter.logXcpt();
    22412242                    raise;
    22422243            except:
    … …  
    22592260        return None;
    22602261
    2261     # pylint: disable=R0913,R0914,R0915
     2262    # pylint: disable=too-many-arguments,too-many-locals,too-many-statements
    22622263    def createTestVM(self,
    22632264                     sName,
    … …  
    23752376        self.logVmInfo(oVM); # testing...
    23762377        return oVM;
    2377     # pylint: enable=R0913,R0914,R0915
     2378    # pylint: enable=too-many-arguments,too-many-locals,too-many-statements
    23782379
    23792380    def createTestVmWithDefaults(self,                                      # pylint: disable=too-many-arguments
    … …  
    26092610          and sCurName != '' \
    26102611          and base.timestampMilli() - msStart < cMsTimeout \
    2611           and (   eCurState == vboxcon.SessionState_Unlocking \
    2612                or eCurState == vboxcon.SessionState_Spawning \
    2613                or eCurState == vboxcon.SessionState_Locked):
     2612          and eCurState in (vboxcon.SessionState_Unlocking, vboxcon.SessionState_Spawning, vboxcon.SessionState_Locked,):
    26142613            self.processEvents(1000);
    26152614            try:
    … …  
    26622661        return fRc;
    26632662
    2664     def startVmEx(self, oVM, fWait = True, sType = None, sName = None, asEnv = None): # pylint: disable=R0914,R0915
     2663    def startVmEx(self, oVM, fWait = True, sType = None, sName = None, asEnv = None): # pylint: disable=too-many-locals,too-many-statements
    26652664        """
    26662665        Start the VM, returning the VM session and progress object on success.
    … …  
    27582757                    if   self.fpApiVer < 4.3 \
    27592758                      or (self.fpApiVer == 4.3 and not hasattr(self.oVBoxMgr, 'getSessionObject')):
    2760                         oSession = self.oVBoxMgr.mgr.getSessionObject(self.oVBox);  # pylint: disable=E1101
     2759                        oSession = self.oVBoxMgr.mgr.getSessionObject(self.oVBox);  # pylint: disable=no-member
    27612760                    elif self.fpApiVer < 5.2 \
    27622761                      or (self.fpApiVer == 5.2 and hasattr(self.oVBoxMgr, 'vbox')):
    2763                         oSession = self.oVBoxMgr.getSessionObject(self.oVBox);      # pylint: disable=E1101
     2762                        oSession = self.oVBoxMgr.getSessionObject(self.oVBox);      # pylint: disable=no-member
    27642763                    else:
    2765                         oSession = self.oVBoxMgr.getSessionObject();                # pylint: disable=E1101,E1120
     2764                        oSession = self.oVBoxMgr.getSessionObject();           # pylint: disable=no-member,no-value-for-parameter
    27662765                    if self.fpApiVer < 3.3:
    27672766                        oProgress = self.oVBox.openRemoteSession(oSession, sUuid, sType, sEnv);
    … …  
    27752774                    oSession = None;
    27762775                    if i >= 0:
    2777                         reporter.logXcpt('warning: failed to start VM "%s" ("%s") - retrying in %u secs.' % (sUuid, oVM, i));     # pylint: disable=C0301
     2776                        reporter.logXcpt('warning: failed to start VM "%s" ("%s") - retrying in %u secs.' % (sUuid, oVM, i));     # pylint: disable=line-too-long
    27782777                self.waitOnDirectSessionClose(oVM, 5000 + i * 1000);
    27792778        if fWait and oProgress is not None:
    … …  
    28422841        return oSession;
    28432842
    2844     def terminateVmBySession(self, oSession, oProgress = None, fTakeScreenshot = None): # pylint: disable=R0915
     2843    def terminateVmBySession(self, oSession, oProgress = None, fTakeScreenshot = None): # pylint: disable=too-many-statements
    28452844        """
    28462845        Terminates the VM specified by oSession and adds the release logs to
    … …  
    32913290        fRemoveTxs = self.addTask(oTxsSession);
    32923291
    3293         rc = fnAsync(*aArgs); # pylint: disable=W0142
     3292        rc = fnAsync(*aArgs); # pylint: disable=star-args
    32943293        if rc is True:
    32953294            rc = False;
    … …  
    33253324        return rc;
    33263325
    3327     # pylint: disable=C0111
     3326    # pylint: disable=missing-docstring
    33283327
    33293328    def txsDisconnect(self, oSession, oTxsSession, cMsTimeout = 30000, fIgnoreErrors = False):
    … …  
    34243423                              (sRemoteFile, sRemoteDir, self.adjustTimeoutMs(cMsTimeout), fIgnoreErrors));
    34253424
    3426     # pylint: enable=C0111
     3425    # pylint: enable=missing-docstring
    34273426
    34283427    def txsCdWait(self,
    … …  
    36523651        return (fRc, oTxsSession);
    36533652
    3654     # pylint: disable=R0914,R0913
     3653    # pylint: disable=too-many-locals,too-many-arguments
    36553654
    36563655    def txsRunTest(self, oTxsSession, sTestName, cMsTimeout, sExecName, asArgs = (), asAddEnv = (), sAsUser = ""):
    … …  
    38103809        return fRc;
    38113810
    3812     # pylint: enable=R0914,R0913
     3811    # pylint: enable=too-many-locals,too-many-arguments
    38133812
    38143813

  • trunk/src/VBox/ValidationKit/testdriver/vboxcon.py

    r76553 r79087  
    3636
    3737
    38 class VBoxConstantWrappingHack(object):                                         # pylint: disable=R0903
     38class VBoxConstantWrappingHack(object):                                         # pylint: disable=too-few-public-methods
    3939    """
    4040    This is a hack to avoid the self.oVBoxMgr.constants.MachineState_Running
    … …  
    8080
    8181
    82 goHackModuleClass = VBoxConstantWrappingHack(sys.modules[__name__]);                         # pylint: disable=C0103
     82goHackModuleClass = VBoxConstantWrappingHack(sys.modules[__name__]);                         # pylint: disable=invalid-name
    8383sys.modules[__name__] = goHackModuleClass;
    8484

  • trunk/src/VBox/ValidationKit/testdriver/vboxinstaller.py

    r78385 r79087  
    837837        """
    838838
    839         import win32com.client; # pylint: disable=F0401
     839        import win32com.client; # pylint: disable=import-error
    840840        win32com.client.gencache.EnsureModule('{000C1092-0000-0000-C000-000000000046}', 1033, 1, 0);
    841841        oInstaller = win32com.client.Dispatch('WindowsInstaller.Installer',

  • trunk/src/VBox/ValidationKit/testdriver/vboxtestvms.py

    r79071 r79087  
    7171## @name Flags.
    7272## @{
    73 g_k32           = 32;                   # pylint: disable=C0103
    74 g_k64           = 64;                   # pylint: disable=C0103
    75 g_k32_64        = 96;                   # pylint: disable=C0103
     73g_k32           = 32;                   # pylint: disable=invalid-name
     74g_k64           = 64;                   # pylint: disable=invalid-name
     75g_k32_64        = 96;                   # pylint: disable=invalid-name
    7676g_kiArchMask    = 96;
    7777g_kiNoRaw       = 128;                  ##< No raw mode.
    … …  
    8787
    8888# Table translating from VM name core to a more detailed guest info.
    89 # pylint: disable=C0301
     89# pylint: disable=line-too-long
    9090## @todo what's the difference between the first two columns again?
    9191g_aaNameToDetails = \
    … …  
    179179
    180180
    181 # pylint: enable=C0301
     181# pylint: enable=line-too-long
    182182
    183183def _intersects(asSet1, asSet2):
    … …  
    199199    """
    200200
    201     def __init__(self, # pylint: disable=R0913
     201    def __init__(self, # pylint: disable=too-many-arguments
    202202                 sVmName,                                   # type: str
    203203                 fGrouping = 0,                             # type: int
    … …  
    904904    """
    905905
    906     def __init__(self, # pylint: disable=R0913
     906    def __init__(self, # pylint: disable=too-many-arguments
    907907                 sVmName,                                   # type: str
    908908                 fGrouping = 0,                             # type: int
    … …  
    13951395
    13961396
    1397     def __init__(self, # pylint: disable=R0913
     1397    def __init__(self, # pylint: disable=too-many-arguments
    13981398                 sVmName,                                   # type: str
    13991399                 fGrouping = g_kfGrpAncient | g_kfGrpNoTxs, # type: int
    … …  
    17031703        return True;
    17041704
    1705     def actionExecute(self, oTestDrv, fnCallback): # pylint: disable=R0914
     1705    def actionExecute(self, oTestDrv, fnCallback): # pylint: disable=too-many-locals
    17061706        """
    17071707        For base.TestDriver.actionExecute.  Calls the callback function for

  • trunk/src/VBox/ValidationKit/testdriver/vboxwrappers.py

    r79068 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""
    … …  
    102102
    103103
    104 class VirtualBoxWrapper(object): # pylint: disable=R0903
     104class VirtualBoxWrapper(object): # pylint: disable=too-few-public-methods
    105105    """
    106106    Wrapper around the IVirtualBox object that adds some (hopefully) useful
    … …  
    509509        they don't throw errors.
    510510        """
    511         if True is True:
     511        if True is True: # pylint: disable=comparison-with-itself
    512512            try:
    513513                iPct        = self.o.operationPercent;
    … …  
    12801280        Helper that translate the adapter type into a driver name.
    12811281        """
    1282         if    eNicType == vboxcon.NetworkAdapterType_Am79C970A \
    1283            or eNicType == vboxcon.NetworkAdapterType_Am79C973:
     1282        if eNicType in (vboxcon.NetworkAdapterType_Am79C970A, vboxcon.NetworkAdapterType_Am79C973):
    12841283            sName = 'pcnet';
    1285         elif    eNicType == vboxcon.NetworkAdapterType_I82540EM \
    1286              or eNicType == vboxcon.NetworkAdapterType_I82543GC \
    1287              or eNicType == vboxcon.NetworkAdapterType_I82545EM:
     1284        elif eNicType in (vboxcon.NetworkAdapterType_I82540EM,
     1285                          vboxcon.NetworkAdapterType_I82543GC,
     1286                          vboxcon.NetworkAdapterType_I82545EM):
    12881287            sName = 'e1000';
    12891288        elif eNicType == vboxcon.NetworkAdapterType_Virtio:
    … …  
    15621561        # Resolve missing MAC address prefix by feeding in the host IP address bytes.
    15631562        cchMacAddr = len(sMacAddr);
    1564         if cchMacAddr > 0 and cchMacAddr < 12:
     1563        if 0 < cchMacAddr < 12:
    15651564            sHostIP = netutils.getPrimaryHostIp();
    15661565            abHostIP = socket.inet_aton(sHostIP);
    … …  
    19251924        return oHd;
    19261925
    1927     def createAndAttachHd(self, sHd, sFmt = "VDI", sController = "IDE Controller", cb = 10*1024*1024*1024, # pylint: disable=R0913
     1926    def createAndAttachHd(self, sHd, sFmt = "VDI", sController = "IDE Controller", cb = 10*1024*1024*1024, # pylint: disable=too-many-arguments
    19281927                          iPort = 0, iDevice = 0, fImmutable = True, cMsTimeout = 60000, tMediumVariant = None):
    19291928        """
    … …  
    21152114        return True;
    21162115
    2117     def setupPreferredConfig(self):                                             # pylint: disable=R0914
     2116    def setupPreferredConfig(self):                                             # pylint: disable=too-many-locals
    21182117        """
    21192118        Configures the VM according to the preferences of the guest type.
    … …  
    21802179            if not self.enableUsbHid(fUsbHid):          fRc = False;
    21812180            if not self.enableHpet(fHpet):              fRc = False;
    2182         if  eStorCtlType == vboxcon.StorageControllerType_PIIX3 \
    2183          or eStorCtlType == vboxcon.StorageControllerType_PIIX4 \
    2184          or eStorCtlType == vboxcon.StorageControllerType_ICH6:
     2181        if eStorCtlType in (vboxcon.StorageControllerType_PIIX3,
     2182                            vboxcon.StorageControllerType_PIIX4,
     2183                            vboxcon.StorageControllerType_ICH6,):
    21852184            if not self.setStorageControllerType(eStorCtlType, "IDE Controller"):
    21862185                fRc = False;
    … …  
    21902189        return fRc;
    21912190
    2192     def addUsbDeviceFilter(self, sName, sVendorId = None, sProductId = None, sRevision = None, # pylint: disable=R0913
     2191    def addUsbDeviceFilter(self, sName, sVendorId = None, sProductId = None, sRevision = None, # pylint: disable=too-many-arguments
    21932192                           sManufacturer = None, sProduct = None, sSerialNumber = None,
    21942193                           sPort = None, sRemote = None):
    … …  
    30333032        """ Class for looking for IPv4 address changes on interface 0."""
    30343033        def __init__(self, dArgs):
    3035             vbox.VirtualBoxEventHandlerBase.__init__(self, dArgs);              # pylint: disable=W0233
     3034            vbox.VirtualBoxEventHandlerBase.__init__(self, dArgs);
    30363035            self.oParentTask = dArgs['oParentTask'];
    30373036            self.sMachineId  = dArgs['sMachineId'];
    … …  
    30443043                oParentTask = self.oParentTask;
    30453044                if oParentTask:
    3046                     oParentTask._setIp(sValue);                                # pylint: disable=W0212
     3045                    oParentTask._setIp(sValue);                                # pylint: disable=protected-access
    30473046
    30483047

  • trunk/src/VBox/ValidationKit/testdriver/winbase.py

    r76553 r79087  
    143143    if fRc is True:
    144144        try:
    145             from win32com.client import GetObject; # pylint: disable=F0401
     145            from win32com.client import GetObject; # pylint: disable=import-error
    146146            oWmi = GetObject('winmgmts:');
    147147            aoProcesses = oWmi.InstancesOf('Win32_Process');

  • trunk/src/VBox/ValidationKit/testmanager/batch/add_build.py

    r76553 r79087  
    22# -*- coding: utf-8 -*-
    33# $Id$
    4 # pylint: disable=C0301
     4# pylint: disable=line-too-long
    55
    66"""
    … …  
    4444from testmanager.core.build import BuildDataEx, BuildLogic, BuildCategoryData;
    4545
    46 class Build(object): # pylint: disable=R0903
     46class Build(object): # pylint: disable=too-few-public-methods
    4747    """
    4848    Add build info into Test Manager database.

  • trunk/src/VBox/ValidationKit/testmanager/batch/check_for_deleted_builds.py

    r76553 r79087  
    22# -*- coding: utf-8 -*-
    33# $Id$
    4 # pylint: disable=C0301
     4# pylint: disable=line-too-long
    55
    66"""
    … …  
    5353
    5454
    55 class BuildChecker(object): # pylint: disable=R0903
     55class BuildChecker(object): # pylint: disable=too-few-public-methods
    5656    """
    5757    Add build info into Test Manager database.

  • trunk/src/VBox/ValidationKit/testmanager/batch/close_orphaned_testsets.py

    r76553 r79087  
    22# -*- coding: utf-8 -*-
    33# $Id$
    4 # pylint: disable=C0301
     4# pylint: disable=line-too-long
    55
    66"""

  • trunk/src/VBox/ValidationKit/testmanager/batch/del_build.py

    r76553 r79087  
    22# -*- coding: utf-8 -*-
    33# $Id$
    4 # pylint: disable=C0301
     4# pylint: disable=line-too-long
    55
    66"""

  • trunk/src/VBox/ValidationKit/testmanager/batch/filearchiver.py

    r76553 r79087  
    22# -*- coding: utf-8 -*-
    33# $Id$
    4 # pylint: disable=C0301
     4# pylint: disable=line-too-long
    55
    66"""
    … …  
    5353
    5454
    55 class FileArchiverBatchJob(object): # pylint: disable=R0903
     55class FileArchiverBatchJob(object): # pylint: disable=too-few-public-methods
    5656    """
    5757    Log+files comp

  • trunk/src/VBox/ValidationKit/testmanager/batch/regen_sched_queues.py

    r76553 r79087  
    22# -*- coding: utf-8 -*-
    33# $Id$
    4 # pylint: disable=C0301
     4# pylint: disable=line-too-long
    55
    66"""
    … …  
    4949
    5050
    51 class RegenSchedQueues(object): # pylint: disable=R0903
     51class RegenSchedQueues(object): # pylint: disable=too-few-public-methods
    5252    """
    5353    Regenerates all the scheduling queues.

  • trunk/src/VBox/ValidationKit/testmanager/batch/vcs_import.py

    r76553 r79087  
    22# -*- coding: utf-8 -*-
    33# $Id$
    4 # pylint: disable=C0301
     4# pylint: disable=line-too-long
    55
    66"""
    … …  
    4848from common                         import utils;
    4949
    50 class VcsImport(object): # pylint: disable=R0903
     50class VcsImport(object): # pylint: disable=too-few-public-methods
    5151    """
    5252    Imports revision history from a VSC into the Test Manager database.

  • trunk/src/VBox/ValidationKit/testmanager/batch/virtual_test_sheriff.py

    r78770 r79087  
    22# -*- coding: utf-8 -*-
    33# $Id$
    4 # pylint: disable=C0301
     4# pylint: disable=line-too-long
    55
    66"""
    … …  
    275275
    276276
    277 class VirtualTestSheriff(object): # pylint: disable=R0903
     277class VirtualTestSheriff(object): # pylint: disable=too-few-public-methods
    278278    """
    279279    Add build info into Test Manager database.

  • trunk/src/VBox/ValidationKit/testmanager/core/base.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""
    … …  
    4444# Python 3 hacks:
    4545if sys.version_info[0] >= 3:
    46     long = int      # pylint: disable=W0622,C0103
     46    long = int      # pylint: disable=redefined-builtin,invalid-name
    4747
    4848
    … …  
    5151    For exceptions raised by any TestManager component.
    5252    """
    53     pass;
     53    pass;                               # pylint: disable=unnecessary-pass
    5454
    5555
    … …  
    5959    Used by ModelLogicBase decendants.
    6060    """
    61     pass;
     61    pass;                               # pylint: disable=unnecessary-pass
    6262
    6363
    … …  
    6767    Used by ModelLogicBase decendants.
    6868    """
    69     pass;
     69    pass;                               # pylint: disable=unnecessary-pass
    7070
    7171
    … …  
    7575    Used by ModelLogicBase decendants.
    7676    """
    77     pass;
     77    pass;                               # pylint: disable=unnecessary-pass
    7878
    7979
    … …  
    8383    Used by ModelLogicBase decendants.
    8484    """
    85     pass;
     85    pass;                               # pylint: disable=unnecessary-pass
    8686
    8787
    … …  
    9191    Used by ModelLogicBase decendants.
    9292    """
    93     pass;
     93    pass;                               # pylint: disable=unnecessary-pass
    9494
    9595
    … …  
    100100    Used by ModelLogicBase decendants.
    101101    """
    102     pass;
    103 
    104 
    105 class ModelBase(object): # pylint: disable=R0903
     102    pass;                               # pylint: disable=unnecessary-pass
     103
     104
     105class ModelBase(object): # pylint: disable=too-few-public-methods
    106106    """
    107107    Something all classes in the logical model inherits from.
    … …  
    115115
    116116
    117 class ModelDataBase(ModelBase): # pylint: disable=R0903
     117class ModelDataBase(ModelBase): # pylint: disable=too-few-public-methods
    118118    """
    119119    Something all classes in the data classes in the logical model inherits from.
    … …  
    198198        if sPrefix in ['id', 'uid', 'i', 'off', 'pct']:
    199199            return [-1, '', '-1',];
    200         elif sPrefix in ['l', 'c',]:
     200        if sPrefix in ['l', 'c',]:
    201201            return [long(-1), '', '-1',];
    202         elif sPrefix == 'f':
     202        if sPrefix == 'f':
    203203            return ['',];
    204         elif sPrefix in ['enm', 'ip', 's', 'ts', 'uuid']:
     204        if sPrefix in ['enm', 'ip', 's', 'ts', 'uuid']:
    205205            return ['',];
    206         elif sPrefix in ['ai', 'aid', 'al', 'as']:
     206        if sPrefix in ['ai', 'aid', 'al', 'as']:
    207207            return [[], '', None]; ## @todo ??
    208         elif sPrefix == 'bm':
     208        if sPrefix == 'bm':
    209209            return ['', [],]; ## @todo bitmaps.
    210210        raise TMExceptionBase('Unable to classify "%s" (prefix %s)' % (sAttr, sPrefix));
    … …  
    370370
    371371        # Check the NULL requirements of the primary ID(s) for the 'add' and 'edit' actions.
    372         if   enmValidateFor == ModelDataBase.ksValidateFor_Add \
    373           or enmValidateFor == ModelDataBase.ksValidateFor_AddForeignId \
    374           or enmValidateFor == ModelDataBase.ksValidateFor_Edit:
     372        if enmValidateFor in (ModelDataBase.ksValidateFor_Add,
     373                              ModelDataBase.ksValidateFor_AddForeignId,
     374                              ModelDataBase.ksValidateFor_Edit,):
    375375            fMustBeNull = enmValidateFor == ModelDataBase.ksValidateFor_Add;
    376376            sAttr = getattr(self, 'ksIdAttr', None);
    … …  
    572572        if iValue < iMin:
    573573            return (iValue, 'Value too small (min %d)' % (iMin,));
    574         elif iValue > iMax:
     574        if iValue > iMax:
    575575            return (iValue, 'Value too high (max %d)' % (iMax,));
    576576        return (iValue, None);
    … …  
    596596        if lMin is not None and lValue < lMin:
    597597            return (lValue, 'Value too small (min %d)' % (lMin,));
    598         elif lMax is not None and lValue > lMax:
     598        if lMax is not None and lValue > lMax:
    599599            return (lValue, 'Value too high (max %d)' % (lMax,));
    600600        return (lValue, None);
    … …  
    662662
    663663        try:
    664             socket.inet_pton(socket.AF_INET, sValue); # pylint: disable=E1101
     664            socket.inet_pton(socket.AF_INET, sValue); # pylint: disable=no-member
    665665        except:
    666666            try:
    667                 socket.inet_pton(socket.AF_INET6, sValue); # pylint: disable=E1101
     667                socket.inet_pton(socket.AF_INET6, sValue); # pylint: disable=no-member
    668668            except:
    669669                return (sValue, 'Not a valid IP address.');
    … …  
    10671067
    10681068
    1069 # pylint: disable=E1101,C0111,R0903
     1069# pylint: disable=no-member,missing-docstring,too-few-public-methods
    10701070class ModelDataBaseTestCase(unittest.TestCase):
    10711071    """
    … …  
    12411241    def __init__(self):
    12421242        ModelBase.__init__(self);
    1243         self.aCriteria = []; # type: list[FilterCriterion]
     1243        self.aCriteria = [] # type: list[FilterCriterion]
    12441244
    12451245    def _initFromParamsWorker(self, oDisp, oCriterion):
    … …  
    12851285
    12861286
    1287 class ModelLogicBase(ModelBase): # pylint: disable=R0903
     1287class ModelLogicBase(ModelBase): # pylint: disable=too-few-public-methods
    12881288    """
    12891289    Something all classes in the logic classes the logical model inherits from.
    … …  
    13281328
    13291329
    1330 class AttributeChangeEntry(object): # pylint: disable=R0903
     1330class AttributeChangeEntry(object): # pylint: disable=too-few-public-methods
    13311331    """
    13321332    Data class representing the changes made to one attribute.
    … …  
    13401340        self.sOldText       = sOldText;
    13411341
    1342 class AttributeChangeEntryPre(AttributeChangeEntry): # pylint: disable=R0903
     1342class AttributeChangeEntryPre(AttributeChangeEntry): # pylint: disable=too-few-public-methods
    13431343    """
    13441344    AttributeChangeEntry for preformatted values.
    … …  
    13481348        AttributeChangeEntry.__init__(self, sAttr, oNewRaw, oOldRaw, sNewText, sOldText);
    13491349
    1350 class ChangeLogEntry(object): # pylint: disable=R0903
     1350class ChangeLogEntry(object): # pylint: disable=too-few-public-methods
    13511351    """
    13521352    A change log entry returned by the fetchChangeLog method typically

  • trunk/src/VBox/ValidationKit/testmanager/core/build.py

    r76553 r79087  
    143143
    144144
    145 class BuildCategoryLogic(ModelLogicBase): # pylint: disable=R0903
     145class BuildCategoryLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    146146    """
    147147    Build categories database logic.
    … …  
    502502
    503503
    504 class BuildLogic(ModelLogicBase): # pylint: disable=R0903
     504class BuildLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    505505    """
    506506    Build database logic (covers build categories as well as builds).
    … …  
    867867#
    868868
    869 # pylint: disable=C0111
     869# pylint: disable=missing-docstring
    870870class BuildCategoryDataTestCase(ModelDataBaseTestCase):
    871871    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/buildblacklist.py

    r76553 r79087  
    119119
    120120
    121 class BuildBlacklistLogic(ModelLogicBase): # pylint: disable=R0903
     121class BuildBlacklistLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    122122    """
    123123    Build Back List logic.

  • trunk/src/VBox/ValidationKit/testmanager/core/buildsource.py

    r76553 r79087  
    150150        return (oNewValue, sError);
    151151
    152 class BuildSourceLogic(ModelLogicBase): # pylint: disable=R0903
     152class BuildSourceLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    153153    """
    154154    Build source database logic.
    … …  
    504504#
    505505
    506 # pylint: disable=C0111
     506# pylint: disable=missing-docstring
    507507class BuildSourceDataTestCase(ModelDataBaseTestCase):
    508508    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/db.py

    r76553 r79087  
    214214        if config.g_ksDatabasePort is not None:
    215215            dArgs['port'] = config.g_ksDatabasePort;
    216         self._oConn             = psycopg2.connect(**dArgs); # pylint: disable=W0142
     216        self._oConn             = psycopg2.connect(**dArgs); # pylint: disable=star-args
    217217        self._oConn.set_client_encoding('UTF-8');
    218218        self._oCursor           = self._oConn.cursor();
    … …  
    220220        self._oExplainCursor    = None;
    221221        if config.g_kfWebUiSqlTraceExplain and config.g_kfWebUiSqlTrace:
    222             self._oExplainConn  = psycopg2.connect(**dArgs); # pylint: disable=W0142
     222            self._oExplainConn  = psycopg2.connect(**dArgs); # pylint: disable=star-args
    223223            self._oExplainConn.set_client_encoding('UTF-8');
    224224            self._oExplainCursor = self._oExplainConn.cursor();
    … …  
    701701            if config.g_ksDatabasePort is not None:
    702702                dArgs['port'] = config.g_ksDatabasePort;
    703             self._oExplainConn  = psycopg2.connect(**dArgs); # pylint: disable=W0142
     703            self._oExplainConn  = psycopg2.connect(**dArgs); # pylint: disable=star-args
    704704            self._oExplainCursor = self._oExplainConn.cursor();
    705705        return True;

  • trunk/src/VBox/ValidationKit/testmanager/core/failurecategory.py

    r76553 r79087  
    109109
    110110
    111 class FailureCategoryLogic(ModelLogicBase): # pylint: disable=R0903
     111class FailureCategoryLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    112112    """
    113113    Failure Category logic.
    … …  
    149149
    150150
    151     def fetchForChangeLog(self, idFailureCategory, iStart, cMaxRows, tsNow): # pylint: disable=R0914
     151    def fetchForChangeLog(self, idFailureCategory, iStart, cMaxRows, tsNow): # pylint: disable=too-many-locals
    152152        """
    153153        Fetches change log entries for a failure reason.

  • trunk/src/VBox/ValidationKit/testmanager/core/failurereason.py

    r76553 r79087  
    143143
    144144
    145 class FailureReasonLogic(ModelLogicBase): # pylint: disable=R0903
     145class FailureReasonLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    146146    """
    147147    Failure Reason logic.
    … …  
    276276
    277277
    278     def fetchForChangeLog(self, idFailureReason, iStart, cMaxRows, tsNow): # pylint: disable=R0914
     278    def fetchForChangeLog(self, idFailureReason, iStart, cMaxRows, tsNow): # pylint: disable=too-many-locals
    279279        """
    280280        Fetches change log entries for a failure reason.

  • trunk/src/VBox/ValidationKit/testmanager/core/globalresource.py

    r76553 r79087  
    308308#
    309309
    310 # pylint: disable=C0111
     310# pylint: disable=missing-docstring
    311311class GlobalResourceDataTestCase(ModelDataBaseTestCase):
    312312    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/report.py

    r76553 r79087  
    6060
    6161
    62 class ReportModelBase(ModelLogicBase): # pylint: disable=R0903
     62class ReportModelBase(ModelLogicBase): # pylint: disable=too-few-public-methods
    6363    """
    6464    Something all report logic(/miner) classes inherit from.
    … …  
    242242class ReportFailureReasonTransient(ReportTransientBase):
    243243    """ Details on the test where a failure reason was first/last seen.  """
    244     def __init__(self, idBuild, iRevision, sRepository, idTestSet, idTestResult, tsDone,  # pylint: disable=R0913
     244    def __init__(self, idBuild, iRevision, sRepository, idTestSet, idTestResult, tsDone,  # pylint: disable=too-many-arguments
    245245                 iPeriod, fEnter, oReason):
    246246        ReportTransientBase.__init__(self, idBuild, iRevision, sRepository, idTestSet, idTestResult, tsDone, iPeriod, fEnter,
    … …  
    530530
    531531
    532 class ReportLazyModel(ReportModelBase): # pylint: disable=R0903
     532class ReportLazyModel(ReportModelBase): # pylint: disable=too-few-public-methods
    533533    """
    534534    The 'lazy bird' report model class.
    … …  
    890890
    891891
    892 class ReportGraphModel(ReportModelBase): # pylint: disable=R0903
     892class ReportGraphModel(ReportModelBase): # pylint: disable=too-few-public-methods
    893893    """
    894894    Extended report model used when generating the more complicated graphs
    … …  
    977977
    978978
    979     def __init__(self, oDb, tsNow, cPeriods, cHoursPerPeriod, sSubject, aidSubjects, # pylint: disable=R0913
     979    def __init__(self, oDb, tsNow, cPeriods, cHoursPerPeriod, sSubject, aidSubjects, # pylint: disable=too-many-arguments
    980980                 aidTestBoxes, aidBuildCats, aidTestCases, fSepTestVars):
    981981        assert(sSubject == self.ksSubEverything); # dummy

  • trunk/src/VBox/ValidationKit/testmanager/core/schedgroup.py

    r76553 r79087  
    259259    def __init__(self):
    260260        SchedGroupData.__init__(self);
    261         self.aoMembers          = [];       # type: SchedGroupMemberDataEx
     261        self.aoMembers          = []        # type: SchedGroupMemberDataEx
    262262
    263263        # Two build sources for convenience sake.
    264         self.oBuildSrc          = None;     # type: TestBoxData
    265         self.oBuildSrcValidationKit = None; # type: TestBoxData
     264        self.oBuildSrc          = None      # type: TestBoxData
     265        self.oBuildSrcValidationKit = None  # type: TestBoxData
    266266        # List of test boxes that uses this group for convenience.
    267         self.aoTestBoxes        = None;     # type: list[TestBoxData]
     267        self.aoTestBoxes        = None      # type: list[TestBoxData]
    268268
    269269    def _initExtraMembersFromDb(self, oDb, tsNow = None, sPeriodBack = None):
    … …  
    421421
    422422
    423 class SchedGroupLogic(ModelLogicBase): # pylint: disable=R0903
     423class SchedGroupLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    424424    """
    425425    SchedGroup logic.
    … …  
    578578                raise TMRowInUse('Scheduling group #%d is associated with one or more test boxes: %s'
    579579                                 % (idSchedGroup, ', '.join(asTestBoxes),));
    580             else:
    581                 # Reassign testboxes to scheduling group #1 (the default group).
    582                 oTbLogic = TestBoxLogic(self._oDb);
    583                 for oTestBox in oData.aoTestBoxes:
    584                     oTbCopy = TestBoxData().initFromOther(oTestBox);
    585                     oTbCopy.idSchedGroup = 1;
    586                     oTbLogic.editEntry(oTbCopy, uidAuthor, fCommit = False);
    587 
    588                 oData = SchedGroupDataEx().initFromDbWithId(self._oDb, idSchedGroup);
    589                 if oData.aoTestBoxes:
    590                     raise TMRowInUse('More testboxes was added to the scheduling group as we were trying to delete it.');
     580            # Reassign testboxes to scheduling group #1 (the default group).
     581            oTbLogic = TestBoxLogic(self._oDb);
     582            for oTestBox in oData.aoTestBoxes:
     583                oTbCopy = TestBoxData().initFromOther(oTestBox);
     584                oTbCopy.idSchedGroup = 1;
     585                oTbLogic.editEntry(oTbCopy, uidAuthor, fCommit = False);
     586
     587            oData = SchedGroupDataEx().initFromDbWithId(self._oDb, idSchedGroup);
     588            if oData.aoTestBoxes:
     589                raise TMRowInUse('More testboxes was added to the scheduling group as we were trying to delete it.');
    591590
    592591        #
    … …  
    982981#
    983982
    984 # pylint: disable=C0111
     983# pylint: disable=missing-docstring
    985984class SchedGroupMemberDataTestCase(ModelDataBaseTestCase):
    986985    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/schedulerbase.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55
    … …  
    352352        self.cMissingGangMembers    = 1;
    353353
    354     def initFromValues(self, idSchedGroup, idGenTestCaseArgs, idTestGroup, aidTestGroupPreReqs, # pylint: disable=R0913
     354    def initFromValues(self, idSchedGroup, idGenTestCaseArgs, idTestGroup, aidTestGroupPreReqs, # pylint: disable=too-many-arguments
    355355                       bmHourlySchedule, cMissingGangMembers,
    356356                       idItem = None, offQueue = None, tsConfig = None, tsLastScheduled = None, idTestSetGangLeader = None):
    … …  
    15061506#
    15071507
    1508 # pylint: disable=C0111
     1508# pylint: disable=missing-docstring
    15091509class SchedQueueDataTestCase(ModelDataBaseTestCase):
    15101510    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/schedulerbeci.py

    r76553 r79087  
    3434
    3535
    36 class SchdulerBeci(SchedulerBase): # pylint: disable=R0903
     36class SchdulerBeci(SchedulerBase): # pylint: disable=too-few-public-methods
    3737    """
    3838    The best-effort-continuous-integration scheduler, BECI for short.

  • trunk/src/VBox/ValidationKit/testmanager/core/systemchangelog.py

    r76553 r79087  
    3636
    3737
    38 class SystemChangelogEntry(object): # pylint: disable=R0902
     38class SystemChangelogEntry(object): # pylint: disable=too-many-instance-attributes
    3939    """
    4040    System changelog entry.
    … …  
    7171
    7272    ## Mapping a changelog entry kind to a table, key and clue.
    73     kdWhatToTable = dict({  # pylint: disable=W0142
     73    kdWhatToTable = dict({  # pylint: disable=star-args
    7474        ksWhat_TestBox:          ( 'TestBoxes',          'idTestBox',           None, ),
    7575        ksWhat_TestCase:         ( 'TestCasees',         'idTestCase',          None, ),

  • trunk/src/VBox/ValidationKit/testmanager/core/systemlog.py

    r76553 r79087  
    3737
    3838
    39 class SystemLogData(ModelDataBase):  # pylint: disable=R0902
     39class SystemLogData(ModelDataBase):  # pylint: disable=too-many-instance-attributes
    4040    """
    4141    SystemLog Data.
    … …  
    166166#
    167167
    168 # pylint: disable=C0111
     168# pylint: disable=missing-docstring
    169169class SystemLogDataTestCase(ModelDataBaseTestCase):
    170170    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testbox.py

    r76886 r79087  
    9999    def __init__(self):
    100100        TestBoxInSchedGroupData.__init__(self);
    101         self.oSchedGroup        = None; # type: SchedGroupData
     101        self.oSchedGroup        = None  # type: SchedGroupData
    102102
    103103    def initFromDbRowEx(self, aoRow, oDb, tsNow = None, sPeriodBack = None):
    … …  
    111111
    112112
    113 # pylint: disable=C0103
    114 class TestBoxData(ModelDataBase):  # pylint: disable=R0902
     113# pylint: disable=invalid-name
     114class TestBoxData(ModelDataBase):  # pylint: disable=too-many-instance-attributes
    115115    """
    116116    TestBox Data.
    … …  
    476476            if uFam == 0xf:
    477477                if uMod < 0x10:                             return 'K8_130nm';
    478                 if uMod >= 0x60 and uMod < 0x80:            return 'K8_65nm';
     478                if 0x60 <= uMod < 0x80:                     return 'K8_65nm';
    479479                if uMod >= 0x40:                            return 'K8_90nm_AMDV';
    480480                if uMod in [0x21, 0x23, 0x2b, 0x37, 0x3f]:  return 'K8_90nm_DualCore';
    … …  
    567567    def __init__(self):
    568568        TestBoxData.__init__(self);
    569         self.aoInSchedGroups        = [];   # type: list[TestBoxInSchedGroupData]
     569        self.aoInSchedGroups        = []    # type: list[TestBoxInSchedGroupData]
    570570
    571571    def _initExtraMembersFromDb(self, oDb, tsNow = None, sPeriodBack = None):
    … …  
    634634        return aoNewValues;
    635635
    636     def _validateAndConvertAttribute(self, sAttr, sParam, oValue, aoNilValues, fAllowNull, oDb): # pylint: disable=R0914
     636    def _validateAndConvertAttribute(self, sAttr, sParam, oValue, aoNilValues, fAllowNull, oDb): # pylint: disable=too-many-locals
    637637        """
    638638        Validate special arrays and requirement expressions.
    … …  
    773773                TestBoxDataEx.__init__(self);
    774774                self.tsCurrent = None;  # CURRENT_TIMESTAMP
    775                 self.oStatus   = None;  # type: TestBoxStatusData
     775                self.oStatus   = None   # type: TestBoxStatusData
    776776
    777777        from testmanager.core.testboxstatus import TestBoxStatusData;
    … …  
    811811        return aoRows;
    812812
    813     def fetchForChangeLog(self, idTestBox, iStart, cMaxRows, tsNow): # pylint: disable=R0914
     813    def fetchForChangeLog(self, idTestBox, iStart, cMaxRows, tsNow): # pylint: disable=too-many-locals
    814814        """
    815815        Fetches change log entries for a testbox.
    … …  
    10131013
    10141014
    1015     def updateOnSignOn(self, idTestBox, idGenTestBox, sTestBoxAddr, sOs, sOsVersion, # pylint: disable=R0913,R0914
     1015    def updateOnSignOn(self, idTestBox, idGenTestBox, sTestBoxAddr, sOs, sOsVersion, # pylint: disable=too-many-arguments,too-many-locals
    10161016                       sCpuVendor, sCpuArch, sCpuName, lCpuRevision, cCpus, fCpuHwVirt, fCpuNestedPaging, fCpu64BitGuest,
    10171017                       fChipsetIoMmu, fRawMode, cMbMemory, cMbScratch, sReport, iTestBoxScriptRev, iPythonHexVersion):
    … …  
    11531153        except TMInFligthCollision:
    11541154            return False;
    1155         except:
    1156             raise;
    11571155        return True;
    11581156
    … …  
    11771175#
    11781176
    1179 # pylint: disable=C0111
     1177# pylint: disable=missing-docstring
    11801178class TestBoxDataTestCase(ModelDataBaseTestCase):
    11811179    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testboxcontroller.py

    r76553 r79087  
    3333import re;
    3434import os;
    35 import string;                          # pylint: disable=W0402
     35import string;                          # pylint: disable=deprecated-module
    3636import sys;
    3737import uuid;
    … …  
    5353# Python 3 hacks:
    5454if sys.version_info[0] >= 3:
    55     long = int;     # pylint: disable=W0622,C0103
     55    long = int;     # pylint: disable=redefined-builtin,invalid-name
    5656
    5757
    … …  
    6060    Exception class for TestBoxController.
    6161    """
    62     pass;
    63 
    64 
    65 class TestBoxController(object): # pylint: disable=R0903
     62    pass;                               # pylint: disable=unnecessary-pass
     63
     64
     65class TestBoxController(object): # pylint: disable=too-few-public-methods
    6666    """
    6767    TestBox Controller class.
    … …  
    190190        """
    191191        sValue = self._getStringParam(sName, [ 'True', 'true', '1', 'False', 'false', '0'], sDefValue = str(fDefValue));
    192         return sValue == 'True' or sValue == 'true' or sValue == '1';
     192        return sValue in ('True', 'true', '1',);
    193193
    194194    def _getIntParam(self, sName, iMin = None, iMax = None):
    … …  
    346346        return fSizeOk;
    347347
    348     def _actionSignOn(self):        # pylint: disable=R0914
     348    def _actionSignOn(self):        # pylint: disable=too-many-locals
    349349        """ Implement sign-on """
    350350
    … …  
    401401            cPctScratchDiff = 100;
    402402
    403         # pylint: disable=R0916
     403        # pylint: disable=too-many-boolean-expressions
    404404        if   self._sTestBoxAddr != oTestBox.ip \
    405405          or sOs                != oTestBox.sOs \
    … …  
    738738
    739739            abBuf = oSrcFile.read(cbToRead);
    740             oDstFile.write(abBuf); # pylint: disable=E1103
     740            oDstFile.write(abBuf); # pylint: disable=maybe-no-member
    741741            del abBuf;
    742742
    743         oDstFile.close(); # pylint: disable=E1103
     743        oDstFile.close(); # pylint: disable=maybe-no-member
    744744
    745745        # Done.

  • trunk/src/VBox/ValidationKit/testmanager/core/testboxstatus.py

    r76553 r79087  
    297297#
    298298
    299 # pylint: disable=C0111
     299# pylint: disable=missing-docstring
    300300class TestBoxStatusDataTestCase(ModelDataBaseTestCase):
    301301    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testcase.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""
    … …  
    857857        return aoNewValues;
    858858
    859     def _validateAndConvertAttribute(self, sAttr, sParam, oValue, aoNilValues, fAllowNull, oDb): # pylint: disable=R0914
     859    def _validateAndConvertAttribute(self, sAttr, sParam, oValue, aoNilValues, fAllowNull, oDb): # pylint: disable=too-many-locals
    860860        """
    861861        Validate special arrays and requirement expressions.
    … …  
    999999        return aoRows;
    10001000
    1001     def fetchForChangeLog(self, idTestCase, iStart, cMaxRows, tsNow): # pylint: disable=R0914
     1001    def fetchForChangeLog(self, idTestCase, iStart, cMaxRows, tsNow): # pylint: disable=too-many-locals
    10021002        """
    10031003        Fetches change log entries for a testbox.
    … …  
    11841184        return True;
    11851185
    1186     def editEntry(self, oData, uidAuthor, fCommit = False):  # pylint: disable=R0914
     1186    def editEntry(self, oData, uidAuthor, fCommit = False):  # pylint: disable=too-many-locals
    11871187        """
    11881188        Edit a testcase entry (extended).
    … …  
    14161416#
    14171417
    1418 # pylint: disable=C0111
     1418# pylint: disable=missing-docstring
    14191419class TestCaseGlobalRsrcDepDataTestCase(ModelDataBaseTestCase):
    14201420    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testcaseargs.py

    r76553 r79087  
    4242# Python 3 hacks:
    4343if sys.version_info[0] >= 3:
    44     long = int;     # pylint: disable=W0622,C0103
     44    long = int;     # pylint: disable=redefined-builtin,invalid-name
    4545
    4646
    … …  
    135135        return self.initFromDbRow(oDb.fetchOne());
    136136
    137     def initFromValues(self, sArgs, cSecTimeout = None, sTestBoxReqExpr = None, sBuildReqExpr = None,  # pylint: disable=R0913
     137    def initFromValues(self, sArgs, cSecTimeout = None, sTestBoxReqExpr = None, sBuildReqExpr = None,  # pylint: disable=too-many-arguments
    138138                       cGangMembers = 1, idTestCase = None, idTestCaseArgs = None, tsEffective = None, tsExpire = None,
    139139                       uidAuthor = None, idGenTestCaseArgs = None, sSubName = None):
    … …  
    396396#
    397397
    398 # pylint: disable=C0111
     398# pylint: disable=missing-docstring
    399399class TestCaseArgsDataTestCase(ModelDataBaseTestCase):
    400400    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testgroup.py

    r76553 r79087  
    747747#
    748748
    749 # pylint: disable=C0111
     749# pylint: disable=missing-docstring
    750750class TestGroupMemberDataTestCase(ModelDataBaseTestCase):
    751751    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testresultfailures.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55## @todo Rename this file to testresult.py!
    … …  
    146146
    147147
    148 class TestResultListingData(ModelDataBase): # pylint: disable=R0902
     148class TestResultListingData(ModelDataBase): # pylint: disable=too-many-instance-attributes
    149149    """
    150150    Test case result data representation for table listing
    … …  
    255255
    256256
    257 class TestResultFailureLogic(ModelLogicBase): # pylint: disable=R0903
     257class TestResultFailureLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    258258    """
    259259    Test result failure reason logic.
    … …  
    263263        ModelLogicBase.__init__(self, oDb)
    264264
    265     def fetchForChangeLog(self, idTestResult, iStart, cMaxRows, tsNow): # pylint: disable=R0914
     265    def fetchForChangeLog(self, idTestResult, iStart, cMaxRows, tsNow): # pylint: disable=too-many-locals
    266266        """
    267267        Fetches change log entries for a failure reason.
    … …  
    509509#
    510510
    511 # pylint: disable=C0111
     511# pylint: disable=missing-docstring
    512512class TestResultFailureDataTestCase(ModelDataBaseTestCase):
    513513    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testresults.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55## @todo Rename this file to testresult.py!
    … …  
    550550
    551551
    552 class TestResultListingData(ModelDataBase): # pylint: disable=R0902
     552class TestResultListingData(ModelDataBase): # pylint: disable=too-many-instance-attributes
    553553    """
    554554    Test case result data representation for table listing
    … …  
    990990
    991991
    992 class TestResultLogic(ModelLogicBase): # pylint: disable=R0903
     992class TestResultLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    993993    """
    994994    Results grouped by scheduling group.
    … …  
    11991199        return sRet
    12001200
    1201     def fetchResultsForListing(self, iStart, cMaxRows, tsNow, sInterval, oFilter, enmResultSortBy, # pylint: disable=R0913
     1201    def fetchResultsForListing(self, iStart, cMaxRows, tsNow, sInterval, oFilter, enmResultSortBy, # pylint: disable=too-many-arguments
    12021202                               enmResultsGroupingType, iResultsGroupingValue, fOnlyFailures, fOnlyNeedingReason):
    12031203        """
    … …  
    25582558            if sAttr in dAttribs:
    25592559                try:
    2560                     _ = long(dAttribs[sAttr]);  # pylint: disable=R0204
     2560                    _ = long(dAttribs[sAttr]);  # pylint: disable=redefined-variable-type
    25612561                except:
    25622562                    return 'Element %s has an invalid %s attribute value: %s.' % (sName, sAttr, dAttribs[sAttr],);
    … …  
    28542854#
    28552855
    2856 # pylint: disable=C0111
     2856# pylint: disable=missing-docstring
    28572857class TestResultDataTestCase(ModelDataBaseTestCase):
    28582858    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testset.py

    r78780 r79087  
    537537        return True;
    538538
    539     def createFile(self, oTestSet, sName, sMime, sKind, sDesc, cbFile, fCommit = False): # pylint: disable=R0914
     539    def createFile(self, oTestSet, sName, sMime, sKind, sDesc, cbFile, fCommit = False): # pylint: disable=too-many-locals
    540540        """
    541541        Creates a file and associating with the current test result record in
    … …  
    825825#
    826826
    827 # pylint: disable=C0111
     827# pylint: disable=missing-docstring
    828828class TestSetDataTestCase(ModelDataBaseTestCase):
    829829    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/useraccount.py

    r76553 r79087  
    282282#
    283283
    284 # pylint: disable=C0111
     284# pylint: disable=missing-docstring
    285285class UserAccountDataTestCase(ModelDataBaseTestCase):
    286286    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/vcsrevisions.py

    r76553 r79087  
    105105
    106106
    107 class VcsRevisionLogic(ModelLogicBase): # pylint: disable=R0903
     107class VcsRevisionLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    108108    """
    109109    VCS revisions database logic.
    … …  
    234234#
    235235
    236 # pylint: disable=C0111
     236# pylint: disable=missing-docstring
    237237class VcsRevisionDataTestCase(ModelDataBaseTestCase):
    238238    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/db/partial-db-dump.py

    r76553 r79087  
    22# -*- coding: utf-8 -*-
    33# $Id$
    4 # pylint: disable=C0301
     4# pylint: disable=line-too-long
    55
    66"""
    … …  
    4747
    4848
    49 class PartialDbDump(object): # pylint: disable=R0903
     49class PartialDbDump(object): # pylint: disable=too-few-public-methods
    5050    """
    5151    Dumps or loads the last X days of database data.

  • trunk/src/VBox/ValidationKit/testmanager/webui/wuiadmin.py

    r76553 r79087  
    812812                                           self.ksActionGlobalRsrcShowAll);
    813813
    814     def _actionGlobalRsrcShowAddEdit(self, sAction): # pylint: disable=C0103
     814    def _actionGlobalRsrcShowAddEdit(self, sAction): # pylint: disable=invalid-name
    815815        """Show Global Resource creation or edit dialog"""
    816816        from testmanager.core.globalresource           import GlobalResourceLogic, GlobalResourceData;

  • trunk/src/VBox/ValidationKit/testmanager/webui/wuiadmintestbox.py

    r76553 r79087  
    239239        return (sTitle, sBody);
    240240
    241     def _formatListEntry(self, iEntry): # pylint: disable=R0914
     241    def _formatListEntry(self, iEntry): # pylint: disable=too-many-locals
    242242        from testmanager.webui.wuiadmin import WuiAdmin;
    243243        oEntry  = self._aoEntries[iEntry];
    … …  
    274274            else:
    275275                from testmanager.webui.wuimain import WuiMain;
    276                 oState = WuiTmLink(oEntry.oStatus.enmState, WuiMain.ksScriptName,                       # pylint: disable=R0204
     276                oState = WuiTmLink(oEntry.oStatus.enmState, WuiMain.ksScriptName,                       # pylint: disable=redefined-variable-type
    277277                                   { WuiMain.ksParamAction: WuiMain.ksActionTestResultDetails,
    278278                                     TestSetData.ksParam_idTestSet: oEntry.oStatus.idTestSet, },

  • trunk/src/VBox/ValidationKit/testmanager/webui/wuibase.py

    r76553 r79087  
    523523        return asValues;
    524524
    525     def getListOfTestCasesParam(self, sName, asDefaults = None):  # too many local vars - pylint: disable=R0914
     525    def getListOfTestCasesParam(self, sName, asDefaults = None):  # too many local vars - pylint: disable=too-many-locals
    526526        """Get list of test cases and their parameters"""
    527527        if sName in self._dParams:
    … …  
    855855        return True
    856856
    857     def _actionGenericFormDetails(self, oDataType, oLogicType, oFormType, sIdAttr = None, sGenIdAttr = None): # pylint: disable=R0914
     857    def _actionGenericFormDetails(self, oDataType, oLogicType, oFormType, sIdAttr = None, sGenIdAttr = None): # pylint: disable=too-many-locals
    858858        """
    859859        Generic handler for showing a details form/page.

  • trunk/src/VBox/ValidationKit/testmanager/webui/wuicontentbase.py

    r76553 r79087  
    4747
    4848
    49 class WuiHtmlBase(object): # pylint: disable=R0903
     49class WuiHtmlBase(object): # pylint: disable=too-few-public-methods
    5050    """
    5151    Base class for HTML objects.
    … …  
    6969
    7070
    71 class WuiLinkBase(WuiHtmlBase): # pylint: disable=R0903
     71class WuiLinkBase(WuiHtmlBase): # pylint: disable=too-few-public-methods
    7272    """
    7373    For passing links from WuiListContentBase._formatListEntry.
    … …  
    118118
    119119
    120 class WuiTmLink(WuiLinkBase): # pylint: disable=R0903
     120class WuiTmLink(WuiLinkBase): # pylint: disable=too-few-public-methods
    121121    """ Local link to the test manager. """
    122122
    … …  
    139139
    140140
    141 class WuiAdminLink(WuiTmLink): # pylint: disable=R0903
     141class WuiAdminLink(WuiTmLink): # pylint: disable=too-few-public-methods
    142142    """ Local link to the test manager's admin portion. """
    143143
    … …  
    156156                           sFragmentId = sFragmentId, fBracketed = fBracketed);
    157157
    158 class WuiMainLink(WuiTmLink): # pylint: disable=R0903
     158class WuiMainLink(WuiTmLink): # pylint: disable=too-few-public-methods
    159159    """ Local link to the test manager's main portion. """
    160160
    … …  
    170170                           sFragmentId = sFragmentId, fBracketed = fBracketed);
    171171
    172 class WuiSvnLink(WuiLinkBase): # pylint: disable=R0903
     172class WuiSvnLink(WuiLinkBase): # pylint: disable=too-few-public-methods
    173173    """
    174174    For linking to a SVN revision.
    … …  
    180180                             fBracketed = fBracketed, sExtraAttrs = sExtraAttrs);
    181181
    182 class WuiSvnLinkWithTooltip(WuiSvnLink): # pylint: disable=R0903
     182class WuiSvnLinkWithTooltip(WuiSvnLink): # pylint: disable=too-few-public-methods
    183183    """
    184184    For linking to a SVN revision with changelog tooltip.
    … …  
    202202            WuiLinkBase.__init__(self, sName, sUrl, fBracketed = fBracketed);
    203203
    204 class WuiRawHtml(WuiHtmlBase): # pylint: disable=R0903
     204class WuiRawHtml(WuiHtmlBase): # pylint: disable=too-few-public-methods
    205205    """
    206206    For passing raw html from WuiListContentBase._formatListEntry.
    … …  
    213213        return self.sHtml;
    214214
    215 class WuiHtmlKeeper(WuiHtmlBase): # pylint: disable=R0903
     215class WuiHtmlKeeper(WuiHtmlBase): # pylint: disable=too-few-public-methods
    216216    """
    217217    For keeping a list of elements, concatenating their toHtml output together.
    … …  
    238238        return self.sSep.join(oObj.toHtml() for oObj in self.aoKept);
    239239
    240 class WuiSpanText(WuiRawHtml): # pylint: disable=R0903
     240class WuiSpanText(WuiRawHtml): # pylint: disable=too-few-public-methods
    241241    """
    242242    Outputs the given text within a span of the given CSS class.
    … …  
    252252                                % ( webutils.escapeAttr(sSpanClass), webutils.escapeAttr(sTitle), webutils.escapeElem(sText),));
    253253
    254 class WuiElementText(WuiRawHtml): # pylint: disable=R0903
     254class WuiElementText(WuiRawHtml): # pylint: disable=too-few-public-methods
    255255    """
    256256    Outputs the given element text.
    … …  
    260260
    261261
    262 class WuiContentBase(object): # pylint: disable=R0903
     262class WuiContentBase(object): # pylint: disable=too-few-public-methods
    263263    """
    264264    Base for the content classes.
    … …  
    382382        return sHtml;
    383383
    384 class WuiSingleContentBase(WuiContentBase): # pylint: disable=R0903
     384class WuiSingleContentBase(WuiContentBase): # pylint: disable=too-few-public-methods
    385385    """
    386386    Base for the content classes working on a single data object (oData).
    … …  
    391391
    392392
    393 class WuiFormContentBase(WuiSingleContentBase): # pylint: disable=R0903
     393class WuiFormContentBase(WuiSingleContentBase): # pylint: disable=too-few-public-methods
    394394    """
    395395    Base class for simple input form content classes (single data object).

  • trunk/src/VBox/ValidationKit/testmanager/webui/wuihlpform.py

    r76553 r79087  
    415415                             sExtraAttribs = sExtraAttribs);
    416416
    417     def addListOfTestCaseArgs(self, sName, aoVariations, sLabel): # pylint: disable=R0915
     417    def addListOfTestCaseArgs(self, sName, aoVariations, sLabel): # pylint: disable=too-many-statements
    418418        """
    419419        Adds a list of test case argument variations to the form.
    … …  
    646646        return self._add(sHtml)
    647647
    648     def addListOfTestGroupMembers(self, sName, aoTestGroupMembers, aoAllTestCases, sLabel,  # pylint: disable=R0914
     648    def addListOfTestGroupMembers(self, sName, aoTestGroupMembers, aoAllTestCases, sLabel,  # pylint: disable=too-many-locals
    649649                                  fReadOnly = True):
    650650        """
    … …  
    763763                         u'</table>\n');
    764764
    765     def addListOfSchedGroupMembers(self, sName, aoSchedGroupMembers, aoAllTestGroups,  # pylint: disable=R0914
     765    def addListOfSchedGroupMembers(self, sName, aoSchedGroupMembers, aoAllTestGroups,  # pylint: disable=too-many-locals
    766766                                   sLabel, fReadOnly = True):
    767767        """
    … …  
    862862                         u'</table>\n');
    863863
    864     def addListOfSchedGroupsForTestBox(self, sName, aoInSchedGroups, aoAllSchedGroups, sLabel,  # pylint: disable=R0914
     864    def addListOfSchedGroupsForTestBox(self, sName, aoInSchedGroups, aoAllSchedGroups, sLabel,  # pylint: disable=too-many-locals
    865865                                       fReadOnly = None):
    866866        # type: (str, TestBoxInSchedGroupDataEx, SchedGroupData, str, bool) -> str

  • trunk/src/VBox/ValidationKit/testmanager/webui/wuihlpgraph.py

    r76553 r79087  
    3030
    3131
    32 class WuiHlpGraphDataTable(object): # pylint: disable=R0903
     32class WuiHlpGraphDataTable(object): # pylint: disable=too-few-public-methods
    3333    """
    3434    Data table container.
    3535    """
    3636
    37     class Row(object): # pylint: disable=R0903
     37    class Row(object): # pylint: disable=too-few-public-methods
    3838        """A row."""
    3939        def __init__(self, sGroup, aoValues, asValues = None):
    … …  
    5959
    6060
    61 class WuiHlpGraphDataTableEx(object): # pylint: disable=R0903
     61class WuiHlpGraphDataTableEx(object): # pylint: disable=too-few-public-methods
    6262    """
    6363    Data container for an table/graph with optional error bars on the Y values.
    6464    """
    6565
    66     class DataSeries(object): # pylint: disable=R0903
     66    class DataSeries(object): # pylint: disable=too-few-public-methods
    6767        """
    6868        A data series.
    … …  
    100100# Dynamically choose implementation.
    101101#
    102 if True: # pylint: disable=W0125
     102if True: # pylint: disable=using-constant-test
    103103    from testmanager.webui import wuihlpgraphgooglechart        as GraphImplementation;
    104104else:
    105105    try:
    106         import matplotlib; # pylint: disable=W0611,F0401,import-error,wrong-import-order
     106        import matplotlib; # pylint: disable=unused-import,import-error,import-error,wrong-import-order
    107107        from testmanager.webui import wuihlpgraphmatplotlib     as GraphImplementation; # pylint: disable=ungrouped-imports
    108108    except:
    109109        from testmanager.webui import wuihlpgraphsimple         as GraphImplementation;
    110110
    111 # pylint: disable=C0103
     111# pylint: disable=invalid-name
    112112WuiHlpBarGraph              = GraphImplementation.WuiHlpBarGraph;
    113113WuiHlpLineGraph             = GraphImplementation.WuiHlpLineGraph;

  • trunk/src/VBox/ValidationKit/testmanager/webui/wuihlpgraphgooglechart.py

    r76553 r79087  
    6868        return True;
    6969
    70     def renderGraph(self): # pylint: disable=R0914
     70    def renderGraph(self): # pylint: disable=too-many-locals
    7171        fSlideFilter = True;
    7272

  • trunk/src/VBox/ValidationKit/testmanager/webui/wuihlpgraphmatplotlib.py

    r76553 r79087  
    3737    from StringIO import StringIO as StringIO;  # pylint: disable=import-error,no-name-in-module
    3838
    39 import matplotlib;                              # pylint: disable=F0401
     39import matplotlib;                              # pylint: disable=import-error
    4040matplotlib.use('Agg'); # Force backend.
    41 import matplotlib.pyplot;                       # pylint: disable=F0401
    42 from numpy import arange as numpy_arange;       # pylint: disable=E0611,E0401,wrong-import-order
     41import matplotlib.pyplot;                       # pylint: disable=import-error
     42from numpy import arange as numpy_arange;       # pylint: disable=no-name-in-module,import-error,wrong-import-order
    4343
    4444# Validation Kit imports.
    … …  
    6464        """
    6565        if self._fXkcdStyle and matplotlib.__version__ > '1.2.9':
    66             matplotlib.pyplot.xkcd();           # pylint: disable=E1101
     66            matplotlib.pyplot.xkcd();           # pylint: disable=no-member
    6767        matplotlib.rcParams.update({'font.size': self._cPtFont});
    6868
    … …  
    106106        return None;
    107107
    108     def renderGraph(self): # pylint: disable=R0914
     108    def renderGraph(self): # pylint: disable=too-many-locals
    109109        aoTable  = self._oData.aoTable;
    110110
    … …  
    198198        return True;
    199199
    200     def renderGraph(self): # pylint: disable=R0914
     200    def renderGraph(self): # pylint: disable=too-many-locals
    201201        aoSeries = self._oData.aoSeries;
    202202
    … …  
    246246            oSubPlot.grid(True, 'both', axis = 'x');
    247247
    248         if True: # pylint: disable=W0125
     248        if True: # pylint: disable=using-constant-test
    249249            #    oSubPlot.axis('off');
    250250            #oSubPlot.grid(True, 'major', axis = 'none');
    … …  
    278278        self.setFontSize(6);
    279279
    280     def renderGraph(self): # pylint: disable=R0914
     280    def renderGraph(self): # pylint: disable=too-many-locals
    281281        assert len(self._oData.aoSeries) == 1;
    282282        oSeries = self._oData.aoSeries[0];
    … …  
    288288
    289289        oFigure = self._createFigure();
    290         from mpl_toolkits.axes_grid.axislines import SubplotZero; # pylint: disable=E0401
     290        from mpl_toolkits.axes_grid.axislines import SubplotZero; # pylint: disable=import-error
    291291        oAxis = SubplotZero(oFigure, 111);
    292292        oFigure.add_subplot(oAxis);

  • trunk/src/VBox/ValidationKit/testmanager/webui/wuimain.py

    r76553 r79087  
    717717    #
    718718
    719     def _actionGroupedResultsListing( #pylint: disable=R0914
     719    def _actionGroupedResultsListing( #pylint: disable=too-many-locals
    720720            self,
    721721            enmResultsGroupingType,

  • trunk/src/VBox/ValidationKit/testmanager/webui/wuireport.py

    r76553 r79087  
    416416                    oTable.addRow(oPeriod.sDesc, aiValues, asValues);
    417417
    418                 if True: # pylint: disable=W0125
     418                if True: # pylint: disable=using-constant-test
    419419                    aiValues = [];
    420420                    asValues = [];

  • trunk/src/VBox/ValidationKit/testmanager/webui/wuitestresult.py

    r76553 r79087  
    154154
    155155    def _recursivelyGenerateEvents(self, oTestResult, sParentName, sLineage, iRow,
    156                                    iFailure, oTestSet, iDepth):     # pylint: disable=R0914
     156                                   iFailure, oTestSet, iDepth):     # pylint: disable=too-many-locals
    157157        """
    158158        Recursively generate event table rows for the result set.
    … …  
    442442
    443443
    444     def showTestCaseResultDetails(self,             # pylint: disable=R0914,R0915
     444    def showTestCaseResultDetails(self,             # pylint: disable=too-many-locals,too-many-statements
    445445                                  oTestResultTree,
    446446                                  oTestSet,

  • trunk/src/VBox/ValidationKit/tests/additions/tdAddBasic1.py

    r79067 r79087  
    5353
    5454
    55 class tdAddBasic1(vbox.TestDriver):                                         # pylint: disable=R0902
     55class tdAddBasic1(vbox.TestDriver):                                         # pylint: disable=too-many-instance-attributes
    5656    """
    5757    Additions Basics #1.
    … …  
    8484        return rc;
    8585
    86     def parseOption(self, asArgs, iArg):                                        # pylint: disable=R0912,R0915
     86    def parseOption(self, asArgs, iArg):                                  # pylint: disable=too-many-branches,too-many-statements
    8787        if asArgs[iArg] == '--tests':
    8888            iArg += 1;

  • trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py

    r79071 r79087  
    11#!/usr/bin/env python
    22# -*- coding: utf-8 -*-
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""
    … …  
    3131
    3232# Disable bitching about too many arguments per function.
    33 # pylint: disable=R0913
    34 
    35 # Disable bitching about semicolons at the end of lines.
    36 # pylint: disable=W0301
     33# pylint: disable=too-many-arguments
    3734
    3835## @todo Convert map() usage to a cleaner alternative Python now offers.
    39 # pylint: disable=W0141
     36# pylint: disable=bad-builtin
    4037
    4138## @todo Convert the context/test classes into named tuples. Not in the mood right now, so
    4239#        disabling it.
    43 # pylint: disable=R0903
     40# pylint: disable=too-few-public-methods
    4441
    4542# Standard Python imports.
    … …  
    4845import os
    4946import random
    50 import string # pylint: disable=W0402
     47import string # pylint: disable=deprecated-module
    5148import struct
    5249import sys
    … …  
    7067# Python 3 hacks:
    7168if sys.version_info[0] >= 3:
    72     long = int      # pylint: disable=W0622,C0103
     69    long = int      # pylint: disable=redefined-builtin,invalid-name
    7370
    7471
    … …  
    8986    as generic as possible.
    9087    """
    91     def __init__(self, oSession, oTxsSession, oTestVm): # pylint: disable=W0613
     88    def __init__(self, oSession, oTxsSession, oTestVm): # pylint: disable=unused-argument
    9289        ## The desired Main API result.
    9390        self.fRc = False;
    … …  
    188185                # therefore return WaitFlagNotSupported.
    189186                #
    190                 if      waitResult != vboxcon.GuestSessionWaitResult_Start \
    191                     and waitResult != vboxcon.GuestSessionWaitResult_WaitFlagNotSupported:
     187                if waitResult not in (vboxcon.GuestSessionWaitResult_Start, vboxcon.GuestSessionWaitResult_WaitFlagNotSupported):
    192188                    # Just log, don't assume an error here (will be done in the main loop then).
    193189                    reporter.log('Session did not start successfully, returned wait result: %d' \
    … …  
    955951        self.asRsrcs    = ['5.3/guestctrl/50mb_rnd.dat', ];
    956952
    957     def parseOption(self, asArgs, iArg):                                        # pylint: disable=R0912,R0915
     953    def parseOption(self, asArgs, iArg):                                        # pylint: disable=too-many-branches,too-many-statements
    958954        if asArgs[iArg] == '--add-guest-ctrl-tests':
    959955            iArg += 1;
    … …  
    11971193        return fRc;
    11981194
    1199     def gctrlReadDir(self, oTest, oRes, oGuestSession, subDir = ''): # pylint: disable=R0914
     1195    def gctrlReadDir(self, oTest, oRes, oGuestSession, subDir = ''): # pylint: disable=too-many-locals
    12001196        """
    12011197        Helper function to read a guest directory specified in
    … …  
    12811277                                          map(hex, map(ord, oRes.sBuf)), len(oRes.sBuf)));
    12821278                        return False;
    1283                     else:
    1284                         reporter.log2('Test #%d passed: Buffers match (%d bytes)' % (i, len(oRes.sBuf)));
     1279                    reporter.log2('Test #%d passed: Buffers match (%d bytes)' % (i, len(oRes.sBuf)));
    12851280                elif     oRes.sBuf is not None \
    12861281                     and oRes.sBuf:
    … …  
    13381333                        try:
    13391334                            # Try stdout.
    1340                             if     waitResult == vboxcon.ProcessWaitResult_StdOut \
    1341                                 or waitResult == vboxcon.ProcessWaitResult_WaitFlagNotSupported:
     1335                            if waitResult in (vboxcon.ProcessWaitResult_StdOut, vboxcon.ProcessWaitResult_WaitFlagNotSupported):
    13421336                                reporter.log2('Reading stdout ...');
    13431337                                abBuf = curProc.Read(1, 64 * 1024, oTest.timeoutMS);
    … …  
    13471341                                    oTest.sBuf = abBuf; # Appending does *not* work atm, so just assign it. No time now.
    13481342                            # Try stderr.
    1349                             if     waitResult == vboxcon.ProcessWaitResult_StdErr \
    1350                                 or waitResult == vboxcon.ProcessWaitResult_WaitFlagNotSupported:
     1343                            if waitResult in (vboxcon.ProcessWaitResult_StdErr, vboxcon.ProcessWaitResult_WaitFlagNotSupported):
    13511344                                reporter.log2('Reading stderr ...');
    13521345                                abBuf = curProc.Read(2, 64 * 1024, oTest.timeoutMS);
    … …  
    13561349                                    oTest.sBuf = abBuf; # Appending does *not* work atm, so just assign it. No time now.
    13571350                            # Use stdin.
    1358                             if     waitResult == vboxcon.ProcessWaitResult_StdIn \
    1359                                 or waitResult == vboxcon.ProcessWaitResult_WaitFlagNotSupported:
     1351                            if waitResult in (vboxcon.ProcessWaitResult_StdIn, vboxcon.ProcessWaitResult_WaitFlagNotSupported):
    13601352                                pass; #reporter.log2('Process (PID %d) needs stdin data' % (curProc.pid,));
    13611353                            # Termination or error?
    1362                             if     waitResult == vboxcon.ProcessWaitResult_Terminate \
    1363                                 or waitResult == vboxcon.ProcessWaitResult_Error \
    1364                                 or waitResult == vboxcon.ProcessWaitResult_Timeout:
     1354                            if waitResult in (vboxcon.ProcessWaitResult_Terminate,
     1355                                              vboxcon.ProcessWaitResult_Error,
     1356                                              vboxcon.ProcessWaitResult_Timeout,):
    13651357                                reporter.log2('Process (PID %d) reported terminate/error/timeout: %d, status: %d' \
    13661358                                              % (curProc.PID, waitResult, curProc.status));
    … …  
    13851377        return fRc;
    13861378
    1387     def testGuestCtrlSessionEnvironment(self, oSession, oTxsSession, oTestVm): # pylint: disable=R0914
     1379    def testGuestCtrlSessionEnvironment(self, oSession, oTxsSession, oTestVm): # pylint: disable=too-many-locals
    13881380        """
    13891381        Tests the guest session environment changes.
    … …  
    14871479        return tdTestSessionEx.executeListTestSessions(aoTests, self.oTstDrv, oSession, oTxsSession, oTestVm, 'SessionEnv');
    14881480
    1489     def testGuestCtrlSession(self, oSession, oTxsSession, oTestVm): # pylint: disable=R0914
     1481    def testGuestCtrlSession(self, oSession, oTxsSession, oTestVm): # pylint: disable=too-many-locals
    14901482        """
    14911483        Tests the guest session handling.
    … …  
    15911583                break;
    15921584        curSessionCount = multiSession[i].getSessionCount(self.oTstDrv.oVBoxMgr);
    1593         if curSessionCount is not 1:
     1585        if curSessionCount != 1:
    15941586            reporter.error('Final MultiSession count #2 must be 1, got %d' % (curSessionCount,));
    15951587            fRc = False;
    … …  
    16121604            multiSession[iLastSession].closeSession();
    16131605            curSessionCount = multiSession[i].getSessionCount(self.oTstDrv.oVBoxMgr);
    1614             if curSessionCount is not 0:
     1606            if curSessionCount != 0:
    16151607                reporter.error('Final MultiSession count #3 must be 0, got %d' % (curSessionCount,));
    16161608                fRc = False;
    … …  
    16231615        return (fRc, oTxsSession);
    16241616
    1625     def testGuestCtrlSessionFileRefs(self, oSession, oTxsSession, oTestVm): # pylint: disable=R0914
     1617    def testGuestCtrlSessionFileRefs(self, oSession, oTxsSession, oTestVm): # pylint: disable=too-many-locals
    16261618        """
    16271619        Tests the guest session file reference handling.
    … …  
    16501642            # therefore return WaitFlagNotSupported.
    16511643            #
    1652             if      waitResult != vboxcon.GuestSessionWaitResult_Start \
    1653                 and waitResult != vboxcon.GuestSessionWaitResult_WaitFlagNotSupported:
     1644            if waitResult not in (vboxcon.GuestSessionWaitResult_Start, vboxcon.GuestSessionWaitResult_WaitFlagNotSupported):
    16541645                # Just log, don't assume an error here (will be done in the main loop then).
    16551646                reporter.log('Session did not start successfully, returned wait result: %d' \
    … …  
    17601751    #    return (fRc, oTxsSession);
    17611752
    1762     def testGuestCtrlSessionProcRefs(self, oSession, oTxsSession, oTestVm): # pylint: disable=R0914
     1753    def testGuestCtrlSessionProcRefs(self, oSession, oTxsSession, oTestVm): # pylint: disable=too-many-locals
    17631754        """
    17641755        Tests the guest session process reference handling.
    … …  
    17881779            # therefore return WaitFlagNotSupported.
    17891780            #
    1790             if      waitResult != vboxcon.GuestSessionWaitResult_Start \
    1791                 and waitResult != vboxcon.GuestSessionWaitResult_WaitFlagNotSupported:
     1781            if waitResult not in (vboxcon.GuestSessionWaitResult_Start, vboxcon.GuestSessionWaitResult_WaitFlagNotSupported):
    17921782                # Just log, don't assume an error here (will be done in the main loop then).
    17931783                reporter.log('Session did not start successfully, returned wait result: %d' \
    … …  
    19171907        return (fRc, oTxsSession);
    19181908
    1919     def testGuestCtrlExec(self, oSession, oTxsSession, oTestVm):                # pylint: disable=R0914,R0915
     1909    def testGuestCtrlExec(self, oSession, oTxsSession, oTestVm):                # pylint: disable=too-many-locals,too-many-statements
    19201910        """
    19211911        Tests the basic execution feature.
    … …  
    20842074            aSessions = self.oTstDrv.oVBoxMgr.getArray(oSession.o.console.guest, 'sessions');
    20852075            cSessions   = len(aSessions);
    2086             if cSessions is not 0:
     2076            if cSessions != 0:
    20872077                reporter.error('Found %d stale session(s), expected 0:' % (cSessions,));
    20882078                for (i, aSession) in enumerate(aSessions):
    … …  
    21062096                fWaitFor = [ vboxcon.GuestSessionWaitForFlag_Start ];
    21072097                waitResult = curGuestSession.waitForArray(fWaitFor, 30 * 1000);
    2108                 if      waitResult != vboxcon.GuestSessionWaitResult_Start \
    2109                     and waitResult != vboxcon.GuestSessionWaitResult_WaitFlagNotSupported:
     2098                if waitResult not in (vboxcon.GuestSessionWaitResult_Start, vboxcon.GuestSessionWaitResult_WaitFlagNotSupported):
    21102099                    reporter.error('Session did not start successfully, returned wait result: %d' \
    21112100                                   % (waitResult));
    … …  
    21422131        if fRc is True:
    21432132            cSessions = len(self.oTstDrv.oVBoxMgr.getArray(oSession.o.console.guest, 'sessions'));
    2144             if cSessions is not 0:
     2133            if cSessions != 0:
    21452134                reporter.error('Found %d stale session(s), expected 0' % (cSessions,));
    21462135                fRc = False;
    … …  
    21642153                            % (waitResult, oGuestProcess.status));
    21652154
    2166     def testGuestCtrlSessionReboot(self, oSession, oTxsSession, oTestVm): # pylint: disable=R0914
     2155    def testGuestCtrlSessionReboot(self, oSession, oTxsSession, oTestVm): # pylint: disable=too-many-locals
    21672156        """
    21682157        Tests guest object notifications when a guest gets rebooted / shutdown.
    … …  
    21912180                fWaitFor = [ vboxcon.GuestSessionWaitForFlag_Start ];
    21922181                waitResult = oGuestSession.waitForArray(fWaitFor, 30 * 1000);
    2193                 if      waitResult != vboxcon.GuestSessionWaitResult_Start \
    2194                     and waitResult != vboxcon.GuestSessionWaitResult_WaitFlagNotSupported:
     2182                if waitResult not in (vboxcon.GuestSessionWaitResult_Start, vboxcon.GuestSessionWaitResult_WaitFlagNotSupported):
    21952183                    reporter.error('Session did not start successfully, returned wait result: %d' \
    21962184                                   % (waitResult));
    … …  
    24952483        return (fRc, oTxsSession);
    24962484
    2497     def testGuestCtrlDirCreateTemp(self, oSession, oTxsSession, oTestVm): # pylint: disable=R0914
     2485    def testGuestCtrlDirCreateTemp(self, oSession, oTxsSession, oTestVm): # pylint: disable=too-many-locals
    24982486        """
    24992487        Tests creation of temporary directories.
    … …  
    26432631        return (fRc, oTxsSession);
    26442632
    2645     def testGuestCtrlDirRead(self, oSession, oTxsSession, oTestVm): # pylint: disable=R0914
     2633    def testGuestCtrlDirRead(self, oSession, oTxsSession, oTestVm): # pylint: disable=too-many-locals
    26462634        """
    26472635        Tests opening and reading (enumerating) guest directories.
    … …  
    27952783        return (fRc, oTxsSession);
    27962784
    2797     def testGuestCtrlFileStat(self, oSession, oTxsSession, oTestVm): # pylint: disable=R0914
     2785    def testGuestCtrlFileStat(self, oSession, oTxsSession, oTestVm): # pylint: disable=too-many-locals
    27982786        """
    27992787        Tests querying file information through stat.
    … …  
    28802868        return tdTestSessionEx.executeListTestSessions(aoTests, self.oTstDrv, oSession, oTxsSession, oTestVm, 'FsStat');
    28812869
    2882     def testGuestCtrlFileRead(self, oSession, oTxsSession, oTestVm): # pylint: disable=R0914
     2870    def testGuestCtrlFileRead(self, oSession, oTxsSession, oTestVm): # pylint: disable=too-many-locals
    28832871        """
    28842872        Tests reading from guest files.
    … …  
    30333021        return (fRc, oTxsSession);
    30343022
    3035     def testGuestCtrlFileWrite(self, oSession, oTxsSession, oTestVm): # pylint: disable=R0914
     3023    def testGuestCtrlFileWrite(self, oSession, oTxsSession, oTestVm): # pylint: disable=too-many-locals
    30363024        """
    30373025        Tests writing to guest files.
    … …  
    33253313        return (fRc, oTxsSession);
    33263314
    3327     def testGuestCtrlCopyFrom(self, oSession, oTxsSession, oTestVm): # pylint: disable=R0914
     3315    def testGuestCtrlCopyFrom(self, oSession, oTxsSession, oTestVm): # pylint: disable=too-many-locals
    33283316        """
    33293317        Tests copying files from guest to the host.
    … …  
    34903478        return (fRc, oTxsSession);
    34913479
    3492     def testGuestCtrlUpdateAdditions(self, oSession, oTxsSession, oTestVm): # pylint: disable=R0914
     3480    def testGuestCtrlUpdateAdditions(self, oSession, oTxsSession, oTestVm): # pylint: disable=too-many-locals
    34933481        """
    34943482        Tests updating the Guest Additions inside the guest.
    … …  
    36013589
    36023590
    3603 class tdAddGuestCtrl(vbox.TestDriver):                                         # pylint: disable=R0902,R0904
     3591class tdAddGuestCtrl(vbox.TestDriver):                                         # pylint: disable=too-many-instance-attributes,too-many-public-methods
    36043592    """
    36053593    Guest control using VBoxService on the guest.
    … …  
    36273615        return rc;
    36283616
    3629     def parseOption(self, asArgs, iArg):                                        # pylint: disable=R0912,R0915
     3617    def parseOption(self, asArgs, iArg):                                        # pylint: disable=too-many-branches,too-many-statements
    36303618        """
    36313619        Parses the testdriver arguments from the command line.
    … …  
    36533641    # Test execution helpers.
    36543642    #
    3655     def testOneCfg(self, oVM, oTestVm): # pylint: disable=R0915
     3643    def testOneCfg(self, oVM, oTestVm): # pylint: disable=too-many-statements
    36563644        """
    36573645        Runs the specified VM thru the tests.
    … …  
    37013689        based from a timeout value and the start time (both in ms).
    37023690        """
    3703         if msTimeout is 0:
     3691        if msTimeout == 0:
    37043692            return 0xFFFFFFFE; # Wait forever.
    37053693        msElapsed = base.timestampMilli() - msStart;
    … …  
    37083696        return msTimeout - msElapsed;
    37093697
    3710     def testGuestCtrlManual(self, oSession, oTxsSession, oTestVm):                # pylint: disable=R0914,R0915,W0613,W0612
     3698    def testGuestCtrlManual(self, oSession, oTxsSession, oTestVm):                # pylint: disable=too-many-locals,too-many-statements,unused-argument,unused-variable
    37113699        """
    37123700        For manually testing certain bits.

  • trunk/src/VBox/ValidationKit/tests/audio/tdGuestHostTimings.py

    r76553 r79087  
    5050from testdriver import vboxtestvms
    5151
    52 class tdGuestHostTimings(vbox.TestDriver):                                         # pylint: disable=R0902
     52class tdGuestHostTimings(vbox.TestDriver):                                         # pylint: disable=too-many-instance-attributes
    5353
    5454    def __init__(self):
    … …  
    7575        return rc;
    7676
    77     def parseOption(self, asArgs, iArg):                                        # pylint: disable=R0912,R0915
     77    def parseOption(self, asArgs, iArg):                                        # pylint: disable=too-many-branches,too-many-statements
    7878        if asArgs[iArg] == '--runningvmname':
    7979            iArg += 1

  • trunk/src/VBox/ValidationKit/tests/autostart/tdAutostart1.py

    r76553 r79087  
    185185        return fRc;
    186186
    187     # pylint: disable=R0913
     187    # pylint: disable=too-many-arguments
    188188
    189189    def runProgAsUser(self, oTxsSession, sTestName, cMsTimeout, sExecName, sAsUser, asArgs = (),
    … …  
    199199        return fRc;
    200200
    201     # pylint: enable=R0913
     201    # pylint: enable=too-many-arguments
    202202
    203203    def createTestVM(self, oSession, oTxsSession, sUser, sVmName):
    … …  
    355355        return fRc;
    356356
    357     # pylint: disable=R0913
     357    # pylint: disable=too-many-arguments
    358358
    359359    def runProgAsUser(self, oTxsSession, sTestName, cMsTimeout, sExecName, sAsUser, asArgs = (),
    … …  
    369369        return fRc;
    370370
    371     # pylint: enable=R0913
     371    # pylint: enable=too-many-arguments
    372372
    373373    def createTestVM(self, oSession, oTxsSession, sUser, sVmName):
    … …  
    446446        return False;
    447447
    448 class tdAutostart(vbox.TestDriver):                                      # pylint: disable=R0902
     448class tdAutostart(vbox.TestDriver):                                      # pylint: disable=too-many-instance-attributes
    449449    """
    450450    Autostart testcase.
    … …  
    482482        return rc;
    483483
    484     def parseOption(self, asArgs, iArg):                                        # pylint: disable=R0912,R0915
     484    def parseOption(self, asArgs, iArg):                                        # pylint: disable=too-many-branches,too-many-statements
    485485        if asArgs[iArg] == '--test-build-dir':
    486486            iArg += 1;
    … …  
    569569        reporter.testStart('Autostart ' + sVmName);
    570570
    571         oGuestOsHlp = None;             # type: tdAutostartOs
     571        oGuestOsHlp = None              # type: tdAutostartOs
    572572        if sVmName == self.ksOsLinux:
    573573            oGuestOsHlp = tdAutostartOsLinux(self, self.sTestBuildDir);

  • trunk/src/VBox/ValidationKit/tests/installation/tdGuestOsInstTest1.py

    r78824 r79087  
    223223        oSet = vboxtestvms.TestVmSet(self.oTestVmManager, fIgnoreSkippedVm = True);
    224224        oSet.aoTestVms.extend([
    225             # pylint: disable=C0301
     225            # pylint: disable=line-too-long
    226226            InstallTestVm(oSet, 'tst-fedora4',      'Fedora',           'fedora4-txs.iso',          InstallTestVm.ksIdeController,   8, InstallTestVm.kf32Bit),
    227227            InstallTestVm(oSet, 'tst-fedora5',      'Fedora',           'fedora5-txs.iso',          InstallTestVm.ksSataController,  8, InstallTestVm.kf32Bit | InstallTestVm.kfReqPae | InstallTestVm.kfReqIoApicSmp),
    … …  
    261261            InstallTestVm(oSet, 'tst-w10-32',       'Windows10',        'win10-x86-txs.iso',        InstallTestVm.ksSataController, 25, InstallTestVm.kf32Bit | InstallTestVm.kfReqPae),
    262262            InstallTestVm(oSet, 'tst-w10-64',       'Windows10_64',     'win10-x64-txs.iso',        InstallTestVm.ksSataController, 25, InstallTestVm.kf64Bit),
    263             # pylint: enable=C0301
     263            # pylint: enable=line-too-long
    264264        ]);
    265265        self.oTestVmSet = oSet;

  • trunk/src/VBox/ValidationKit/tests/network/tdNetBenchmark1.py

    r76553 r79087  
    4949
    5050
    51 class tdNetBenchmark1(vbox.TestDriver):                                         # pylint: disable=R0902
     51class tdNetBenchmark1(vbox.TestDriver):                                         # pylint: disable=too-many-instance-attributes
    5252    """
    5353    Networking benchmark #1.
    … …  
    130130        return rc;
    131131
    132     def parseOption(self, asArgs, iArg):                                        # pylint: disable=R0912,R0915
     132    def parseOption(self, asArgs, iArg):                                        # pylint: disable=too-many-branches,too-many-statements
    133133        if asArgs[iArg] == '--remote-host':
    134134            iArg += 1;

  • trunk/src/VBox/ValidationKit/tests/storage/remoteexecutor.py

    r76553 r79087  
    162162                oStdIn = StdInOutBuffer(sInput);
    163163            else:
    164                 oStdIn = '/dev/null'; # pylint: disable=R0204
     164                oStdIn = '/dev/null'; # pylint: disable=redefined-variable-type
    165165            fRc = self.oTxsSession.syncExecEx(sExec, (sExec,) + asArgs,
    166166                                              oStdIn = oStdIn, oStdOut = oStdOut,

  • trunk/src/VBox/ValidationKit/tests/storage/storagecfg.py

    r76553 r79087  
    428428            oStorOs = StorageConfigOsSolaris();
    429429        elif sTargetOs == 'linux':
    430             oStorOs = StorageConfigOsLinux(); # pylint: disable=R0204
     430            oStorOs = StorageConfigOsLinux(); # pylint: disable=redefined-variable-type
    431431        else:
    432432            fRc = False;
    … …  
    450450
    451451        # Destroy all volumes first.
    452         for sMountPoint in self.dVols.keys(): # pylint: disable=C0201
     452        for sMountPoint in self.dVols.keys(): # pylint: disable=consider-iterating-dictionary
    453453            self.destroyVolume(sMountPoint);
    454454
    455455        # Destroy all pools.
    456         for sPool in self.dPools.keys(): # pylint: disable=C0201
     456        for sPool in self.dPools.keys(): # pylint: disable=consider-iterating-dictionary
    457457            self.destroyStoragePool(sPool);
    458458

  • trunk/src/VBox/ValidationKit/tests/storage/tdStorageBenchmark1.py

    r76553 r79087  
    3636import sys;
    3737if sys.version_info[0] >= 3:
    38     from io       import StringIO as StringIO;      # pylint: disable=import-error,no-name-in-module
     38    from io       import StringIO as StringIO;      # pylint: disable=import-error,no-name-in-module,useless-import-alias
    3939else:
    40     from StringIO import StringIO as StringIO;      # pylint: disable=import-error,no-name-in-module
     40    from StringIO import StringIO as StringIO;      # pylint: disable=import-error,no-name-in-module,useless-import-alias
    4141
    4242# Only the main script needs to modify the path.
    … …  
    6161def _ControllerTypeToName(eControllerType):
    6262    """ Translate a controller type to a name. """
    63     if eControllerType == vboxcon.StorageControllerType_PIIX3 or eControllerType == vboxcon.StorageControllerType_PIIX4:
     63    if eControllerType in (vboxcon.StorageControllerType_PIIX3, eControllerType == vboxcon.StorageControllerType_PIIX4,):
    6464        sType = "IDE Controller";
    6565    elif eControllerType == vboxcon.StorageControllerType_IntelAhci:
    … …  
    6767    elif eControllerType == vboxcon.StorageControllerType_LsiLogicSas:
    6868        sType = "SAS Controller";
    69     elif eControllerType == vboxcon.StorageControllerType_LsiLogic or eControllerType == vboxcon.StorageControllerType_BusLogic:
     69    elif eControllerType in (vboxcon.StorageControllerType_LsiLogic, vboxcon.StorageControllerType_BusLogic,):
    7070        sType = "SCSI Controller";
    7171    elif eControllerType == vboxcon.StorageControllerType_NVMe:
    … …  
    404404        return asTestCfg;
    405405
    406 class tdStorageBenchmark(vbox.TestDriver):                                      # pylint: disable=R0902
     406class tdStorageBenchmark(vbox.TestDriver):                                      # pylint: disable=too-many-instance-attributes
    407407    """
    408408    Storage benchmark.
    … …  
    579579        return rc;
    580580
    581     def parseOption(self, asArgs, iArg):                                        # pylint: disable=R0912,R0915
     581    def parseOption(self, asArgs, iArg):                                        # pylint: disable=too-many-branches,too-many-statements
    582582        if asArgs[iArg] == '--virt-modes':
    583583            iArg += 1;
    … …  
    944944            oTst = IozoneTest(oExecutor, dTestSet);
    945945        elif sBenchmark == 'fio':
    946             oTst = FioTest(oExecutor, dTestSet); # pylint: disable=R0204
     946            oTst = FioTest(oExecutor, dTestSet); # pylint: disable=redefined-variable-type
    947947
    948948        if oTst is not None:
    … …  
    10451045        return (None, None);
    10461046
    1047     def testOneCfg(self, sVmName, eStorageController, sHostIoCache, sDiskFormat, # pylint: disable=R0913,R0914,R0915
     1047    def testOneCfg(self, sVmName, eStorageController, sHostIoCache, sDiskFormat, # pylint: disable=too-many-arguments,too-many-locals,too-many-statements
    10481048                   sDiskVariant, sDiskPath, cCpus, sIoTest, sVirtMode, sTestSet):
    10491049        """
    … …  
    11091109
    11101110                iDevice = 0;
    1111                 if eStorageController == vboxcon.StorageControllerType_PIIX3 or \
    1112                    eStorageController == vboxcon.StorageControllerType_PIIX4:
     1111                if eStorageController in (vboxcon.StorageControllerType_PIIX3, vboxcon.StorageControllerType_PIIX4,):
    11131112                    iDevice = 1; # Master is for the OS.
    11141113
    … …  
    11411140
    11421141                        iLun = 0;
    1143                         if eStorageController == vboxcon.StorageControllerType_PIIX3 or \
    1144                            eStorageController == vboxcon.StorageControllerType_PIIX4:
     1142                        if eStorageController in (vboxcon.StorageControllerType_PIIX3, vboxcon.StorageControllerType_PIIX4,):
    11451143                            iLun = 1
    11461144                        sDrv, fDrvScsi = self.getStorageDriverFromEnum(eStorageController, True);

  • trunk/src/VBox/ValidationKit/tests/storage/tdStorageSnapshotMerging1.py

    r79022 r79087  
    7979
    8080
    81 class tdStorageSnapshot(vbox.TestDriver):                                      # pylint: disable=R0902
     81class tdStorageSnapshot(vbox.TestDriver):                                      # pylint: disable=too-many-instance-attributes
    8282    """
    8383    Storage benchmark.
    … …  
    109109        return rc;
    110110
    111     def parseOption(self, asArgs, iArg):                                        # pylint: disable=R0912,R0915
     111    def parseOption(self, asArgs, iArg):                                        # pylint: disable=too-many-branches,too-many-statements
    112112        if asArgs[iArg] == '--storage-ctrls':
    113113            iArg += 1;

  • trunk/src/VBox/ValidationKit/tests/storage/tdStorageStress1.py

    r76553 r79087  
    6060    return sType;
    6161
    62 class tdStorageStress(vbox.TestDriver):                                      # pylint: disable=R0902
     62class tdStorageStress(vbox.TestDriver):                                      # pylint: disable=too-many-instance-attributes
    6363    """
    6464    Storage testcase.
    … …  
    125125        return rc;
    126126
    127     def parseOption(self, asArgs, iArg):                                        # pylint: disable=R0912,R0915
     127    def parseOption(self, asArgs, iArg):                                        # pylint: disable=too-many-branches,too-many-statements
    128128        if asArgs[iArg] == '--virt-modes':
    129129            iArg += 1;
    … …  
    326326        return fRc;
    327327
    328     # pylint: disable=R0913
     328    # pylint: disable=too-many-arguments
    329329
    330330    def test1OneCfg(self, sVmName, eStorageController, sDiskFormat, sDiskPath1, sDiskPath2, \

  • trunk/src/VBox/ValidationKit/tests/unittests/tdUnitTest1.py

    r76553 r79087  
    9999            'testcase/tstX86-1': '',                    # Fails on win.x86.
    100100            'tscpasswd': '',                            # ??
    101             'tstVMREQ': '',                            # ?? Same as darwin.x86?
     101            'tstVMREQ': '',                             # ?? Same as darwin.x86?
    102102        },
    103103        'win.x86': {
    … …  
    505505            return False;
    506506        reporter.log('Exit code [sudo]: %s (%s)' % (iRc, asArgs));
    507         return iRc is 0;
     507        return iRc == 0;
    508508
    509509    def _hardenedMkDir(self, sPath):
    … …  
    565565        return True;
    566566
    567     def _executeTestCase(self, sName, sFullPath, sTestCaseSubDir, oDevNull): # pylint: disable=R0914
     567    def _executeTestCase(self, sName, sFullPath, sTestCaseSubDir, oDevNull): # pylint: disable=too-many-locals
    568568        """
    569569        Executes a test case.

  • trunk/src/VBox/ValidationKit/tests/usb/tdUsb1.py

    r76553 r79087  
    5656
    5757
    58 class tdUsbBenchmark(vbox.TestDriver):                                      # pylint: disable=R0902
     58class tdUsbBenchmark(vbox.TestDriver):                                      # pylint: disable=too-many-instance-attributes
    5959    """
    6060    USB benchmark.
    … …  
    154154        return rc;
    155155
    156     def parseOption(self, asArgs, iArg):                                        # pylint: disable=R0912,R0915
     156    def parseOption(self, asArgs, iArg):                                        # pylint: disable=too-many-branches,too-many-statements
    157157        if asArgs[iArg] == '--virt-modes':
    158158            iArg += 1;
    … …  
    423423        return fRc;
    424424
    425     def testUsbReattach(self, oSession, oTxsSession, sUsbCtrl, sSpeed, sCaptureFile = None): # pylint: disable=W0613
     425    def testUsbReattach(self, oSession, oTxsSession, sUsbCtrl, sSpeed, sCaptureFile = None): # pylint: disable=unused-argument
    426426        """
    427427        Tests that rapid connect/disconnect cycles work.

  • trunk/src/VBox/ValidationKit/tests/usb/tst-utsgadget.py

    r76553 r79087  
    6969    return 'FAILED';
    7070
    71 def main(asArgs): # pylint: disable=C0111,R0914,R0915
     71def main(asArgs): # pylint: disable=missing-docstring,too-many-locals,too-many-statements
    7272    cMsTimeout      = long(30*1000);
    7373    sAddress        = 'localhost';

  • trunk/src/VBox/ValidationKit/tests/usb/usbgadget.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""
    … …  
    193193    abArray = array.array('B', (0, ));
    194194    cb = cb - 1;
    195     for i in range(cb): # pylint: disable=W0612
     195    for i in range(cb): # pylint: disable=unused-variable
    196196        abArray.append(0);
    197197    return abArray;
    … …  
    985985                    if oXcpt[0] == errno.EWOULDBLOCK:
    986986                        return True;
    987                     if utils.getHostOs == 'win' and oXcpt[0] == errno.WSAEWOULDBLOCK: # pylint: disable=E1101
     987                    if utils.getHostOs == 'win' and oXcpt[0] == errno.WSAEWOULDBLOCK: # pylint: disable=no-member
    988988                        return True;
    989989                except: pass;
    … …  
    11231123        oWakeupW = None;
    11241124        if hasattr(socket, 'socketpair'):
    1125             try:    (oWakeupR, oWakeupW) = socket.socketpair();         # pylint: disable=E1101
     1125            try:    (oWakeupR, oWakeupW) = socket.socketpair();         # pylint: disable=no-member
    11261126            except: reporter.logXcpt('socket.socketpair() failed');
    11271127
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette