Changeset 79087 in vbox for trunk/src/VBox/ValidationKit/testmanager/webui

Timestamp:

Jun 11, 2019 11:58:28 AM (6 years ago)

Author:

vboxsync

Message:

ValKit: New pylint version - cleanup in progress.

Location:

trunk/src/VBox/ValidationKit/testmanager/webui

Files:

• wuiadmin.py (modified) (1 diff)
• wuiadmintestbox.py (modified) (2 diffs)
• wuibase.py (modified) (2 diffs)
• wuicontentbase.py (modified) (14 diffs)
• wuihlpform.py (modified) (4 diffs)
• wuihlpgraph.py (modified) (3 diffs)
• wuihlpgraphgooglechart.py (modified) (1 diff)
• wuihlpgraphmatplotlib.py (modified) (7 diffs)
• wuimain.py (modified) (1 diff)
• wuireport.py (modified) (1 diff)
• wuitestresult.py (modified) (2 diffs)

trunk/src/VBox/ValidationKit/testmanager/webui/wuiadmin.py

@@ -812 +812 @@
                                            self.ksActionGlobalRsrcShowAll);
 
-    def _actionGlobalRsrcShowAddEdit(self, sAction): # pylint: disable=C0103
+    def _actionGlobalRsrcShowAddEdit(self, sAction): # pylint: disable=invalid-name
         """Show Global Resource creation or edit dialog"""
         from testmanager.core.globalresource           import GlobalResourceLogic, GlobalResourceData;

trunk/src/VBox/ValidationKit/testmanager/webui/wuiadmintestbox.py

@@ -239 +239 @@
         return (sTitle, sBody);
 
-    def _formatListEntry(self, iEntry): # pylint: disable=R0914
+    def _formatListEntry(self, iEntry): # pylint: disable=too-many-locals
         from testmanager.webui.wuiadmin import WuiAdmin;
         oEntry  = self._aoEntries[iEntry];
@@ -274 +274 @@
             else:
                 from testmanager.webui.wuimain import WuiMain;
-                oState = WuiTmLink(oEntry.oStatus.enmState, WuiMain.ksScriptName,                       # pylint: disable=R0204
+                oState = WuiTmLink(oEntry.oStatus.enmState, WuiMain.ksScriptName,                       # pylint: disable=redefined-variable-type
                                    { WuiMain.ksParamAction: WuiMain.ksActionTestResultDetails,
                                      TestSetData.ksParam_idTestSet: oEntry.oStatus.idTestSet, },

trunk/src/VBox/ValidationKit/testmanager/webui/wuibase.py

@@ -523 +523 @@
         return asValues;
 
-    def getListOfTestCasesParam(self, sName, asDefaults = None):  # too many local vars - pylint: disable=R0914
+    def getListOfTestCasesParam(self, sName, asDefaults = None):  # too many local vars - pylint: disable=too-many-locals
         """Get list of test cases and their parameters"""
         if sName in self._dParams:
@@ -855 +855 @@
         return True
 
-    def _actionGenericFormDetails(self, oDataType, oLogicType, oFormType, sIdAttr = None, sGenIdAttr = None): # pylint: disable=R0914
+    def _actionGenericFormDetails(self, oDataType, oLogicType, oFormType, sIdAttr = None, sGenIdAttr = None): # pylint: disable=too-many-locals
         """
         Generic handler for showing a details form/page.

trunk/src/VBox/ValidationKit/testmanager/webui/wuicontentbase.py

@@ -47 +47 @@
 
 
-class WuiHtmlBase(object): # pylint: disable=R0903
+class WuiHtmlBase(object): # pylint: disable=too-few-public-methods
     """
     Base class for HTML objects.
@@ -69 +69 @@
 
 
-class WuiLinkBase(WuiHtmlBase): # pylint: disable=R0903
+class WuiLinkBase(WuiHtmlBase): # pylint: disable=too-few-public-methods
     """
     For passing links from WuiListContentBase._formatListEntry.
@@ -118 +118 @@
 
 
-class WuiTmLink(WuiLinkBase): # pylint: disable=R0903
+class WuiTmLink(WuiLinkBase): # pylint: disable=too-few-public-methods
     """ Local link to the test manager. """
 
@@ -139 +139 @@
 
 
-class WuiAdminLink(WuiTmLink): # pylint: disable=R0903
+class WuiAdminLink(WuiTmLink): # pylint: disable=too-few-public-methods
     """ Local link to the test manager's admin portion. """
 
@@ -156 +156 @@
                            sFragmentId = sFragmentId, fBracketed = fBracketed);
 
-class WuiMainLink(WuiTmLink): # pylint: disable=R0903
+class WuiMainLink(WuiTmLink): # pylint: disable=too-few-public-methods
     """ Local link to the test manager's main portion. """
 
@@ -170 +170 @@
                            sFragmentId = sFragmentId, fBracketed = fBracketed);
 
-class WuiSvnLink(WuiLinkBase): # pylint: disable=R0903
+class WuiSvnLink(WuiLinkBase): # pylint: disable=too-few-public-methods
     """
     For linking to a SVN revision.
@@ -180 +180 @@
                              fBracketed = fBracketed, sExtraAttrs = sExtraAttrs);
 
-class WuiSvnLinkWithTooltip(WuiSvnLink): # pylint: disable=R0903
+class WuiSvnLinkWithTooltip(WuiSvnLink): # pylint: disable=too-few-public-methods
     """
     For linking to a SVN revision with changelog tooltip.
@@ -202 +202 @@
             WuiLinkBase.__init__(self, sName, sUrl, fBracketed = fBracketed);
 
-class WuiRawHtml(WuiHtmlBase): # pylint: disable=R0903
+class WuiRawHtml(WuiHtmlBase): # pylint: disable=too-few-public-methods
     """
     For passing raw html from WuiListContentBase._formatListEntry.
@@ -213 +213 @@
         return self.sHtml;
 
-class WuiHtmlKeeper(WuiHtmlBase): # pylint: disable=R0903
+class WuiHtmlKeeper(WuiHtmlBase): # pylint: disable=too-few-public-methods
     """
     For keeping a list of elements, concatenating their toHtml output together.
@@ -238 +238 @@
         return self.sSep.join(oObj.toHtml() for oObj in self.aoKept);
 
-class WuiSpanText(WuiRawHtml): # pylint: disable=R0903
+class WuiSpanText(WuiRawHtml): # pylint: disable=too-few-public-methods
     """
     Outputs the given text within a span of the given CSS class.
@@ -252 +252 @@
                                 % ( webutils.escapeAttr(sSpanClass), webutils.escapeAttr(sTitle), webutils.escapeElem(sText),));
 
-class WuiElementText(WuiRawHtml): # pylint: disable=R0903
+class WuiElementText(WuiRawHtml): # pylint: disable=too-few-public-methods
     """
     Outputs the given element text.
@@ -260 +260 @@
 
 
-class WuiContentBase(object): # pylint: disable=R0903
+class WuiContentBase(object): # pylint: disable=too-few-public-methods
     """
     Base for the content classes.
@@ -382 +382 @@
         return sHtml;
 
-class WuiSingleContentBase(WuiContentBase): # pylint: disable=R0903
+class WuiSingleContentBase(WuiContentBase): # pylint: disable=too-few-public-methods
     """
     Base for the content classes working on a single data object (oData).
@@ -391 +391 @@
 
 
-class WuiFormContentBase(WuiSingleContentBase): # pylint: disable=R0903
+class WuiFormContentBase(WuiSingleContentBase): # pylint: disable=too-few-public-methods
     """
     Base class for simple input form content classes (single data object).

trunk/src/VBox/ValidationKit/testmanager/webui/wuihlpform.py

@@ -415 +415 @@
                              sExtraAttribs = sExtraAttribs);
 
-    def addListOfTestCaseArgs(self, sName, aoVariations, sLabel): # pylint: disable=R0915
+    def addListOfTestCaseArgs(self, sName, aoVariations, sLabel): # pylint: disable=too-many-statements
         """
         Adds a list of test case argument variations to the form.
@@ -646 +646 @@
         return self._add(sHtml)
 
-    def addListOfTestGroupMembers(self, sName, aoTestGroupMembers, aoAllTestCases, sLabel,  # pylint: disable=R0914
+    def addListOfTestGroupMembers(self, sName, aoTestGroupMembers, aoAllTestCases, sLabel,  # pylint: disable=too-many-locals
                                   fReadOnly = True):
         """
@@ -763 +763 @@
                          u'</table>\n');
 
-    def addListOfSchedGroupMembers(self, sName, aoSchedGroupMembers, aoAllTestGroups,  # pylint: disable=R0914
+    def addListOfSchedGroupMembers(self, sName, aoSchedGroupMembers, aoAllTestGroups,  # pylint: disable=too-many-locals
                                    sLabel, fReadOnly = True):
         """
@@ -862 +862 @@
                          u'</table>\n');
 
-    def addListOfSchedGroupsForTestBox(self, sName, aoInSchedGroups, aoAllSchedGroups, sLabel,  # pylint: disable=R0914
+    def addListOfSchedGroupsForTestBox(self, sName, aoInSchedGroups, aoAllSchedGroups, sLabel,  # pylint: disable=too-many-locals
                                        fReadOnly = None):
         # type: (str, TestBoxInSchedGroupDataEx, SchedGroupData, str, bool) -> str

trunk/src/VBox/ValidationKit/testmanager/webui/wuihlpgraph.py

@@ -30 +30 @@
 
 
-class WuiHlpGraphDataTable(object): # pylint: disable=R0903
+class WuiHlpGraphDataTable(object): # pylint: disable=too-few-public-methods
     """
     Data table container.
     """
 
-    class Row(object): # pylint: disable=R0903
+    class Row(object): # pylint: disable=too-few-public-methods
         """A row."""
         def __init__(self, sGroup, aoValues, asValues = None):
@@ -59 +59 @@
 
 
-class WuiHlpGraphDataTableEx(object): # pylint: disable=R0903
+class WuiHlpGraphDataTableEx(object): # pylint: disable=too-few-public-methods
     """
     Data container for an table/graph with optional error bars on the Y values.
     """
 
-    class DataSeries(object): # pylint: disable=R0903
+    class DataSeries(object): # pylint: disable=too-few-public-methods
         """
         A data series.
@@ -100 +100 @@
 # Dynamically choose implementation.
 #
-if True: # pylint: disable=W0125
+if True: # pylint: disable=using-constant-test
     from testmanager.webui import wuihlpgraphgooglechart        as GraphImplementation;
 else:
     try:
-        import matplotlib; # pylint: disable=W0611,F0401,import-error,wrong-import-order
+        import matplotlib; # pylint: disable=unused-import,import-error,import-error,wrong-import-order
         from testmanager.webui import wuihlpgraphmatplotlib     as GraphImplementation; # pylint: disable=ungrouped-imports
     except:
         from testmanager.webui import wuihlpgraphsimple         as GraphImplementation;
 
-# pylint: disable=C0103
+# pylint: disable=invalid-name
 WuiHlpBarGraph              = GraphImplementation.WuiHlpBarGraph;
 WuiHlpLineGraph             = GraphImplementation.WuiHlpLineGraph;

trunk/src/VBox/ValidationKit/testmanager/webui/wuihlpgraphgooglechart.py

@@ -68 +68 @@
         return True;
 
-    def renderGraph(self): # pylint: disable=R0914
+    def renderGraph(self): # pylint: disable=too-many-locals
         fSlideFilter = True;
 

trunk/src/VBox/ValidationKit/testmanager/webui/wuihlpgraphmatplotlib.py

@@ -37 +37 @@
     from StringIO import StringIO as StringIO;  # pylint: disable=import-error,no-name-in-module
 
-import matplotlib;                              # pylint: disable=F0401
+import matplotlib;                              # pylint: disable=import-error
 matplotlib.use('Agg'); # Force backend.
-import matplotlib.pyplot;                       # pylint: disable=F0401
-from numpy import arange as numpy_arange;       # pylint: disable=E0611,E0401,wrong-import-order
+import matplotlib.pyplot;                       # pylint: disable=import-error
+from numpy import arange as numpy_arange;       # pylint: disable=no-name-in-module,import-error,wrong-import-order
 
 # Validation Kit imports.
@@ -64 +64 @@
         """
         if self._fXkcdStyle and matplotlib.__version__ > '1.2.9':
-            matplotlib.pyplot.xkcd();           # pylint: disable=E1101
+            matplotlib.pyplot.xkcd();           # pylint: disable=no-member
         matplotlib.rcParams.update({'font.size': self._cPtFont});
 
@@ -106 +106 @@
         return None;
 
-    def renderGraph(self): # pylint: disable=R0914
+    def renderGraph(self): # pylint: disable=too-many-locals
         aoTable  = self._oData.aoTable;
 
@@ -198 +198 @@
         return True;
 
-    def renderGraph(self): # pylint: disable=R0914
+    def renderGraph(self): # pylint: disable=too-many-locals
         aoSeries = self._oData.aoSeries;
 
@@ -246 +246 @@
             oSubPlot.grid(True, 'both', axis = 'x');
 
-        if True: # pylint: disable=W0125
+        if True: # pylint: disable=using-constant-test
             #    oSubPlot.axis('off');
             #oSubPlot.grid(True, 'major', axis = 'none');
@@ -278 +278 @@
         self.setFontSize(6);
 
-    def renderGraph(self): # pylint: disable=R0914
+    def renderGraph(self): # pylint: disable=too-many-locals
         assert len(self._oData.aoSeries) == 1;
         oSeries = self._oData.aoSeries[0];
@@ -288 +288 @@
 
         oFigure = self._createFigure();
-        from mpl_toolkits.axes_grid.axislines import SubplotZero; # pylint: disable=E0401
+        from mpl_toolkits.axes_grid.axislines import SubplotZero; # pylint: disable=import-error
         oAxis = SubplotZero(oFigure, 111);
         oFigure.add_subplot(oAxis);

trunk/src/VBox/ValidationKit/testmanager/webui/wuimain.py

@@ -717 +717 @@
     #
 
-    def _actionGroupedResultsListing( #pylint: disable=R0914
+    def _actionGroupedResultsListing( #pylint: disable=too-many-locals
             self,
             enmResultsGroupingType,

trunk/src/VBox/ValidationKit/testmanager/webui/wuireport.py

@@ -416 +416 @@
                     oTable.addRow(oPeriod.sDesc, aiValues, asValues);
 
-                if True: # pylint: disable=W0125
+                if True: # pylint: disable=using-constant-test
                     aiValues = [];
                     asValues = [];

trunk/src/VBox/ValidationKit/testmanager/webui/wuitestresult.py

@@ -154 +154 @@
 
     def _recursivelyGenerateEvents(self, oTestResult, sParentName, sLineage, iRow,
-                                   iFailure, oTestSet, iDepth):     # pylint: disable=R0914
+                                   iFailure, oTestSet, iDepth):     # pylint: disable=too-many-locals
         """
         Recursively generate event table rows for the result set.
@@ -442 +442 @@
 
 
-    def showTestCaseResultDetails(self,             # pylint: disable=R0914,R0915
+    def showTestCaseResultDetails(self,             # pylint: disable=too-many-locals,too-many-statements
                                   oTestResultTree,
                                   oTestSet,