Changeset 79496 in vbox for trunk/src/VBox/Runtime/r3/win/dllmain-win.cpp

Timestamp:

Jul 3, 2019 12:54:38 PM (6 years ago)

Author:

vboxsync

Message:

IPRT/DllMain: Don't put a 8KB buffer on the stack that we only need for processing the one time DLL_PROCESS_ATTACH event. This function is called for each thread being created or destroyed too.

File:

• trunk/src/VBox/Runtime/r3/win/dllmain-win.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/r3/win/dllmain-win.cpp

@@ -37 +37 @@
 
 /**
+ * Increases the load count on the IPRT DLL so it won't unload.
+ *
+ * This is a separate function so as to not overflow the stack of threads with
+ * very little of it.
+ *
+ * @param   hModule     The IPRT DLL module handle.
+ */
+DECL_NO_INLINE(static, void) EnsureNoUnload(HMODULE hModule)
+{
+    WCHAR wszName[RTPATH_MAX];
+    SetLastError(NO_ERROR);
+    if (   GetModuleFileNameW(hModule, wszName, RT_ELEMENTS(wszName)) > 0
+        && GetLastError() == NO_ERROR)
+    {
+        int cExtraLoads = 32;
+        while (cExtraLoads-- > 0)
+            LoadLibraryW(wszName);
+    }
+}
+
+
+/**
  * The Dll main entry point.
  */
@@ -50 +72 @@
          */
         case DLL_PROCESS_ATTACH:
-        {
-            WCHAR wszName[RTPATH_MAX];
-            SetLastError(NO_ERROR);
-            if (   GetModuleFileNameW((HMODULE)hModule, wszName, RT_ELEMENTS(wszName)) > 0
-                && GetLastError() == NO_ERROR)
-            {
-                int cExtraLoads = 32;
-                while (cExtraLoads-- > 0)
-                    LoadLibraryW(wszName);
-            }
+            EnsureNoUnload((HMODULE)hModule);
             break;
-        }
 
         case DLL_PROCESS_DETACH: