Changeset 82477 in vbox for trunk/src/VBox/GuestHost/SharedClipboard/clipboard-common.cpp

Timestamp:

Dec 6, 2019 11:54:16 PM (5 years ago)

Author:

vboxsync

Message:

clipboard-common.cpp: Use RTMemDup. Some nits. bugref:9437

File:

• trunk/src/VBox/GuestHost/SharedClipboard/clipboard-common.cpp (modified) (5 diffs)

trunk/src/VBox/GuestHost/SharedClipboard/clipboard-common.cpp

@@ -45 +45 @@
 {
     AssertPtrReturn(pvData, VERR_INVALID_POINTER);
-    AssertReturn   (cbData, VERR_INVALID_PARAMETER);
-
-    PSHCLEVENTPAYLOAD pPayload =
-        (PSHCLEVENTPAYLOAD)RTMemAlloc(sizeof(SHCLEVENTPAYLOAD));
-    if (!pPayload)
-        return VERR_NO_MEMORY;
-
-    pPayload->pvData = RTMemAlloc(cbData);
-    if (pPayload->pvData)
-    {
-        memcpy(pPayload->pvData, pvData, cbData);
-
-        pPayload->cbData = cbData;
-        pPayload->uID    = uID;
-
-        *ppPayload = pPayload;
-
-        return VINF_SUCCESS;
-    }
-
-    RTMemFree(pPayload);
+    AssertReturn(cbData > 0, VERR_INVALID_PARAMETER);
+
+    PSHCLEVENTPAYLOAD pPayload = (PSHCLEVENTPAYLOAD)RTMemAlloc(sizeof(SHCLEVENTPAYLOAD));
+    if (pPayload)
+    {
+        pPayload->pvData = RTMemDup(pvData, cbData);
+        if (pPayload->pvData)
+        {
+            pPayload->cbData = cbData;
+            pPayload->uID    = uID;
+
+            *ppPayload = pPayload;
+            return VINF_SUCCESS;
+        }
+
+        RTMemFree(pPayload);
+    }
     return VERR_NO_MEMORY;
 }
@@ -88 +84 @@
 
     pPayload->cbData = 0;
+    pPayload->uID = UINT32_MAX;
 
     RTMemFree(pPayload);
-    pPayload = NULL;
 }
 
@@ -148 +144 @@
 int ShClEventSourceCreate(PSHCLEVENTSOURCE pSource, SHCLEVENTSOURCEID uID)
 {
+    LogFlowFunc(("pSource=%p, uID=%RU16\n", pSource, uID));
     AssertPtrReturn(pSource, VERR_INVALID_POINTER);
-
-    LogFlowFunc(("pSource=%p, uID=%RU32\n", pSource, uID));
-
-    int rc = VINF_SUCCESS;
 
     RTListInit(&pSource->lstEvents);
@@ -160 +153 @@
     pSource->uEventIDNext = RTRandU32() % VBOX_SHCL_MAX_EVENTS;
 
-    LogFlowFuncLeaveRC(rc);
-    return rc;
+    LogFlowFuncLeaveRC(VINF_SUCCESS);
+    return VINF_SUCCESS;
 }
 
@@ -178 +171 @@
     ShClEventSourceReset(pSource);
 
-    pSource->uID          = 0;
-    pSource->uEventIDNext = 0;
+    pSource->uID          = UINT16_MAX;
+    pSource->uEventIDNext = UINT32_MAX;
 }