ClipboardStreamImpl-win.cpp

Timestamp:

Dec 7, 2019 12:22:38 PM (5 years ago)

Author:

vboxsync

Message:

ClipboardStreamImpl-win.cpp: Point out wrong allocator for STATSTG::pwczName. bugref:9437

File:

trunk/src/VBox/GuestHost/SharedClipboard/ClipboardStreamImpl-win.cpp

-              r82466
+              r82495
     if (pStatStg)
+    {
         RT_BZERO(pStatStg, sizeof(STATSTG));
+        RT_ZERO(*pStatStg);
         switch (dwFlags)
 …
             case STATFLAG_DEFAULT:
+            {
+                /** @todo r=bird: This is using the wrong allocator.  According to MSDN the
+                 * caller will pass this to CoTaskMemFree, so we should use CoTaskMemAlloc to
+                 * allocate it. */
                 int rc2 = RTStrToUtf16(m_strPath.c_str(), &pStatStg->pwcsName);
                 if (RT_FAILURE(rc2))

Note: See TracChangeset for help on using the changeset viewer.