Changeset 84588 in vbox for trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py

Timestamp:

May 28, 2020 12:40:39 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

138318

Message:

Validation Kit/tdAddGuestCtrl.py: Simplified long arguments tests.

File:

• trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py (modified) (1 diff)

trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py

@@ -2958 +2958 @@
         # Test very long arguments.
         if self.oTstDrv.fpApiVer >= 6.1:
-            if oTestVm.isWindows() \
-            or oTestVm.isOS2():
-                sEcho = sShell;
-                sEchoSuffix = '';
-            else:
-                sEcho       = oTestVm.pathJoin(self.oTstDrv.getGuestSystemDir(oTestVm), 'echo');
-                # The suffix acts as an indicator / beacon to see if the actual (random) args were received fully.
-                sEchoSuffix = "-n";
-
             for _ in xrange(0, 16):
+                if oTestVm.isWindows() \
+                or oTestVm.isOS2():
+                    sCmd   = sShell;
+                    asArgs = [ sShell, sShellOpt, "echo",
+                               self.oTestFiles.generateFilenameEx(128 * 1024, 2048), "--end-marker" ],
+                else:
+                    sCmd   = oTestVm.pathJoin(self.oTstDrv.getGuestSystemDir(oTestVm), 'echo');
+                    asArgs = [ sCmd,
+                               self.oTestFiles.generateFilenameEx(128 * 1024, 2048), "--end-marker" ],
                 ## @todo Check limits; on Ubuntu with 256KB IPRT returns VERR_NOT_IMPLEMENTED.
-                atExec.append([ tdTestExec(sCmd = sEcho,
-                                           asArgs = [ sEcho, sShellOpt,
-                                                      self.oTestFiles.generateFilenameEx(128 * 1024, 2048), sEchoSuffix ],
+                atExec.append([ tdTestExec(sCmd, asArgs,
                                            afFlags = [ vboxcon.ProcessCreateFlag_WaitForStdOut,
                                                        vboxcon.ProcessCreateFlag_WaitForStdErr ]),