Changeset 86031 in vbox for trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp

Timestamp:

Sep 4, 2020 12:15:14 PM (4 years ago)

Author:

vboxsync

Message:

AMD IOMMU: bugref:9654 Logging.

File:

• trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp (modified) (16 diffs)

trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp

@@ -1981 +1981 @@
     RTGCPHYS const GCPhysDte    = GCPhysDevTab + offDte;
 
+    LogFlowFunc(("idxSegsEn=%#x GCPhysDevTab=%#RGp offDte=%#x GCPhysDte=%#RGp\n", idxSegsEn, GCPhysDevTab, offDte, GCPhysDte));
+
     Assert(!(GCPhysDevTab & X86_PAGE_4K_OFFSET_MASK));
     int rc = PDMDevHlpPCIPhysRead(pDevIns, GCPhysDte, pDte, sizeof(*pDte));
@@ -2066 +2068 @@
          *        raising an ILLEGAL_DEV_TABLE_ENTRY event or an IO_PAGE_FAULT event here.
          *        I'm just going with I/O page fault. */
-        LogFunc(("Invalid root page table level %#x -> IOPF", uMaxLevel));
+        LogFunc(("Invalid root page table level %#x -> IOPF\n", uMaxLevel));
         EVT_IO_PAGE_FAULT_T EvtIoPageFault;
         iommuAmdInitIoPageFaultEvent(uDevId, pDte->n.u16DomainId, uIova, true /* fPresent */, false /* fRsvdNotZero */,
@@ -2081 +2083 @@
     else
     {
-        LogFunc(("Permission denied (fAccess=%#x fRootPtePerm=%#x) -> IOPF", fAccess, fRootPtePerm));
+        LogFunc(("Permission denied (fAccess=%#x fRootPtePerm=%#x) -> IOPF\n", fAccess, fRootPtePerm));
         EVT_IO_PAGE_FAULT_T EvtIoPageFault;
         iommuAmdInitIoPageFaultEvent(uDevId, pDte->n.u16DomainId, uIova, true /* fPresent */, false /* fRsvdNotZero */,
@@ -2153 +2155 @@
         else
         {
-            LogFunc(("Page table entry permission denied (fAccess=%#x fPtePerm=%#x) -> IOPF", fAccess, fPtePerm));
+            LogFunc(("Page table entry permission denied (fAccess=%#x fPtePerm=%#x) -> IOPF\n", fAccess, fPtePerm));
             EVT_IO_PAGE_FAULT_T EvtIoPageFault;
             iommuAmdInitIoPageFaultEvent(uDevId, pDte->n.u16DomainId, uIova, true /* fPresent */, false /* fRsvdNotZero */,
@@ -2190 +2192 @@
             }
 
-            LogFunc(("Page size invalid cShift=%#x -> IOPF", cShift));
+            LogFunc(("Page size invalid cShift=%#x -> IOPF\n", cShift));
             EVT_IO_PAGE_FAULT_T EvtIoPageFault;
             iommuAmdInitIoPageFaultEvent(uDevId, pDte->n.u16DomainId, uIova, true /* fPresent */, false /* fRsvdNotZero */,
@@ -2205 +2207 @@
         else
         {
-            LogFunc(("Next level of PDE invalid uNextLevel=%#x -> IOPF", uNextLevel));
+            LogFunc(("Next level of PDE invalid uNextLevel=%#x -> IOPF\n", uNextLevel));
             EVT_IO_PAGE_FAULT_T EvtIoPageFault;
             iommuAmdInitIoPageFaultEvent(uDevId, pDte->n.u16DomainId, uIova, true /* fPresent */, false /* fRsvdNotZero */,
@@ -2222 +2224 @@
         else
         {
-            LogFunc(("Next level (%#x) must be less than the current level (%#x) -> IOPF", uNextLevel, uLevel));
+            LogFunc(("Next level (%#x) must be less than the current level (%#x) -> IOPF\n", uNextLevel, uLevel));
             EVT_IO_PAGE_FAULT_T EvtIoPageFault;
             iommuAmdInitIoPageFaultEvent(uDevId, pDte->n.u16DomainId, uIova, true /* fPresent */, false /* fRsvdNotZero */,
@@ -2240 +2242 @@
         else
         {
-            LogFunc(("IOVA of skipped levels are not zero %#RX64 (SkipMask=%#RX64) -> IOPF", uIova, uIovaSkipMask));
+            LogFunc(("IOVA of skipped levels are not zero %#RX64 (SkipMask=%#RX64) -> IOPF\n", uIova, uIovaSkipMask));
             EVT_IO_PAGE_FAULT_T EvtIoPageFault;
             iommuAmdInitIoPageFaultEvent(uDevId, pDte->n.u16DomainId, uIova, true /* fPresent */, false /* fRsvdNotZero */,
@@ -2533 +2535 @@
                 }
 
-                LogFunc(("Interrupt type (%#x) invalid -> IOPF", Irte.n.u3IntrType));
+                LogFunc(("Interrupt type (%#x) invalid -> IOPF\n", Irte.n.u3IntrType));
                 EVT_IO_PAGE_FAULT_T EvtIoPageFault;
                 iommuAmdInitIoPageFaultEvent(uDevId, pDte->n.u16DomainId, pMsiIn->Addr.u64, Irte.n.u1RemapEnable,
@@ -2541 +2543 @@
             }
 
-            LogFunc(("Guest mode not supported -> IOPF"));
+            LogFunc(("Guest mode not supported -> IOPF\n"));
             EVT_IO_PAGE_FAULT_T EvtIoPageFault;
             iommuAmdInitIoPageFaultEvent(uDevId, pDte->n.u16DomainId, pMsiIn->Addr.u64, Irte.n.u1RemapEnable,
@@ -2549 +2551 @@
         }
 
-        LogFunc(("Remapping disabled -> IOPF"));
+        LogFunc(("Remapping disabled -> IOPF\n"));
         EVT_IO_PAGE_FAULT_T EvtIoPageFault;
         iommuAmdInitIoPageFaultEvent(uDevId, pDte->n.u16DomainId, pMsiIn->Addr.u64, Irte.n.u1RemapEnable,
@@ -2576 +2578 @@
 {
     /* Read the device table entry from memory. */
+    LogFlowFunc(("uDevId=%#x enmOp=%u\n", uDevId, enmOp));
+
     DTE_T Dte;
     int rc = iommuAmdReadDte(pDevIns, uDevId, enmOp, &Dte);
@@ -2673 +2677 @@
                         Assert(uIntrCtrl == IOMMU_INTR_CTRL_RSVD);
 
-                        LogFunc(("IntCtl mode invalid %#x -> Illegal DTE", uIntrCtrl));
+                        LogFunc(("IntCtl mode invalid %#x -> Illegal DTE\n", uIntrCtrl));
 
                         EVT_ILLEGAL_DTE_T Event;
@@ -2688 +2692 @@
                     default:
                     {
-                        LogFunc(("MSI data delivery mode invalid %#x -> Target abort", u8DeliveryMode));
+                        LogFunc(("MSI data delivery mode invalid %#x -> Target abort\n", u8DeliveryMode));
                         iommuAmdSetPciTargetAbort(pDevIns);
                         return VERR_IOMMU_INTR_REMAP_FAILED;
@@ -2705 +2709 @@
             else
             {
-                LogFunc(("MSI address region invalid %#RX64.", pMsiIn->Addr.u64));
+                LogFunc(("MSI address region invalid %#RX64\n", pMsiIn->Addr.u64));
                 return VERR_IOMMU_INTR_REMAP_FAILED;
             }
@@ -2712 +2716 @@
         {
             /** @todo IOMMU: Add to interrupt remapping cache. */
+            LogFlowFunc(("DTE interrupt map not valid\n"));
             *pMsiOut = *pMsiIn;
             return VINF_SUCCESS;