Changeset 86741 in vbox for trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

Timestamp:

Oct 28, 2020 4:32:46 PM (4 years ago)

Author:

vboxsync

Message:

AMD IOMMU: bugref:9654 DevIchAc97: Use PCI versions of the function that access guest memory.

File:

• trunk/src/VBox/Devices/Audio/DevIchAc97.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

@@ -849 +849 @@
 
     AC97BDLE BDLE;
-    PDMDevHlpPhysRead(pDevIns, pRegs->bdbar + pRegs->civ * sizeof(AC97BDLE), &BDLE, sizeof(AC97BDLE));
+    PDMDevHlpPCIPhysRead(pDevIns, pRegs->bdbar + pRegs->civ * sizeof(AC97BDLE), &BDLE, sizeof(AC97BDLE));
     pRegs->bd_valid   = 1;
 # ifndef RT_LITTLE_ENDIAN
@@ -1572 +1572 @@
     {
         AC97BDLE BDLE;
-        PDMDevHlpPhysRead(pDevIns, u64BDLBase + i * sizeof(AC97BDLE), &BDLE, sizeof(AC97BDLE));
+        PDMDevHlpPCIPhysRead(pDevIns, u64BDLBase + i * sizeof(AC97BDLE), &BDLE, sizeof(AC97BDLE));
 
 # ifndef RT_LITTLE_ENDIAN
@@ -2894 +2894 @@
                 if (cbDst)
                 {
-                    int rc2 = PDMDevHlpPhysRead(pDevIns, pRegs->bd.addr, (uint8_t *)pvDst, cbDst);
+                    int rc2 = PDMDevHlpPCIPhysRead(pDevIns, pRegs->bd.addr, (uint8_t *)pvDst, cbDst);
                     AssertRC(rc2);
 
@@ -2919 +2919 @@
                 if (cbSrc)
                 {
-/** @todo r=bird: Just curious, DevHDA uses PDMDevHlpPCIPhysWrite here.  So,
- *        is AC97 not subject to PCI busmaster enable/disable? */
-                    int rc2 = PDMDevHlpPhysWrite(pDevIns, pRegs->bd.addr, (uint8_t *)pvSrc, cbSrc);
+                    int rc2 = PDMDevHlpPCIPhysWrite(pDevIns, pRegs->bd.addr, (uint8_t *)pvSrc, cbSrc);
                     AssertRC(rc2);