Changeset 87066 in vbox for trunk/src/VBox/GuestHost/SharedClipboard/clipboard-transfers-http.cpp

Timestamp:

Dec 9, 2020 2:08:45 PM (4 years ago)

Author:

vboxsync

Message:

Shared Clipboard/Transfers: Pointer to port number is optional in ShClTransferHttpServerCreate(). bugref:9874

File:

• trunk/src/VBox/GuestHost/SharedClipboard/clipboard-transfers-http.cpp (modified) (2 diffs)

trunk/src/VBox/GuestHost/SharedClipboard/clipboard-transfers-http.cpp

@@ -283 +283 @@
  * @returns VBox status code.
  * @param   pSrv                HTTP server instance to create.
- * @param   puPort              Where to return the TCP port number being used on success.
+ * @param   puPort              Where to return the TCP port number being used on success. Optional.
  */
 int ShClTransferHttpServerCreate(PSHCLHTTPSERVER pSrv, uint16_t *puPort)
 {
     AssertPtrReturn(pSrv, VERR_INVALID_POINTER);
-    AssertPtrReturn(puPort, VERR_INVALID_POINTER);
+    /* puPort is optional. */
 
     /** @todo Try favorite ports first (e.g. 8080, 8000, ...)? */
@@ -300 +300 @@
         {
             uPort = RTRandAdvU32Ex(hRand, 1024, UINT16_MAX);
-#ifdef DEBUG_andy
-            uPort = 8000; /** @todo BUGBUG Remove this! */
-#endif
             rc = ShClTransferHttpServerCreateEx(pSrv, (uint32_t)uPort);
             if (RT_SUCCESS(rc))
             {
-                *puPort = uPort;
+                if (puPort)
+                    *puPort = uPort;
                 break;
             }