Changeset 87881 in vbox

Timestamp:

Feb 26, 2021 5:09:24 AM (4 years ago)

Author:

vboxsync

Message:

AMD IOMMU: bugref:9654 Fix MemoryAccess Read/Write stats (was incorrectly swapped)

File:

• trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp (modified) (7 diffs)

trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp

@@ -4207 +4207 @@
 #ifdef VBOX_WITH_STATISTICS
         if (!fBulk)
-            STAM_COUNTER_INC(&pThis->CTX_SUFF_Z(StatMemRead));
+            STAM_COUNTER_INC(&pThis->CTX_SUFF_Z(StatMemWrite));
         else
-            STAM_COUNTER_INC(&pThis->CTX_SUFF_Z(StatMemBulkRead));
+            STAM_COUNTER_INC(&pThis->CTX_SUFF_Z(StatMemBulkWrite));
 #else
         RT_NOREF2(pThis, fBulk);
@@ -4221 +4221 @@
 #ifdef VBOX_WITH_STATISTICS
         if (!fBulk)
-            STAM_COUNTER_INC(&pThis->CTX_SUFF_Z(StatMemWrite));
+            STAM_COUNTER_INC(&pThis->CTX_SUFF_Z(StatMemRead));
         else
-            STAM_COUNTER_INC(&pThis->CTX_SUFF_Z(StatMemBulkWrite));
+            STAM_COUNTER_INC(&pThis->CTX_SUFF_Z(StatMemBulkRead));
 #else
         RT_NOREF2(pThis, fBulk);
@@ -6037 +6037 @@
 }
 
+
 /**
  * @callback_method_impl{FNDBGFHANDLERDEV}
@@ -6697 +6698 @@
     IOMMU_LOCK_NORET(pDevIns, pThisR3);
 
-    /* Close the command thread semaphore. */
     if (pThis->hEvtCmdThread != NIL_SUPSEMEVENT)
     {
@@ -6705 +6705 @@
 
 #ifdef IOMMU_WITH_IOTLBE_CACHE
-    /* Destroy the IOTLB cache. */
     if (pThisR3->paIotlbes)
     {
@@ -6855 +6854 @@
     /*
      * Register MSI support for the PCI device.
-     * This must be done -after- register it as a PCI device!
+     * This must be done -after- registering it as a PCI device!
      */
     rc = PDMDevHlpPCIRegisterMsi(pDevIns, &MsiReg);
@@ -6880 +6879 @@
 
     /*
-     * Register saved state.
+     * Register saved state handlers.
      */
     rc = PDMDevHlpSSMRegisterEx(pDevIns, IOMMU_SAVED_STATE_VERSION, sizeof(IOMMU), NULL /* pszBefore */,