Changeset 88015 in vbox for trunk/src/VBox/Devices/Audio/DrvAudioCommon.cpp

Timestamp:

Mar 8, 2021 1:05:26 PM (4 years ago)

Author:

vboxsync

Message:

Audio: DrvAudioHlpPCMPropsAreEqual -> DrvAudioHlpPcmPropsAreEqual & DrvAudioHlpStreamCfgMatchesPcmProps (overloading functions is confusing, esp. when only one variant was ever used). bugref:9890

File:

• trunk/src/VBox/Devices/Audio/DrvAudioCommon.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/DrvAudioCommon.cpp

@@ -792 +792 @@
 
 /**
+ * Checks whether stream configuration matches the given PCM properties.
+ *
+ * @returns @c true if equal, @c false if not.
+ * @param   pCfg    Stream configuration.
+ * @param   pProps  PCM properties to match with.
+ */
+bool DrvAudioHlpStreamCfgMatchesPcmProps(PCPDMAUDIOSTREAMCFG pCfg, PCPDMAUDIOPCMPROPS pProps)
+{
+    AssertPtrReturn(pCfg, false);
+    return DrvAudioHlpPcmPropsAreEqual(pProps, &pCfg->Props);
+}
+
+/**
  * Frees an allocated audio stream configuration.
  *
@@ -1335 +1348 @@
  * @param   pProps2             Second properties to compare.
  */
-bool DrvAudioHlpPCMPropsAreEqual(PCPDMAUDIOPCMPROPS pProps1, PCPDMAUDIOPCMPROPS pProps2)
+bool DrvAudioHlpPcmPropsAreEqual(PCPDMAUDIOPCMPROPS pProps1, PCPDMAUDIOPCMPROPS pProps2)
 {
     AssertPtrReturn(pProps1, false);
@@ -1395 +1408 @@
 
     return fValid;
-}
-
-/**
- * Checks whether the given PCM properties are equal with the given
- * stream configuration.
- *
- * @returns @c true if equal, @c false if not.
- * @param   pProps              PCM properties to compare.
- * @param   pCfg                Stream configuration to compare.
- */
-bool DrvAudioHlpPCMPropsAreEqual(PCPDMAUDIOPCMPROPS pProps, PCPDMAUDIOSTREAMCFG pCfg)
-{
-    AssertPtrReturn(pProps, false);
-    AssertPtrReturn(pCfg,   false);
-
-    return DrvAudioHlpPCMPropsAreEqual(pProps, &pCfg->Props);
 }