Changeset 88112 in vbox for trunk/src/VBox/Devices/Audio/HDAStream.h

Timestamp:

Mar 12, 2021 8:41:05 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

143255

Message:

Audio,DevHDA: Made PDMAUDIOPCMPROPS_F2B and PDMAUDIOPCMPROPS_B2F work for 5.1 and other frame sizes that aren't a power of two. Rewrote hdaR3StreamDoDmaOutput. Mapping is now done using converter functions rather than the complexity in hdaR3StreamTransfer. Probably fixes some recent goofs in the DMA period heuristics for non-stereo guest streams, I've renamed the members to make it clear what's what. bugref:9890

File:

• trunk/src/VBox/Devices/Audio/HDAStream.h (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/HDAStream.h

@@ -132 +132 @@
      *  Can be 0 if no next transfer is scheduled. */
     uint64_t                tsTransferNext;
-    /** Total transfer size (in bytes) of a transfer period. */
+    /** Total transfer size (in bytes) of a transfer period.
+     * @note This is in host side frames, in case we're doing any mapping. */
     uint32_t                cbTransferSize;
-    /** Transfer chunk size (in bytes) of a transfer period. */
+    /** Unused, same as cbTransferSize. */
     uint32_t                cbTransferChunk;
     /** How many interrupts are pending due to
@@ -157 +158 @@
     /** The stream's period. Need for timing. */
     HDASTREAMPERIOD         Period;
-    /** The stream's current configuration.
-     *  Should match SDFMT. */
+    /** The stream's current host side configuration.
+     * This should match the SDnFMT in all respects but maybe the channel count as
+     * we may need to expand mono or into/from into stereo.  The unmodified SDnFMT
+     * properties can be found in HDASTREAMR3::Mapping::PCMProps. */
     PDMAUDIOSTREAMCFG       Cfg;
     /** Timestamp (real time, in ns) of last DMA transfer. */