Changeset 89143 in vbox for trunk/src/VBox/ValidationKit/utils/audio/vkat.cpp

Timestamp:

May 18, 2021 3:04:37 PM (4 years ago)

Author:

vboxsync

Message:

Audio/ValKit: Resolved some @todos. bugref:10008

File:

• trunk/src/VBox/ValidationKit/utils/audio/vkat.cpp (modified) (5 diffs)

trunk/src/VBox/ValidationKit/utils/audio/vkat.cpp

@@ -1951 +1951 @@
     PCPDMDRVREG pDrvReg       = g_aBackends[0].pDrvReg;
     bool        fWithDrvAudio = false;
+    uint8_t     cPcmSampleBit = 0;
+    uint8_t     cPcmChannels  = 0;
+    uint32_t    uPcmHz        = 0;
+    bool        fPcmSigned    = true;
 
     int           rc;
@@ -1993 +1997 @@
 
             case VKAT_TEST_OPT_COUNT:
-                break;
+                return RTMsgErrorExitFailure("Not yet implemented!");
 
             case VKAT_TEST_OPT_DEV:
@@ -2000 +2004 @@
 
             case VKAT_TEST_OPT_PAUSE:
-                break;
+                return RTMsgErrorExitFailure("Not yet implemented!");
 
             case VKAT_TEST_OPT_OUTDIR:
@@ -2009 +2013 @@
 
             case VKAT_TEST_OPT_PCM_BIT:
-                /** @todo r=bird: the X suffix means: "fingers off!"   */
-                TstCust.TestTone.Props.cbSampleX = ValueUnion.u8 / 8 /* bit */;
+                cPcmSampleBit = ValueUnion.u8;
                 break;
 
             case VKAT_TEST_OPT_PCM_CHAN:
-                /** @todo r=bird: the X suffix means: "fingers off!"   */
-                TstCust.TestTone.Props.cChannelsX = ValueUnion.u8;
+                cPcmChannels = ValueUnion.u8;
                 break;
 
             case VKAT_TEST_OPT_PCM_HZ:
-                TstCust.TestTone.Props.uHz = ValueUnion.u32;
+                uPcmHz = ValueUnion.u32;
                 break;
 
             case VKAT_TEST_OPT_PCM_SIGNED:
-                TstCust.TestTone.Props.fSigned = ValueUnion.f;
+                fPcmSigned = ValueUnion.f;
                 break;
 
@@ -2051 +2053 @@
      */
     RTTestBanner(g_hTest);
+
+    /* Initialize the custom test parameters with sensible defaults if nothing else is given. */
+    PDMAudioPropsInit(&TstCust.TestTone.Props,
+                      cPcmSampleBit ? cPcmSampleBit / 8 : 2 /* 16-bit */, fPcmSigned, cPcmChannels ? cPcmChannels : 2,
+                      uPcmHz ? uPcmHz : 44100);
 
     /* For now all tests have the same test environment. */