Changeset 89437 in vbox for trunk/src/VBox/VMM/VMMR3/PDMUsb.cpp

Timestamp:

Jun 1, 2021 3:50:07 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

144791

Message:

Hist USB timer: use uniqe naming in order not to confuse STAM on USB hotplug, bugref:10021.

File:

• trunk/src/VBox/VMM/VMMR3/PDMUsb.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR3/PDMUsb.cpp

@@ -1831 +1831 @@
     char szName[32];
     AssertReturn(strlen(pszDesc) < sizeof(szName) - 8, VERR_INVALID_NAME);
-    if (pUsbIns->iInstance > 0)
-    {
-        RTStrPrintf(szName, sizeof(szName), "%s[%u:%s]", pszDesc, pUsbIns->iInstance, pUsbIns->Internal.s.pUsbDev->pReg->szName);
-        pszDesc = szName;
-    }
+    /* Try to use unique names for USB timers in order not to confuse STAM (see xtracker#10021). */
+    RTStrPrintf(szName, sizeof(szName), "%s[%u:%s]", pszDesc, pUsbIns->iInstance, pUsbIns->Internal.s.pUsbDev->pReg->szName);
+    pszDesc = szName;
 
     int rc = TMR3TimerCreateUsb(pVM, pUsbIns, enmClock, pfnCallback, pvUser, fFlags, pszDesc, phTimer);