Changeset 89692 in vbox for trunk/src/VBox/Devices/Audio

Timestamp:

Jun 14, 2021 8:54:07 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

145140

Message:

DevIchAc97: Don't recheck sink active status in ichac97R3StreamUpdateDma, caller already does that. bugref:9890

File:

• trunk/src/VBox/Devices/Audio/DevIchAc97.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

@@ -1320 +1320 @@
  */
 static void ichac97R3StreamUpdateDma(PPDMDEVINS pDevIns, PAC97STATE pThis, PAC97STATER3 pThisCC,
-                                     PAC97STREAM pStream, PAC97STREAMR3 pStreamCC)
-{
-    /*
-     * Make sure we're running and got an active mixer sink.
-     */
-    PAUDMIXSINK pSink = ichac97R3IndexToSink(pThisCC, pStream->u8SD); /** @todo caller will need + check this too afterwards... */
-    AssertPtr(pSink);
-    if (RT_LIKELY(AudioMixerSinkIsActive(pSink)))
-    { /* likely */ }
-    else
-        return;
-
+                                     PAC97STREAM pStream, PAC97STREAMR3 pStreamCC, PAUDMIXSINK pSink)
+{
+    RT_NOREF(pThisCC);
     int rc2;
 
@@ -2551 +2542 @@
     if (pSink && AudioMixerSinkIsActive(pSink))
     {
-        ichac97R3StreamUpdateDma(pDevIns, pThis, pThisCC, pStream, pStreamCC);
+        ichac97R3StreamUpdateDma(pDevIns, pThis, pThisCC, pStream, pStreamCC, pSink);
 
         ichac97R3StreamTransferUpdate(pDevIns, pStream, pStreamCC);