Changeset 89873 in vbox for trunk

Timestamp:

Jun 24, 2021 9:11:18 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

145331

Message:

DevHda: Removed now obsolete config values: PosAdjustEnabled, PosAdjustFrames and TransferHeuristicsEnabled. bugref:9890

Location:

trunk/src/VBox/Devices/Audio

Files:

• DevHda.cpp (modified) (2 diffs)
• DevHda.h (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DevHda.cpp

@@ -4754 +4754 @@
                                   "|InitialDelayMs"
                                   "|TimerHz"
-                                  "|PosAdjustEnabled"
-                                  "|PosAdjustFrames"
-                                  "|TransferHeuristicsEnabled"
                                   "|DebugEnabled"
                                   "|DebugPathOut",
@@ -4802 +4799 @@
         return PDMDevHlpVMSetError(pDevIns, rc, RT_SRC_POS,
                                    N_("HDA configuration error: Out of range: 0 <= InitialDelayMs < 256: %u"), pThis->msInitialDelay);
-
-    /** @todo fPosAdjustEnabled is not honored anymore.   */
-    rc = pHlp->pfnCFGMQueryBoolDef(pCfg, "PosAdjustEnabled", &pThis->fPosAdjustEnabled, true);
-    if (RT_FAILURE(rc))
-        return PDMDEV_SET_ERROR(pDevIns, rc,
-                                N_("HDA configuration error: failed to read position adjustment enabled as boolean"));
-    if (!pThis->fPosAdjustEnabled)
-        LogRel(("HDA: Position adjustment is disabled\n"));
-
-    /** @todo cPosAdjustFrames is not consulted anymore.   */
-    rc = pHlp->pfnCFGMQueryU16Def(pCfg, "PosAdjustFrames", &pThis->cPosAdjustFrames, HDA_POS_ADJUST_DEFAULT);
-    if (RT_FAILURE(rc))
-        return PDMDEV_SET_ERROR(pDevIns, rc,
-                                N_("HDA configuration error: failed to read position adjustment frames as unsigned integer"));
-    if (pThis->cPosAdjustFrames)
-        LogRel(("HDA: Using custom position adjustment (%RU16 audio frames)\n", pThis->cPosAdjustFrames));
-
-    /** @todo fTransferHeuristicsEnabled is not used anymore.   */
-    rc = pHlp->pfnCFGMQueryBoolDef(pCfg, "TransferHeuristicsEnabled", &pThis->fTransferHeuristicsEnabled, true);
-    if (RT_FAILURE(rc))
-        return PDMDEV_SET_ERROR(pDevIns, rc,
-                                N_("HDA configuration error: failed to read data transfer heuristics enabled as boolean"));
-    if (!pThis->fTransferHeuristicsEnabled)
-        LogRel(("HDA: Data transfer heuristics are disabled\n"));
 
     rc = pHlp->pfnCFGMQueryBoolDef(pCfg, "DebugEnabled", &pThisCC->Dbg.fEnabled, false);

trunk/src/VBox/Devices/Audio/DevHda.h

@@ -125 +125 @@
     /** Response Interrupt Count (RINTCNT). */
     uint16_t                u16RespIntCnt;
-    /** Position adjustment (in audio frames).
-     *
-     *  This is not an official feature of the HDA specs, but used by
-     *  certain OS drivers (e.g. snd_hda_intel) to work around certain
-     *  quirks by "real" HDA hardware implementations.
-     *
-     *  The position adjustment specifies how many audio frames
-     *  a stream is ahead from its actual reading/writing position when
-     *  starting a stream.
-     */
-    uint16_t                cPosAdjustFrames;
-    /** Whether the position adjustment is enabled or not. */
-    bool                    fPosAdjustEnabled;
-    /** Whether data transfer heuristics are enabled or not.
-     *  This tries to determine the approx. data rate a guest audio driver expects. */
-    bool                    fTransferHeuristicsEnabled;
     /** DMA position buffer enable bit. */
     bool                    fDMAPosition;
     /** Current IRQ level. */
     uint8_t                 u8IRQL;
+    uint8_t                 abPadding[4];
     /** The device timer Hz rate. Defaults to HDA_TIMER_HZ_DEFAULT. */
     uint16_t                uTimerHz;