Changeset 89888 in vbox

Timestamp:

Jun 24, 2021 12:52:47 PM (4 years ago)

Author:

vboxsync

Message:

DevHda: Moved the HDA_SAVED_STATE_XXX defines to DevHda.h (no idea why it was in the codec header). bugref:9890

Location:

trunk/src/VBox/Devices/Audio

Files:

• DevHda.h (modified) (3 diffs)
• DevHdaCodec.h (modified) (1 diff)

trunk/src/VBox/Devices/Audio/DevHda.h

@@ -124 +124 @@
     uint32_t        writable;
     /** Register descriptor (RD) flags of type HDA_RD_F_XXX. These are used to
-     *  specify the handling (read/write) policy of the register. */
+     *  specify the read/write handling policy of the register. */
     uint32_t        fFlags;
     /** Read callback. */
@@ -166 +166 @@
  * HDA_REG_xxx macros (also HDA_REG_IND_NAME()).
  *
- * The au32Regs[] layout is kept unchanged for saved state
- * compatibility.
+ * The au32Regs[] layout is kept unchanged for saved state compatibility.
  */
 
@@ -827 +826 @@
 uint8_t hdaSDFIFOWToBytes(uint16_t u16RegFIFOW);
 
+
+
+/** @name Saved state versions for the HDA device
+ * @{ */
+/** The current staved state version.
+ * @note Only for the registration call.  Never used for tests. */
+#define HDA_SAVED_STATE_VERSION         HDA_SAVED_STATE_WITHOUT_PERIOD
+
+/** Removed period and redefined wall clock. */
+#define HDA_SAVED_STATE_WITHOUT_PERIOD  8
+/** Added (Controller):              Current wall clock value (this independent from WALCLK register value).
+  * Added (Controller):              Current IRQ level.
+  * Added (Per stream):              Ring buffer. This is optional and can be skipped if (not) needed.
+  * Added (Per stream):              Struct g_aSSMStreamStateFields7.
+  * Added (Per stream):              Struct g_aSSMStreamPeriodFields7.
+  * Added (Current BDLE per stream): Struct g_aSSMBDLEDescFields7.
+  * Added (Current BDLE per stream): Struct g_aSSMBDLEStateFields7. */
+#define HDA_SAVED_STATE_VERSION_7       7
+/** Saves the current BDLE state.
+ * @since 5.0.14 (r104839) */
+#define HDA_SAVED_STATE_VERSION_6       6
+/** Introduced dynamic number of streams + stream identifiers for serialization.
+ *  Bug: Did not save the BDLE states correctly.
+ *  Those will be skipped on load then.
+ * @since 5.0.12 (r104520)  */
+#define HDA_SAVED_STATE_VERSION_5       5
+/** Since this version the number of MMIO registers can be flexible. */
+#define HDA_SAVED_STATE_VERSION_4       4
+#define HDA_SAVED_STATE_VERSION_3       3
+#define HDA_SAVED_STATE_VERSION_2       2
+#define HDA_SAVED_STATE_VERSION_1       1
+/** @} */
+
 #endif /* !VBOX_INCLUDED_SRC_Audio_DevHda_h */
 

trunk/src/VBox/Devices/Audio/DevHdaCodec.h

@@ -957 +957 @@
 void hdaCodecReset(PHDACODEC pThis);
 
-/** @name DevHDA saved state versions
- * @{ */
-/** The current staved state version. */
-#define HDA_SAVED_STATE_VERSION  HDA_SAVED_STATE_WITHOUT_PERIOD
-
-/** Removed period and redefined wall clock. */
-#define HDA_SAVED_STATE_WITHOUT_PERIOD 8
-/** Added (Controller):              Current wall clock value (this independent from WALCLK register value).
-  * Added (Controller):              Current IRQ level.
-  * Added (Per stream):              Ring buffer. This is optional and can be skipped if (not) needed.
-  * Added (Per stream):              Struct g_aSSMStreamStateFields7.
-  * Added (Per stream):              Struct g_aSSMStreamPeriodFields7.
-  * Added (Current BDLE per stream): Struct g_aSSMBDLEDescFields7.
-  * Added (Current BDLE per stream): Struct g_aSSMBDLEStateFields7. */
-#define HDA_SAVED_STATE_VERSION_7 7
-/** Saves the current BDLE state.
- * @since 5.0.14 (r104839) */
-#define HDA_SAVED_STATE_VERSION_6 6
-/** Introduced dynamic number of streams + stream identifiers for serialization.
- *  Bug: Did not save the BDLE states correctly.
- *  Those will be skipped on load then.
- * @since 5.0.12 (r104520)  */
-#define HDA_SAVED_STATE_VERSION_5 5
-/** Since this version the number of MMIO registers can be flexible. */
-#define HDA_SAVED_STATE_VERSION_4 4
-#define HDA_SAVED_STATE_VERSION_3 3
-#define HDA_SAVED_STATE_VERSION_2 2
-#define HDA_SAVED_STATE_VERSION_1 1
-/** @} */
-
 #endif /* !VBOX_INCLUDED_SRC_Audio_DevHdaCodec_h */