Changeset 90309 in vbox

Timestamp:

Jul 23, 2021 2:04:22 PM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

145865

Message:

DevIoApic: Tenative fix for re-triggering edge interrupts in EOI callback. bugref:10073 oem2ticketref:43

File:

• trunk/src/VBox/Devices/PC/DevIoApic.cpp (modified) (1 diff)

trunk/src/VBox/Devices/PC/DevIoApic.cpp

@@ -875 +875 @@
     {
         uint64_t const u64Rte = pThis->au64RedirTable[idxRte];
-/** @todo r=bird: bugref:10073: Ignore edge triggered entries here since
- * the APIC will only call us for those?  Not doing so confuses ended up
- * with spurious HPET/RTC IRQs in SMP linux because of it sharing the vector
- * with a level-triggered IRQ (like vboxguest) delivered on a different CPU.
- * Alternatively, make the call specify the APIC number of use that in the
- * filter too/instead. */
-        if (IOAPIC_RTE_GET_VECTOR(u64Rte) == u8Vector)
+/** @todo r=bird: bugref:10073: I've changed it to ignore edge triggered
+ * entries here since the APIC will only call us for those?  Not doing so
+ * confuses ended up with spurious HPET/RTC IRQs in SMP linux because of it
+ * sharing the vector with a level-triggered IRQ (like vboxguest) delivered on a
+ * different CPU.
+ *
+ * Maybe we should also/instead filter on the source APIC number? */
+        if (   IOAPIC_RTE_GET_VECTOR(u64Rte) == u8Vector
+            && IOAPIC_RTE_GET_TRIGGER_MODE(u64Rte) != IOAPIC_RTE_TRIGGER_MODE_EDGE)
         {
 #ifdef DEBUG_ramshankar