Changeset 90691 in vbox for trunk/src/VBox

Timestamp:

Aug 16, 2021 8:43:03 AM (3 years ago)

Author:

vboxsync

Message:

pdmifs: display reporting doxygen (brief + newline + detailed description) and parameter type+name.

Location:

trunk/src/VBox/Main

Files:

• include/DisplayImpl.h (modified) (1 diff)
• src-client/DisplayImpl.cpp (modified) (1 diff)
• src-client/VMMDevInterface.cpp (modified) (1 diff)

trunk/src/VBox/Main/include/DisplayImpl.h

@@ -164 +164 @@
     int  i_saveVisibleRegion(uint32_t cRect, PRTRECT pRect);
     int  i_handleSetVisibleRegion(uint32_t cRect, PRTRECT pRect);
-    int  i_handleUpdateMonitorPositions(uint32_t cPositions, PRTPOINT pPosition);
+    int  i_handleUpdateMonitorPositions(uint32_t cPositions, PCRTPOINT paPositions);
     int  i_handleQueryVisibleRegion(uint32_t *pcRects, PRTRECT paRects);
 

trunk/src/VBox/Main/src-client/DisplayImpl.cpp

@@ -1280 +1280 @@
 }
 
-int  Display::i_handleUpdateMonitorPositions(uint32_t cPositions, PRTPOINT pPosition)
-{
-    AssertMsgReturn(pPosition, ("Empty monitor position array\n"), E_INVALIDARG);
+int  Display::i_handleUpdateMonitorPositions(uint32_t cPositions, PCRTPOINT paPositions)
+{
+    AssertMsgReturn(paPositions, ("Empty monitor position array\n"), E_INVALIDARG);
     for (unsigned i = 0; i < cPositions; ++i)
         LogRel2(("Display::i_handleUpdateMonitorPositions: uScreenId=%d xOrigin=%d yOrigin=%dX\n",
-                 i, pPosition[i].x, pPosition[i].y));
+                 i, paPositions[i].x, paPositions[i].y));
 
     if (mpDrv && mpDrv->pUpPort->pfnReportMonitorPositions)
-        mpDrv->pUpPort->pfnReportMonitorPositions(mpDrv->pUpPort, cPositions, pPosition);
+        mpDrv->pUpPort->pfnReportMonitorPositions(mpDrv->pUpPort, cPositions, paPositions);
     return VINF_SUCCESS;
 }

trunk/src/VBox/Main/src-client/VMMDevInterface.cpp

@@ -461 +461 @@
 }
 
-DECLCALLBACK(int) vmmdevUpdateMonitorPositions(PPDMIVMMDEVCONNECTOR pInterface, uint32_t cPositions, PRTPOINT pPositions)
-{
-    PDRVMAINVMMDEV pDrv = RT_FROM_MEMBER(pInterface, DRVMAINVMMDEV, Connector);
-    Console *pConsole = pDrv->pVMMDev->getParent();
-
-    pConsole->i_getDisplay()->i_handleUpdateMonitorPositions(cPositions, pPositions);
+/**
+ * @interface_method_impl{PDMIVMMDEVCONNECTOR,pfnUpdateMonitorPositions}
+ */
+static DECLCALLBACK(int) vmmdevUpdateMonitorPositions(PPDMIVMMDEVCONNECTOR pInterface, uint32_t cPositions, PCRTPOINT paPositions)
+{
+    PDRVMAINVMMDEV pDrv = RT_FROM_MEMBER(pInterface, DRVMAINVMMDEV, Connector);
+    Console *pConsole = pDrv->pVMMDev->getParent();
+
+    pConsole->i_getDisplay()->i_handleUpdateMonitorPositions(cPositions, paPositions);
 
     return VINF_SUCCESS;