Changeset 92261 in vbox for trunk/src/VBox/Devices/Audio/AudioTest.cpp

Timestamp:

Nov 8, 2021 10:31:38 AM (3 years ago)

Author:

vboxsync

Message:

Audio/Validation Kit: A bit more sanity checking in AudioTestSetClose(). bugref:10008

File:

• trunk/src/VBox/Devices/Audio/AudioTest.cpp (modified) (5 diffs)

trunk/src/VBox/Devices/Audio/AudioTest.cpp

@@ -1178 +1178 @@
         /* Update number of bound test objects. */
         PAUDIOTESTENTRY pTest;
+        uint32_t        cTests = 0;
         RTListForEach(&pSet->lstTest, pTest, AUDIOTESTENTRY, Node)
         {
@@ -1184 +1185 @@
             rc = audioTestManifestWrite(pSet, "%04RU32", pTest->cObj);
             AssertRCReturn(rc, rc);
+            cTests++; /* Sanity checking. */
         }
 
+        AssertMsgReturn(pSet->cTests == cTests, ("Test count and list don't match"), VERR_INTERNAL_ERROR);
+
         /*
-         * Update number of ran tests.
+         * Update number of total objects.
          */
         rc = RTFileSeek(pSet->f.hFile, pSet->offObjCount, RTFILE_SEEK_BEGIN, NULL);
@@ -1195 +1199 @@
 
         /*
-         * Update number of ran tests.
+         * Update number of total tests.
          */
         rc = RTFileSeek(pSet->f.hFile, pSet->offTestCount, RTFILE_SEEK_BEGIN, NULL);
@@ -1209 +1213 @@
 
         PAUDIOTESTOBJINT pObj;
+        uint32_t         cObj = 0;
         RTListForEach(&pSet->lstObj, pObj, AUDIOTESTOBJINT, Node)
         {
@@ -1261 +1266 @@
                 }
             }
+
+            cObj++; /* Sanity checking. */
         }
+
+        AssertMsgReturn(pSet->cObj == cObj, ("Object count and list don't match"), VERR_INTERNAL_ERROR);
 
         int rc2 = RTFileClose(pSet->f.hFile);