Changeset 92873 in vbox for trunk/src/VBox/Runtime/r0drv/nt/mp-r0drv-nt.cpp

Timestamp:

Dec 11, 2021 1:38:33 AM (3 years ago)

Author:

vboxsync

Message:

IPRT/timer-r0drv-nt.cpp,mp-r0drv-nt.cpp: Work around rtMpNtSetTargetProcessorDpc failure on systems with sparse CPU ID assignments (like on testboxmem1). For timers, if the function fails for an offline CPU, just defer the DPC setup.

File:

• trunk/src/VBox/Runtime/r0drv/nt/mp-r0drv-nt.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/r0drv/nt/mp-r0drv-nt.cpp

@@ -1350 +1350 @@
  *
  * @returns IPRT status code (errors are asserted).
+ * @retval  VERR_CPU_NOT_FOUND if impossible CPU. Not asserted.
  * @param   pDpc                The DPC.
  * @param   idCpu               The ID of the new target CPU.
+ * @note    Callable at any IRQL.
  */
 DECLHIDDEN(int) rtMpNtSetTargetProcessorDpc(KDPC *pDpc, RTCPUID idCpu)
@@ -1361 +1363 @@
         PROCESSOR_NUMBER ProcNum;
         NTSTATUS rcNt = g_pfnrtKeGetProcessorNumberFromIndex(RTMpCpuIdToSetIndex(idCpu), &ProcNum);
-        AssertLogRelMsgReturn(NT_SUCCESS(rcNt), ("KeGetProcessorNumberFromIndex(%u) -> %#x\n", idCpu, rcNt),
-                              RTErrConvertFromNtStatus(rcNt));
-
-        rcNt = g_pfnrtKeSetTargetProcessorDpcEx(pDpc, &ProcNum);
-        AssertLogRelMsgReturn(NT_SUCCESS(rcNt),
-                              ("KeSetTargetProcessorDpcEx(,%u(%u/%u)) -> %#x\n", idCpu, ProcNum.Group, ProcNum.Number, rcNt),
-                              RTErrConvertFromNtStatus(rcNt));
+        if (NT_SUCCESS(rcNt))
+        {
+            rcNt = g_pfnrtKeSetTargetProcessorDpcEx(pDpc, &ProcNum);
+            AssertLogRelMsgReturn(NT_SUCCESS(rcNt),
+                                  ("KeSetTargetProcessorDpcEx(,%u(%u/%u)) -> %#x\n", idCpu, ProcNum.Group, ProcNum.Number, rcNt),
+                                  RTErrConvertFromNtStatus(rcNt));
+        }
+        else if (rcNt == STATUS_INVALID_PARAMETER)
+            return VERR_CPU_NOT_FOUND;
+        else
+            AssertLogRelMsgReturn(NT_SUCCESS(rcNt), ("KeGetProcessorNumberFromIndex(%u) -> %#x\n", idCpu, rcNt),
+                                  RTErrConvertFromNtStatus(rcNt));
+
     }
     else if (g_pfnrtKeSetTargetProcessorDpc)
@@ -1936 +1944 @@
                 g_pfnrtKeSetImportanceDpc(&s_aPokeDpcs[i], HighImportance);
             int rc = rtMpNtSetTargetProcessorDpc(&s_aPokeDpcs[i], idCpu);
-            if (RT_FAILURE(rc))
+            if (RT_FAILURE(rc) && rc != VERR_CPU_NOT_FOUND)
                 return rc;
         }