Changeset 93121 in vbox for trunk/src/VBox/Main/src-server/UnattendedScript.cpp

Timestamp:

Jan 4, 2022 2:58:46 AM (3 years ago)

Author:

vboxsync

Message:

Main/UnattendedScript: Added two todo that needs looking at. bugref:9781

File:

• trunk/src/VBox/Main/src-server/UnattendedScript.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/UnattendedScript.cpp

@@ -539 +539 @@
     {
         //parse the placeholder and extract the OS version from there
-        RTCString strPlaceHolder(pachPlaceholder);
+        RTCString strPlaceHolder(pachPlaceholder); /** @todo r=bird: What's the meaning of duplicating the rest of the script here
+                                                    * when you could just add cchPlaceholder to the parameter list and limit it to
+                                                    * what is actually needed.  OTOH it's really not needed to make copies here,
+                                                    * validating the "[" can be done in the partial match above and "]@@" by using
+                                                    * cchPlaceholder, what you wnat to get at is inbetween and does not need
+                                                    * two copies (only one for RTStrVersionCompare). */
         size_t startPos = sizeof("@@VBOX_COND_GUEST_VERSION") - 1;//-1 is for '\n'
         size_t endPos = strPlaceHolder.find("@@", startPos + 2);
@@ -548 +553 @@
         //The end of placeholder is "@@" like for others.
 
+        /** @todo r=bird: What kind of syntax checking is this? Ignore any kind of
+         *        mistyped stuff and let the user figure out what he did wrong
+         *        without clues?  Lazy. */
         if ( strPlaceHolder[endPos] == '@'
              && strPlaceHolder[endPos+1] == '@' )