Changeset 94129 in vbox for trunk/src/VBox/ValidationKit/testmanager/core/testboxcontroller.py

Timestamp:

Mar 8, 2022 2:57:25 PM (3 years ago)

Author:

vboxsync

Message:

testmanager: pylint 2.9.6 adjustments (mostly about using sub-optimal looping and 'with' statements).

File:

• trunk/src/VBox/ValidationKit/testmanager/core/testboxcontroller.py (modified) (1 diff)

trunk/src/VBox/ValidationKit/testmanager/core/testboxcontroller.py

@@ -327 +327 @@
         if not os.path.exists(os.path.dirname(sFile)):
             os.makedirs(os.path.dirname(sFile), 0o755);
-        oFile = open(sFile, 'ab');
-
-        # Check the size.
-        fSizeOk = True;
-        if not fIgnoreSizeCheck:
-            oStat = os.fstat(oFile.fileno());
-            fSizeOk = oStat.st_size / (1024 * 1024) < config.g_kcMbMaxMainLog;
-
-        # Write the text.
-        if fSizeOk:
-            if sys.version_info[0] >= 3:
-                oFile.write(bytes(sText, 'utf-8'));
-            else:
-                oFile.write(sText);
-
-        # Done
-        oFile.close();
+
+        with open(sFile, 'ab') as oFile:
+            # Check the size.
+            fSizeOk = True;
+            if not fIgnoreSizeCheck:
+                oStat = os.fstat(oFile.fileno());
+                fSizeOk = oStat.st_size / (1024 * 1024) < config.g_kcMbMaxMainLog;
+
+            # Write the text.
+            if fSizeOk:
+                if sys.version_info[0] >= 3:
+                    oFile.write(bytes(sText, 'utf-8'));
+                else:
+                    oFile.write(sText);
+
         return fSizeOk;