Changeset 94129 in vbox for trunk/src/VBox/ValidationKit/testmanager/core/webservergluebase.py

Timestamp:

Mar 8, 2022 2:57:25 PM (3 years ago)

Author:

vboxsync

Message:

testmanager: pylint 2.9.6 adjustments (mostly about using sub-optimal looping and 'with' statements).

File:

• trunk/src/VBox/ValidationKit/testmanager/core/webservergluebase.py (modified) (3 diffs)

trunk/src/VBox/ValidationKit/testmanager/core/webservergluebase.py

@@ -138 +138 @@
         self._oDbgFile         = sys.stderr;
         if config.g_ksSrvGlueDebugLogDst is not None and config.g_kfSrvGlueDebug is True:
-            self._oDbgFile = open(config.g_ksSrvGlueDebugLogDst, 'a');
+            self._oDbgFile = open(config.g_ksSrvGlueDebugLogDst, 'a');  # pylint: disable=consider-using-with
             if config.g_kfSrvGlueCgiDumpArgs:
                 self._oDbgFile.write('Arguments: %s\nEnvironment:\n' % (sys.argv,));
@@ -303 +303 @@
         """
         if self._fHeaderWrittenOut is False:
-            for sKey in self._dHeaderFields:
-                self._writeHeader('%s: %s\n' % (sKey, self._dHeaderFields[sKey]));
+            for sKey, sValue in self._dHeaderFields.items():
+                self._writeHeader('%s: %s\n' % (sKey, sValue,));
             self._fHeaderWrittenOut = True;
             self._writeHeader('\n'); # End of header indicator.
@@ -462 +462 @@
 
         try:
-            oFile = open(sLogFile, 'w');
-            oFile.write(sError + '\n\n');
-            if aXcptInfo[0] is not None:
-                oFile.write(' B a c k t r a c e\n');
-                oFile.write('===================\n');
-                oFile.write(cgitb.text(aXcptInfo, 5));
-                oFile.write('\n\n');
-
-            oFile.write(' D e b u g   I n f o\n');
-            oFile.write('=====================\n\n');
-            self._fHtmlDebugOutput = False;
-            self.debugDumpStuff(oFile.write);
-
-            oFile.close();
+            with open(sLogFile, 'w') as oFile:
+                oFile.write(sError + '\n\n');
+                if aXcptInfo[0] is not None:
+                    oFile.write(' B a c k t r a c e\n');
+                    oFile.write('===================\n');
+                    oFile.write(cgitb.text(aXcptInfo, 5));
+                    oFile.write('\n\n');
+
+                oFile.write(' D e b u g   I n f o\n');
+                oFile.write('=====================\n\n');
+                self._fHtmlDebugOutput = False;
+                self.debugDumpStuff(oFile.write);
         except:
             fRc = False;