Changeset 94996 in vbox for trunk/src/VBox/Devices/Audio/AudioMixer.cpp

Timestamp:

May 12, 2022 3:22:23 PM (3 years ago)

Author:

vboxsync

Message:

Audio/Mixer: Also need to take the sink's critical section when audioMixerSinkRemoveStreamInternal() is being invoked from AudioMixerDestroy() or AudioMixerSinkDestroy(), without explicitly destroying attached mixer streams before via AudioMixerStreamDestroy() or AudioMixerSinkRemoveAllStreams().

File:

• trunk/src/VBox/Devices/Audio/AudioMixer.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/AudioMixer.cpp

@@ -672 +672 @@
     pSink->uMagic = AUDMIXSINK_MAGIC_DEAD;
 
+    int rc = RTCritSectEnter(&pSink->CritSect);
+    AssertRCReturnVoid(rc);
+
     /*
      * Destroy all streams.
@@ -681 +684 @@
         audioMixerStreamDestroyInternal(pStream, pDevIns, true /*fImmediate*/);
     }
+
+    rc = RTCritSectLeave(&pSink->CritSect);
+    AssertRCReturnVoid(rc);
 
     /*