Changeset 95057 in vbox

Timestamp:

May 23, 2022 9:15:10 AM (3 years ago)

Author:

vboxsync

Message:

DevATA: More consistently set ATA_STAT_SEEK on command completion so as to not upset old guests which expect to see it set.

Location:

trunk/src/VBox/Devices/Storage

Files:

• DevATA.cpp (modified) (4 diffs)
• DevFdc.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -4381 +4381 @@
                 Log2(("%s: set multi sector count to %d\n", __FUNCTION__, s->uATARegNSector));
                 s->cMultSectors = s->uATARegNSector;
-                ataR3CmdOK(pCtl, s, 0);
+                ataR3CmdOK(pCtl, s, ATA_STAT_SEEK);
             }
             ataHCSetIRQ(pDevIns, pCtl, s); /* Shortcut, do not use AIO thread. */
@@ -4465 +4465 @@
             s->fLBA48 = true;
             ataR3SetSector(s, s->cTotalSectors - 1);
-            ataR3CmdOK(pCtl, s, 0);
+            ataR3CmdOK(pCtl, s, ATA_STAT_SEEK);
             ataHCSetIRQ(pDevIns, pCtl, s); /* Shortcut, do not use AIO thread. */
             break;
         case ATA_SEEK: /* Used by the SCO OpenServer. Command is marked as obsolete */
-            ataR3CmdOK(pCtl, s, 0);
+            ataR3CmdOK(pCtl, s, ATA_STAT_SEEK);
             ataHCSetIRQ(pDevIns, pCtl, s); /* Shortcut, do not use AIO thread. */
             break;
@@ -4476 +4476 @@
                 goto abort_cmd;
             ataR3SetSector(s, RT_MIN(s->cTotalSectors, 1 << 28) - 1);
-            ataR3CmdOK(pCtl, s, 0);
+            ataR3CmdOK(pCtl, s, ATA_STAT_SEEK);
             ataHCSetIRQ(pDevIns, pCtl, s); /* Shortcut, do not use AIO thread. */
             break;
@@ -5989 +5989 @@
                     {
                         Assert(iSourceSink == ATAFN_SS_NULL);
-                        ataR3CmdOK(pCtl, s, 0);
+                        ataR3CmdOK(pCtl, s, ATA_STAT_SEEK);
                     }
                     s->iIOBufferEnd = s->cbElementaryTransfer;

trunk/src/VBox/Devices/Storage/DevFdc.cpp

@@ -784 +784 @@
         break;
     case FD_REG_DSR:
+#if 0
         fdctrl_write_rate(fdctrl, value);
+#else
+        fdctrl_write_data(fdctrl, value);
+#endif
         break;
     case FD_REG_FIFO: