Changeset 95328 in vbox for trunk/src/VBox/Additions/common/pam/pam_vbox.cpp

Timestamp:

Jun 21, 2022 2:42:41 PM (3 years ago)

Author:

vboxsync

Message:

GA/pam_vbox.cpp: Fixed leak in pam_vbox_wait_prop.

File:

• trunk/src/VBox/Additions/common/pam/pam_vbox.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/common/pam/pam_vbox.cpp

@@ -503 +503 @@
     uint32_t cbBuf = GUEST_PROP_MAX_NAME_LEN + GUEST_PROP_MAX_VALUE_LEN + GUEST_PROP_MAX_FLAGS_LEN + _1K;
 
-    for (int i = 0; i < 10; i++)
+    for (int i = 0; ; i++)
     {
         void *pvTmpBuf = RTMemRealloc(pvBuf, cbBuf);
@@ -518 +518 @@
                                      &pszName, &pszValue, &u64TimestampOut,
                                      &pszFlags, &cbBuf, NULL /* pfWasDeleted */);
+            if (rc == VERR_BUFFER_OVERFLOW && i < 10)
+            {
+                cbBuf += _1K; /* Buffer too small, try it with a bigger one more time. */
+                continue;
+            }
         }
         else
             rc = VERR_NO_MEMORY;
-
-        if (rc == VERR_BUFFER_OVERFLOW)
-        {
-            /* Buffer too small, try it with a bigger one next time. */
-            cbBuf += _1K;
-            continue; /* Try next round. */
-        }
-
-        /* Everything except VERR_BUFFER_OVERLOW makes us bail out ... */
         break;
     }
 
+    RTMemFree(pvBuf);
     return rc;
 }